| Message ID | 20230716004616.21838-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/connector: mark enum counter value as private | expand |
Hi, On 7/15/23 17:46, Randy Dunlap wrote: > Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in > kernel-doc to prevent a build warning: > > include/drm/drm_connector.h:527: warning: Enum value 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorspace' > > Fixes: c627087cb164 ("drm/connector: Use common colorspace_names array") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: dri-devel@lists.freedesktop.org > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: amd-gfx@lists.freedesktop.org > --- > include/drm/drm_connector.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20230714.orig/include/drm/drm_connector.h > +++ linux-next-20230714/include/drm/drm_connector.h > @@ -522,7 +522,7 @@ enum drm_colorspace { > DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13, > DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14, > DRM_MODE_COLORIMETRY_BT601_YCC = 15, > - /* not a valid value; merely used for counting */ > + /* private: not a valid value; merely used for counting */ > DRM_MODE_COLORIMETRY_COUNT > }; > Any comments on this patch? The warning is still present in mainline. The "private:" marker tells kernel-doc not to expect documentation for it. thanks.
--- linux-next-20230714.orig/include/drm/drm_connector.h +++ linux-next-20230714/include/drm/drm_connector.h @@ -522,7 +522,7 @@ enum drm_colorspace { DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13, DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14, DRM_MODE_COLORIMETRY_BT601_YCC = 15, - /* not a valid value; merely used for counting */ + /* private: not a valid value; merely used for counting */ DRM_MODE_COLORIMETRY_COUNT };
Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in kernel-doc to prevent a build warning: include/drm/drm_connector.h:527: warning: Enum value 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorspace' Fixes: c627087cb164 ("drm/connector: Use common colorspace_names array") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: dri-devel@lists.freedesktop.org Cc: Harry Wentland <harry.wentland@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: amd-gfx@lists.freedesktop.org --- include/drm/drm_connector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)