diff mbox series

[1/1] drm/imx/dcss: Use dev_err_probe

Message ID 20230717092950.448823-1-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/1] drm/imx/dcss: Use dev_err_probe | expand

Commit Message

Alexander Stein July 17, 2023, 9:29 a.m. UTC
This helps identifying problems with downstream pipeline devices, like
HDMI/DP output.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/gpu/drm/imx/dcss/dcss-drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurentiu Palcu July 28, 2023, 11:58 a.m. UTC | #1
Hi,

On Mon, Jul 17, 2023 at 11:29:50AM +0200, Alexander Stein wrote:
> This helps identifying problems with downstream pipeline devices, like
> HDMI/DP output.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

Pushed to drm-misc-next.

Thanks,
Laurentiu

> ---
>  drivers/gpu/drm/imx/dcss/dcss-drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c
> index 4f2291610139..c68b0d93ae9e 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-drv.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c
> @@ -66,6 +66,7 @@ static int dcss_drv_platform_probe(struct platform_device *pdev)
>         mdrv->kms = dcss_kms_attach(mdrv->dcss);
>         if (IS_ERR(mdrv->kms)) {
>                 err = PTR_ERR(mdrv->kms);
> +               dev_err_probe(dev, err, "Failed to initialize KMS\n");
>                 goto dcss_shutoff;
>         }
> 
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c
index 4f2291610139..c68b0d93ae9e 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-drv.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c
@@ -66,6 +66,7 @@  static int dcss_drv_platform_probe(struct platform_device *pdev)
 	mdrv->kms = dcss_kms_attach(mdrv->dcss);
 	if (IS_ERR(mdrv->kms)) {
 		err = PTR_ERR(mdrv->kms);
+		dev_err_probe(dev, err, "Failed to initialize KMS\n");
 		goto dcss_shutoff;
 	}