| Message ID | 20230718062854.29875-1-alex@shruggie.ro (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2] drm: adv7511: Fix low refresh rate register for ADV7533/5 | expand |
On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote: > From: Bogdan Togorean <bogdan.togorean@analog.com> > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533") > Reviewed-by: Nuno Sa <nuno.sa@analog.com> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com> > --- > It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :) - Nuno Sá > Changelog v1 -> v2: > * > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/ > * added Fixes: tag > * added Reviewed-by: tag for Nuno > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index ddceafa7b637..09290a377957 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511, > else > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE; > > - regmap_update_bits(adv7511->regmap, 0xfb, > - 0x6, low_refresh_rate << 1); > + if (adv7511->type == ADV7511) > + regmap_update_bits(adv7511->regmap, 0xfb, > + 0x6, low_refresh_rate << 1); > + else > + regmap_update_bits(adv7511->regmap, 0x4a, > + 0xc, low_refresh_rate << 2); > + > regmap_update_bits(adv7511->regmap, 0x17, > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5)); >
On Tue, Jul 18, 2023 at 10:00 AM Nuno Sá <noname.nuno@gmail.com> wrote: > > On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote: > > From: Bogdan Togorean <bogdan.togorean@analog.com> > > > > For ADV7533 and ADV7535 low refresh rate is selected using > > bits [3:2] of 0x4a main register. > > So depending on ADV model write 0xfb or 0x4a register. > > > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533") > > Reviewed-by: Nuno Sa <nuno.sa@analog.com> > > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com> > > --- > > > > It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :) oops; yes; will send a V3; thanks for the notification; > > - Nuno Sá > > > Changelog v1 -> v2: > > * > > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/ > > * added Fixes: tag > > * added Reviewed-by: tag for Nuno > > > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > index ddceafa7b637..09290a377957 100644 > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511, > > else > > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE; > > > > - regmap_update_bits(adv7511->regmap, 0xfb, > > - 0x6, low_refresh_rate << 1); > > + if (adv7511->type == ADV7511) > > + regmap_update_bits(adv7511->regmap, 0xfb, > > + 0x6, low_refresh_rate << 1); > > + else > > + regmap_update_bits(adv7511->regmap, 0x4a, > > + 0xc, low_refresh_rate << 2); > > + > > regmap_update_bits(adv7511->regmap, 0x17, > > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5)); > > >
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ddceafa7b637..09290a377957 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511, else low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE; - regmap_update_bits(adv7511->regmap, 0xfb, - 0x6, low_refresh_rate << 1); + if (adv7511->type == ADV7511) + regmap_update_bits(adv7511->regmap, 0xfb, + 0x6, low_refresh_rate << 1); + else + regmap_update_bits(adv7511->regmap, 0x4a, + 0xc, low_refresh_rate << 2); + regmap_update_bits(adv7511->regmap, 0x17, 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));