From patchwork Wed Jul 19 01:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Rusin X-Patchwork-Id: 13318049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11A2DEB64DD for ; Wed, 19 Jul 2023 01:42:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C921C10E3EF; Wed, 19 Jul 2023 01:42:38 +0000 (UTC) Received: from letterbox.kde.org (letterbox.kde.org [46.43.1.242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DFD410E3ED for ; Wed, 19 Jul 2023 01:42:32 +0000 (UTC) Received: from vertex.vmware.com (pool-173-49-113-140.phlapa.fios.verizon.net [173.49.113.140]) (Authenticated sender: zack) by letterbox.kde.org (Postfix) with ESMTPSA id ED71F32629D; Wed, 19 Jul 2023 02:42:29 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kde.org; s=users; t=1689730950; bh=qI5o564wKTDAHbBz4M1qvgS+Ng4J7DHrYPOXfzvG99o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQdxydbT3sB0LPAtJKfiwh3zXMWOQCamSY1mvcYQFrjcUd4mAIGR5h/bdhlsjj3Kt jtrVkhh8m1687E5GEoQ25l6CMzHiGJdGCBXQZNNdYmbnWxP27vVp6fJbwQAA+XtB/O 5USi/juxWO9UbpSgiozkCCCFOxdFJhQJP0g134gjgLKQIXFISE6NFic96R4lZIrT1B aP0Q7PCTtbzweBs/rmH++Gg01bcLc3gLBit08uJOL4JMBOErovry+RtgEqa2E7teAr r/Vsby+oy18ZJ/6mpSiKPDx/vAsZBS7mgyGiATmArs3RkhXoab7TopRg8h5JIUdNqi ogHm4BF3mGTzQ== From: Zack Rusin To: dri-devel@lists.freedesktop.org Subject: [PATCH v5 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes Date: Tue, 18 Jul 2023 21:42:12 -0400 Message-Id: <20230719014218.1700057-4-zack@kde.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230719014218.1700057-1-zack@kde.org> References: <20230719014218.1700057-1-zack@kde.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zack Rusin Cc: javierm@redhat.com, banackm@vmware.com, krastevm@vmware.com, ppaalanen@gmail.com, iforbes@vmware.com, mombasawalam@vmware.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Cc: Maaz Mombasawala Reviewed-by: Javier Martinez Canillas Reviewed-by: Martin Krastev --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index b62207be3363..de294dfe05d0 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -768,13 +768,8 @@ vmw_du_cursor_plane_atomic_update(struct drm_plane *plane, struct vmw_plane_state *old_vps = vmw_plane_state_to_vps(old_state); s32 hotspot_x, hotspot_y; - hotspot_x = du->hotspot_x; - hotspot_y = du->hotspot_y; - - if (new_state->fb) { - hotspot_x += new_state->fb->hot_x; - hotspot_y += new_state->fb->hot_y; - } + hotspot_x = du->hotspot_x + new_state->hotspot_x; + hotspot_y = du->hotspot_y + new_state->hotspot_y; du->cursor_surface = vps->surf; du->cursor_bo = vps->bo;