| Message ID | 20230719075056.72178-5-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: Small mtk-dpi cleanups | expand |
On Wed, Jul 19, 2023 at 3:51 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > The .remove() callback cannot fail: switch to .remove_new() and > change mtk_dpi_remove() to void. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Fei Shao <fshao@chromium.org>
Hi, Angelo: On Wed, 2023-07-19 at 09:50 +0200, AngeloGioacchino Del Regno wrote: > The .remove() callback cannot fail: switch to .remove_new() and > change mtk_dpi_remove() to void. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index e9c5a0f44537..3a140498c98a 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -1087,11 +1087,9 @@ static int mtk_dpi_probe(struct > platform_device *pdev) > return 0; > } > > -static int mtk_dpi_remove(struct platform_device *pdev) > +static void mtk_dpi_remove(struct platform_device *pdev) > { > component_del(&pdev->dev, &mtk_dpi_component_ops); > - > - return 0; > } > > static const struct of_device_id mtk_dpi_of_ids[] = { > @@ -1122,7 +1120,7 @@ MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids); > > struct platform_driver mtk_dpi_driver = { > .probe = mtk_dpi_probe, > - .remove = mtk_dpi_remove, > + .remove_new = mtk_dpi_remove, > .driver = { > .name = "mediatek-dpi", > .of_match_table = mtk_dpi_of_ids,
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index e9c5a0f44537..3a140498c98a 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -1087,11 +1087,9 @@ static int mtk_dpi_probe(struct platform_device *pdev) return 0; } -static int mtk_dpi_remove(struct platform_device *pdev) +static void mtk_dpi_remove(struct platform_device *pdev) { component_del(&pdev->dev, &mtk_dpi_component_ops); - - return 0; } static const struct of_device_id mtk_dpi_of_ids[] = { @@ -1122,7 +1120,7 @@ MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids); struct platform_driver mtk_dpi_driver = { .probe = mtk_dpi_probe, - .remove = mtk_dpi_remove, + .remove_new = mtk_dpi_remove, .driver = { .name = "mediatek-dpi", .of_match_table = mtk_dpi_of_ids,
The .remove() callback cannot fail: switch to .remove_new() and change mtk_dpi_remove() to void. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)