| Message ID | 20230727112407.2916029-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/msm: Remove redundant DRM_DEV_ERROR() | expand |
On 27/07/2023 14:24, Ruan Jinjie wrote: > There is no need to call the DRM_DEV_ERROR() function directly to print > a custom message when handling an error from platform_get_irq() function > as it is going to display an appropriate error message > in case of a failure. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 1 - > drivers/gpu/drm/msm/msm_gpu.c | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, 27 Jul 2023 11:24:07 +0000, Ruan Jinjie wrote: > There is no need to call the DRM_DEV_ERROR() function directly to print > a custom message when handling an error from platform_get_irq() function > as it is going to display an appropriate error message > in case of a failure. > > Applied, thanks! [1/1] drm/msm: Remove redundant DRM_DEV_ERROR() https://gitlab.freedesktop.org/lumag/msm/-/commit/f09f5459bd85 Best regards,
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c index b6201ae5b42e..700df4040e9a 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -417,7 +417,6 @@ static int mdp4_kms_init(struct drm_device *dev) irq = platform_get_irq(pdev, 0); if (irq < 0) { ret = irq; - DRM_DEV_ERROR(dev->dev, "failed to get irq: %d\n", ret); goto fail; } diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 52db90e34ead..8a9bacc920eb 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -897,7 +897,6 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, gpu->irq = platform_get_irq(pdev, 0); if (gpu->irq < 0) { ret = gpu->irq; - DRM_DEV_ERROR(drm->dev, "failed to get irq: %d\n", ret); goto fail; }
There is no need to call the DRM_DEV_ERROR() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 1 - drivers/gpu/drm/msm/msm_gpu.c | 1 - 2 files changed, 2 deletions(-)