| Message ID | 20230727113923.3093070-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm: omapdrm: dss: Remove redundant DSSERR() | expand |
Hello, On Thu, Jul 27, 2023 at 11:39:23AM +0000, Ruan Jinjie wrote: > There is no need to call the DSSERR() function directly to print > a custom message when handling an error from platform_get_irq() function > as it is going to display an appropriate error message > in case of a failure. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 1 - > drivers/gpu/drm/omapdrm/dss/dsi.c | 4 +--- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - > 4 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c > index c26aab4939fa..9209103f5dc5 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > @@ -4779,7 +4779,6 @@ static int dispc_bind(struct device *dev, struct device *master, void *data) > > dispc->irq = platform_get_irq(dispc->pdev, 0); > if (dispc->irq < 0) { > - DSSERR("platform_get_irq failed\n"); > r = -ENODEV; > goto err_free; > } Orthogonal to your patch I wonder about r = -ENODEV. Wouldn't r = dispc->irq be the sensible option? Ditto for the other hunks. Best regards Uwe
On 2023/7/27 14:57, Uwe Kleine-König wrote: > Hello, > > On Thu, Jul 27, 2023 at 11:39:23AM +0000, Ruan Jinjie wrote: >> There is no need to call the DSSERR() function directly to print >> a custom message when handling an error from platform_get_irq() function >> as it is going to display an appropriate error message >> in case of a failure. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/gpu/drm/omapdrm/dss/dispc.c | 1 - >> drivers/gpu/drm/omapdrm/dss/dsi.c | 4 +--- >> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - >> drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - >> 4 files changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c >> index c26aab4939fa..9209103f5dc5 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c >> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c >> @@ -4779,7 +4779,6 @@ static int dispc_bind(struct device *dev, struct device *master, void *data) >> >> dispc->irq = platform_get_irq(dispc->pdev, 0); >> if (dispc->irq < 0) { >> - DSSERR("platform_get_irq failed\n"); >> r = -ENODEV; >> goto err_free; >> } > > Orthogonal to your patch I wonder about r = -ENODEV. Wouldn't r = > dispc->irq be the sensible option? Ditto for the other hunks. I agree with you, r = dispc->irq will be more sensible! > > Best regards > Uwe >
Hi Ruan, Thank you for the patch. On Thu, Jul 27, 2023 at 11:39:23AM +0000, Ruan Jinjie wrote: > There is no need to call the DSSERR() function directly to print > a custom message when handling an error from platform_get_irq() function > as it is going to display an appropriate error message > in case of a failure. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I expect Tomi to pick this up and push it to drm-misc. > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 1 - > drivers/gpu/drm/omapdrm/dss/dsi.c | 4 +--- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - > 4 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c > index c26aab4939fa..9209103f5dc5 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > @@ -4779,7 +4779,6 @@ static int dispc_bind(struct device *dev, struct device *master, void *data) > > dispc->irq = platform_get_irq(dispc->pdev, 0); > if (dispc->irq < 0) { > - DSSERR("platform_get_irq failed\n"); > r = -ENODEV; > goto err_free; > } > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index ea63c64d3a1a..63cfe0776788 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4935,10 +4935,8 @@ static int dsi_probe(struct platform_device *pdev) > return PTR_ERR(dsi->pll_base); > > dsi->irq = platform_get_irq(pdev, 0); > - if (dsi->irq < 0) { > - DSSERR("platform_get_irq failed\n"); > + if (dsi->irq < 0) > return -ENODEV; > - } > > r = devm_request_irq(dev, dsi->irq, omap_dsi_irq_handler, > IRQF_SHARED, dev_name(dev), dsi); > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > index a26b77d99d52..d4fd6c680db3 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > @@ -782,7 +782,6 @@ static int hdmi4_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - DSSERR("platform_get_irq failed\n"); > r = -ENODEV; > goto err_free; > } > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > index e6611c683857..27c21ff8c4e5 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > @@ -756,7 +756,6 @@ static int hdmi5_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - DSSERR("platform_get_irq failed\n"); > r = -ENODEV; > goto err_free; > }
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c index c26aab4939fa..9209103f5dc5 100644 --- a/drivers/gpu/drm/omapdrm/dss/dispc.c +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c @@ -4779,7 +4779,6 @@ static int dispc_bind(struct device *dev, struct device *master, void *data) dispc->irq = platform_get_irq(dispc->pdev, 0); if (dispc->irq < 0) { - DSSERR("platform_get_irq failed\n"); r = -ENODEV; goto err_free; } diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index ea63c64d3a1a..63cfe0776788 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4935,10 +4935,8 @@ static int dsi_probe(struct platform_device *pdev) return PTR_ERR(dsi->pll_base); dsi->irq = platform_get_irq(pdev, 0); - if (dsi->irq < 0) { - DSSERR("platform_get_irq failed\n"); + if (dsi->irq < 0) return -ENODEV; - } r = devm_request_irq(dev, dsi->irq, omap_dsi_irq_handler, IRQF_SHARED, dev_name(dev), dsi); diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index a26b77d99d52..d4fd6c680db3 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c @@ -782,7 +782,6 @@ static int hdmi4_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - DSSERR("platform_get_irq failed\n"); r = -ENODEV; goto err_free; } diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index e6611c683857..27c21ff8c4e5 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c @@ -756,7 +756,6 @@ static int hdmi5_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - DSSERR("platform_get_irq failed\n"); r = -ENODEV; goto err_free; }
There is no need to call the DSSERR() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/gpu/drm/omapdrm/dss/dispc.c | 1 - drivers/gpu/drm/omapdrm/dss/dsi.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - 4 files changed, 1 insertion(+), 6 deletions(-)