| Message ID | 20230804-tc358768-v1-9-1afd44b7826b@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: tc358768: Fixes and timings improvements | expand |
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up > operation, but it misses subtracting one from the dividend. > > Fix this by just using DIV_ROUND_UP(). Reviewed-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> > Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > drivers/gpu/drm/bridge/tc358768.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 9411b0fb471e..dc2241c18dde 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -630,7 +630,7 @@ static int tc358768_setup_pll(struct tc358768_priv *priv, > > static u32 tc358768_ns_to_cnt(u32 ns, u32 period_ps) > { > - return (ns * 1000 + period_ps) / period_ps; > + return DIV_ROUND_UP(ns * 1000, period_ps); > } > > static u32 tc358768_ps_to_ns(u32 ps) >
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 9411b0fb471e..dc2241c18dde 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -630,7 +630,7 @@ static int tc358768_setup_pll(struct tc358768_priv *priv, static u32 tc358768_ns_to_cnt(u32 ns, u32 period_ps) { - return (ns * 1000 + period_ps) / period_ps; + return DIV_ROUND_UP(ns * 1000, period_ps); } static u32 tc358768_ps_to_ns(u32 ps)
The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up operation, but it misses subtracting one from the dividend. Fix this by just using DIV_ROUND_UP(). Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- drivers/gpu/drm/bridge/tc358768.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)