| Message ID | 20230814134024.397739-1-luca.ceresoli@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock | expand |
Hi, On 14/08/2023 15:40, Luca Ceresoli wrote: > This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: > Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical > one mentioned on the documentation to avoid flickering on the unit > tested. Testing on a different unit shows that the panel actually works > with the intended 70.93 MHz clock and even lower frequencies so the > flickering is likely caused either by a defective unit or by other > different components such as the bridge. > > Fixes: eae7488814b5 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Tested-by: Marek Vasut <marex@denx.de> # MX8MM with LT9211 > Reviewed-by: Marek Vasut <marex@denx.de> > > --- > > Changed in v2: > - fix commit hash in "Fixes:" line > - add tested/reviewed by Marek > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 701013b3ad13..a1bbc7f11e83 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2379,7 +2379,7 @@ static const struct panel_desc innolux_g121x1_l03 = { > }; > > static const struct display_timing innolux_g156hce_l01_timings = { > - .pixelclock = { 120000000, 144000000, 150000000 }, > + .pixelclock = { 120000000, 141860000, 150000000 }, > .hactive = { 1920, 1920, 1920 }, > .hfront_porch = { 80, 90, 100 }, > .hback_porch = { 80, 90, 100 }, I'll apply once drm-misc-next-fixes is aligned on the last drm-misc-next tag for v6.6. Thanks, Neil
Hi, On Mon, 14 Aug 2023 15:40:24 +0200, Luca Ceresoli wrote: > This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: > Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical > one mentioned on the documentation to avoid flickering on the unit > tested. Testing on a different unit shows that the panel actually works > with the intended 70.93 MHz clock and even lower frequencies so the > flickering is likely caused either by a defective unit or by other > different components such as the bridge. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes) [1/1] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock https://cgit.freedesktop.org/drm/drm-misc/commit/?id=438cf3271ca116253cffb8edce8aba0191327682
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 701013b3ad13..a1bbc7f11e83 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2379,7 +2379,7 @@ static const struct panel_desc innolux_g121x1_l03 = { }; static const struct display_timing innolux_g156hce_l01_timings = { - .pixelclock = { 120000000, 144000000, 150000000 }, + .pixelclock = { 120000000, 141860000, 150000000 }, .hactive = { 1920, 1920, 1920 }, .hfront_porch = { 80, 90, 100 }, .hback_porch = { 80, 90, 100 },
This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical one mentioned on the documentation to avoid flickering on the unit tested. Testing on a different unit shows that the panel actually works with the intended 70.93 MHz clock and even lower frequencies so the flickering is likely caused either by a defective unit or by other different components such as the bridge. Fixes: eae7488814b5 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Tested-by: Marek Vasut <marex@denx.de> # MX8MM with LT9211 Reviewed-by: Marek Vasut <marex@denx.de> --- Changed in v2: - fix commit hash in "Fixes:" line - add tested/reviewed by Marek --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)