diff mbox series

Documentation/gpu: Update amdgpu documentation

Message ID 20230816035603.690383-1-lijo.lazar@amd.com (mailing list archive)
State New, archived
Headers show
Series Documentation/gpu: Update amdgpu documentation | expand

Commit Message

Lazar, Lijo Aug. 16, 2023, 3:56 a.m. UTC
7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
Update the documentation accordingly.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
---
 Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Alex Deucher Aug. 16, 2023, 1:40 p.m. UTC | #1
[AMD Official Use Only - General]

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Alex Deucher Aug. 16, 2023, 8:46 p.m. UTC | #2
On Wed, Aug 16, 2023 at 12:15 AM Lijo Lazar <lijo.lazar@amd.com> wrote:
>
> 7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
> the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
> Update the documentation accordingly.
>
> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
> ---
>  Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/gpu/amdgpu/driver-misc.rst b/Documentation/gpu/amdgpu/driver-misc.rst
> index be131e963d87..26334e54447b 100644
> --- a/Documentation/gpu/amdgpu/driver-misc.rst
> +++ b/Documentation/gpu/amdgpu/driver-misc.rst
> @@ -11,19 +11,19 @@ via sysfs
>  product_name
>  ------------
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>     :doc: product_name
>
>  product_number
>  --------------
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>     :doc: product_name

I think this should be product_number

Alex

>
>  serial_number
>  -------------
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>     :doc: serial_number
>
>  unique_id
> --
> 2.25.1
>
Lazar, Lijo Aug. 17, 2023, 3:49 a.m. UTC | #3
On 8/17/2023 2:16 AM, Alex Deucher wrote:
> On Wed, Aug 16, 2023 at 12:15 AM Lijo Lazar <lijo.lazar@amd.com> wrote:
>>
>> 7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
>> the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
>> Update the documentation accordingly.
>>
>> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
>> ---
>>   Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/gpu/amdgpu/driver-misc.rst b/Documentation/gpu/amdgpu/driver-misc.rst
>> index be131e963d87..26334e54447b 100644
>> --- a/Documentation/gpu/amdgpu/driver-misc.rst
>> +++ b/Documentation/gpu/amdgpu/driver-misc.rst
>> @@ -11,19 +11,19 @@ via sysfs
>>   product_name
>>   ------------
>>
>> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>>      :doc: product_name
>>
>>   product_number
>>   --------------
>>
>> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>>      :doc: product_name
> 
> I think this should be product_number
> 
> Alex
> 

Thanks, made the change while pushing.

Thanks,
Lijo

>>
>>   serial_number
>>   -------------
>>
>> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
>>      :doc: serial_number
>>
>>   unique_id
>> --
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/Documentation/gpu/amdgpu/driver-misc.rst b/Documentation/gpu/amdgpu/driver-misc.rst
index be131e963d87..26334e54447b 100644
--- a/Documentation/gpu/amdgpu/driver-misc.rst
+++ b/Documentation/gpu/amdgpu/driver-misc.rst
@@ -11,19 +11,19 @@  via sysfs
 product_name
 ------------
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
    :doc: product_name
 
 product_number
 --------------
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
    :doc: product_name
 
 serial_number
 -------------
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
    :doc: serial_number
 
 unique_id