| Message ID | 20230824073710.2677348-14-lee@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
Hi, On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead > > Signed-off-by: Lee Jones <lee@kernel.org> > --- > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: "Maíra Canal" <mairacanal@riseup.net> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > index f102c23eee1dd..c1dfbfcaa0001 100644 > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr) > } > > /** > - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context > + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context > * @test: The test context object > * > * Allocates and initializes a modeset acquire context. The typo was added by your patch 9. I've applied and squashed them both Maxime
On Thu, 24 Aug 2023, Maxime Ripard wrote: > Hi, > > On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead > > > > Signed-off-by: Lee Jones <lee@kernel.org> > > --- > > Cc: David Airlie <airlied@gmail.com> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: "Maíra Canal" <mairacanal@riseup.net> > > Cc: dri-devel@lists.freedesktop.org > > --- > > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > > index f102c23eee1dd..c1dfbfcaa0001 100644 > > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c > > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > > @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr) > > } > > > > /** > > - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context > > + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context > > * @test: The test context object > > * > > * Allocates and initializes a modeset acquire context. > > The typo was added by your patch 9. Whoops! Good catch. > > I've applied and squashed them both Perfect, thank you.
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index f102c23eee1dd..c1dfbfcaa0001 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr) } /** - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context * @test: The test context object * * Allocates and initializes a modeset acquire context.
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead Signed-off-by: Lee Jones <lee@kernel.org> --- Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Maxime Ripard <mripard@kernel.org> Cc: "Maíra Canal" <mairacanal@riseup.net> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)