| Message ID | 20230903184607.272198-4-jim.cromie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm_dbg: add trailing newlines where missing | expand |
Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. > > No functional changes. > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi
On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote: > Hi Jim, > > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > > By at least strong convention, a print-buffer's trailing newline says > > "message complete, send it". The exception (no TNL, followed by a call > > to pr_cont) proves the general rule. > > > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, > > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. > > > > No functional changes. > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> I pushed this i915 one to our drm-intel-next. While doing it I have changed the subject to make it clear this is 'drm/i915:'. I believe you should do similar change to all the other patches to make it clear in the subject about which domain that commit is touching... instead of only 'drm_dbg'. i.e.: 183670347b06 ("drm/i915: add trailing newlines to msgs") https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=183670347b060521920a81f84ff7f10e227ebe05 Thanks for the patch, Rodrigo. > > Andi
On Wed, Sep 6, 2023 at 10:42 AM Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote: > > Hi Jim, > > > > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > > > By at least strong convention, a print-buffer's trailing newline says > > > "message complete, send it". The exception (no TNL, followed by a call > > > to pr_cont) proves the general rule. > > > > > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, > > > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. > > > > > > No functional changes. > > > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> > > I pushed this i915 one to our drm-intel-next. > While doing it I have changed the subject to make it clear > this is 'drm/i915:'. > > I believe you should do similar change to all the other patches > to make it clear in the subject about which domain that commit > is touching... instead of only 'drm_dbg'. > I will do that, and drop the one you've already pushed. Thank you both. > i.e.: 183670347b06 ("drm/i915: add trailing newlines to msgs") > https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=183670347b060521920a81f84ff7f10e227ebe05 > > Thanks for the patch, > Rodrigo. > > > > > Andi
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 090f242e610c..0a196348e2d1 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -4171,7 +4171,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder, struct drm_connector *connector = conn_state->connector; u8 port_sync_transcoders = 0; - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]", + drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n", encoder->base.base.id, encoder->base.name, crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index cfd7929587d8..29c40e8a7183 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1436,7 +1436,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { drm_dbg(&i915->drm, "reloc with multiple write domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, @@ -1447,7 +1447,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, & ~I915_GEM_GPU_DOMAINS)) { drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains,
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)