From patchwork Mon Sep 4 04:16:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13373465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB15EC83F33 for ; Mon, 4 Sep 2023 04:16:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05AC610E287; Mon, 4 Sep 2023 04:16:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53B3B10E287; Mon, 4 Sep 2023 04:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693801007; x=1725337007; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q0FNLZFCv31DhObWokrUuGARIHxCY7P9GHenMrzVxMc=; b=kokwkvQrV2ngKdK8ARFV8ZB6zynTb2oMrLWVU2UQP8subC4XQersX9iL LEUWiosCTX+TiRBcAonhwMsD8NBMOfRodHDMoLCv8MQx2C8PmYmTH+CrE D8skfsFIaPavycc8TDeeT0LFNM6+Skv2XwA2CdTJfuTGVizPyINxRVMcD lqi7nCVnjVuT0tWrWylxoKu3tdTaiHfbTB/fhLJgy2yTui3Q5ly6hj3ay UD4bHYgMJIzPg7B/DBaQ2TpSu/DsA4ak4eGpJ60diyji65hppEpZc4WFQ /Gs7FIpEEVeOLSwIACjJVku/S5Uc4X+roamqI5liPd7h76I3Fj/azvX42 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="361531448" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="361531448" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 21:16:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="883893548" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="883893548" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.153]) by fmsmga001.fm.intel.com with SMTP; 03 Sep 2023 21:16:40 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 04 Sep 2023 07:16:43 +0300 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH v2 2/2] drm/vblank: Warn when silently cancelling vblank works Date: Mon, 4 Sep 2023 07:16:40 +0300 Message-ID: <20230904041640.31297-2-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230904041640.31297-1-ville.syrjala@linux.intel.com> References: <20230904041640.31297-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Ville Syrjälä Silently cancelling vblank works is a bit rude, especially if said works do any resource management (eg. free memory). WARN if we ever hit this. TODO: Maybe drm_crtc_vblank_off() should wait for any pending work to reach its target vblank before actually doing anything drastic? Cc: Lyude Paul Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank_work.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank_work.c b/drivers/gpu/drm/drm_vblank_work.c index bd481fdd6b87..43cd5c0f4f6f 100644 --- a/drivers/gpu/drm/drm_vblank_work.c +++ b/drivers/gpu/drm/drm_vblank_work.c @@ -73,6 +73,9 @@ void drm_vblank_cancel_pending_works(struct drm_vblank_crtc *vblank) assert_spin_locked(&vblank->dev->event_lock); + drm_WARN_ONCE(vblank->dev, !list_empty(&vblank->pending_work), + "Cancelling pending vblank works!\n"); + list_for_each_entry_safe(work, next, &vblank->pending_work, node) { list_del_init(&work->node); drm_vblank_put(vblank->dev, vblank->pipe);