| Message ID | 20230906181226.2198441-3-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/dp: More DPCD cleanups | expand |
On 06/09/2023 21:12, Stephen Boyd wrote: > Plugging in an Apple dongle without the HDMI cable attached prints out > an error message in the kernel logs when nothing is actually wrong. > > no downstream ports connected > > This is because the downstream port for the HDMI connector is not > connected, so the Apple dongle reports that as a zero sink count device. > > Cc: Vinod Polimera <quic_vpolimer@quicinc.com> > Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c > index 97ba41593820..ae778e1a6fd0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -156,7 +156,6 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel, > if (drm_dp_is_branch(dp_panel->dpcd)) { > count = drm_dp_read_sink_count(panel->aux); > if (!count) { > - DRM_ERROR("no downstream ports connected\n"); Maybe this can be converted to drm_dbg_dp? > panel->link->sink_count = 0; > return -ENOTCONN; > }
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 97ba41593820..ae778e1a6fd0 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -156,7 +156,6 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel, if (drm_dp_is_branch(dp_panel->dpcd)) { count = drm_dp_read_sink_count(panel->aux); if (!count) { - DRM_ERROR("no downstream ports connected\n"); panel->link->sink_count = 0; return -ENOTCONN; }
Plugging in an Apple dongle without the HDMI cable attached prints out an error message in the kernel logs when nothing is actually wrong. no downstream ports connected This is because the downstream port for the HDMI connector is not connected, so the Apple dongle reports that as a zero sink count device. Cc: Vinod Polimera <quic_vpolimer@quicinc.com> Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - 1 file changed, 1 deletion(-)