| Message ID | 20230919131235.759959-1-mripard@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: Update drm-misc entry to match all drivers | expand |
On Tue, 19 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote: > We've had a number of times when a patch slipped through and we couldn't > pick them up either because our MAINTAINERS entry only covers the > framework and thus we weren't Cc'd. > > Let's take another approach where we match everything, and remove all > the drivers that are not maintained through drm-misc. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> FWIW, Acked-by: Jani Nikula <jani.nikula@intel.com> > --- > MAINTAINERS | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90f13281d297..757d4f33e158 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > S: Maintained > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/ > +F: Documentation/devicetree/bindings/gpu/ > F: Documentation/gpu/ > -F: drivers/gpu/drm/* > +F: drivers/gpu/drm/ > F: drivers/gpu/vga/ > -F: include/drm/drm* > +F: include/drm/drm > F: include/linux/vga* > -F: include/uapi/drm/drm* > +F: include/uapi/drm/ > +X: drivers/gpu/drm/amd/ > +X: drivers/gpu/drm/armada/ > +X: drivers/gpu/drm/etnaviv/ > +X: drivers/gpu/drm/exynos/ > +X: drivers/gpu/drm/gma500/ > +X: drivers/gpu/drm/i915/ > +X: drivers/gpu/drm/imx/ > +X: drivers/gpu/drm/ingenic/ > +X: drivers/gpu/drm/kmb/ > +X: drivers/gpu/drm/mediatek/ > +X: drivers/gpu/drm/msm/ > +X: drivers/gpu/drm/nouveau/ > +X: drivers/gpu/drm/radeon/ > +X: drivers/gpu/drm/renesas/ > +X: drivers/gpu/drm/tegra/ > > DRM DRIVERS FOR ALLWINNER A10 > M: Maxime Ripard <mripard@kernel.org>
Hi, On 2023/9/19 21:12, Maxime Ripard wrote: > We've had a number of times when a patch slipped through and we couldn't > pick them up either because our MAINTAINERS entry only covers the > framework and thus we weren't Cc'd. > > Let's take another approach where we match everything, and remove all > the drivers that are not maintained through drm-misc. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > Acked-by: Jani Nikula <jani.nikula@intel.com> > --- > MAINTAINERS | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90f13281d297..757d4f33e158 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > S: Maintained > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/ > +F: Documentation/devicetree/bindings/gpu/ > F: Documentation/gpu/ > -F: drivers/gpu/drm/* > +F: drivers/gpu/drm/ > F: drivers/gpu/vga/ > -F: include/drm/drm* > +F: include/drm/drm > F: include/linux/vga* > -F: include/uapi/drm/drm* > +F: include/uapi/drm/ > +X: drivers/gpu/drm/amd/ > +X: drivers/gpu/drm/armada/ > +X: drivers/gpu/drm/etnaviv/ > +X: drivers/gpu/drm/exynos/ > +X: drivers/gpu/drm/gma500/ > +X: drivers/gpu/drm/i915/ > +X: drivers/gpu/drm/imx/ > +X: drivers/gpu/drm/ingenic/ > +X: drivers/gpu/drm/kmb/ > +X: drivers/gpu/drm/mediatek/ > +X: drivers/gpu/drm/msm/ > +X: drivers/gpu/drm/nouveau/ > +X: drivers/gpu/drm/radeon/ > +X: drivers/gpu/drm/renesas/ > +X: drivers/gpu/drm/tegra/ > > DRM DRIVERS FOR ALLWINNER A10 > M: Maxime Ripard <mripard@kernel.org> Nice patch! Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc? As far as I know: 1) the drm/ingenic driver don't have a "T" annotation (location of the link). 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the code for this link is not up to date. I think at least the drm/ingenic and drm/gma500 drivers are *actually* maintained through drm-misc, So perhaps, these two drivers should not be excluded. Am I correct?
Hi, Adding Paul in Cc On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > On 2023/9/19 21:12, Maxime Ripard wrote: > > We've had a number of times when a patch slipped through and we couldn't > > pick them up either because our MAINTAINERS entry only covers the > > framework and thus we weren't Cc'd. > > > > Let's take another approach where we match everything, and remove all > > the drivers that are not maintained through drm-misc. > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > --- > > MAINTAINERS | 23 ++++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 90f13281d297..757d4f33e158 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > > S: Maintained > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > > T: git git://anongit.freedesktop.org/drm/drm-misc > > +F: Documentation/devicetree/bindings/display/ > > +F: Documentation/devicetree/bindings/gpu/ > > F: Documentation/gpu/ > > -F: drivers/gpu/drm/* > > +F: drivers/gpu/drm/ > > F: drivers/gpu/vga/ > > -F: include/drm/drm* > > +F: include/drm/drm > > F: include/linux/vga* > > -F: include/uapi/drm/drm* > > +F: include/uapi/drm/ > > +X: drivers/gpu/drm/amd/ > > +X: drivers/gpu/drm/armada/ > > +X: drivers/gpu/drm/etnaviv/ > > +X: drivers/gpu/drm/exynos/ > > +X: drivers/gpu/drm/gma500/ > > +X: drivers/gpu/drm/i915/ > > +X: drivers/gpu/drm/imx/ > > +X: drivers/gpu/drm/ingenic/ > > +X: drivers/gpu/drm/kmb/ > > +X: drivers/gpu/drm/mediatek/ > > +X: drivers/gpu/drm/msm/ > > +X: drivers/gpu/drm/nouveau/ > > +X: drivers/gpu/drm/radeon/ > > +X: drivers/gpu/drm/renesas/ > > +X: drivers/gpu/drm/tegra/ > > DRM DRIVERS FOR ALLWINNER A10 > > M: Maxime Ripard <mripard@kernel.org> > > > Nice patch! > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc? > > As far as I know: > 1) the drm/ingenic driver don't have a "T" annotation (location of the link). Yeah, I wasn't sure about that one indeed. I remained conservative since it's a sensitive topic for some. Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, could you clarify which git tree is supposed to merge those patches in MAINTAINERS? > 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the code for this link is not up to date. For gma500, I think it's mostly historical since it was there before drm-misc was a thing. > I think at least the drm/ingenic and drm/gma500 drivers are *actually* > maintained through drm-misc, So perhaps, these two drivers should not be > excluded. Am I correct? It's likely :) Either way, I think it can be solved/clarified later on Maxime
Hi, Le jeudi 21 septembre 2023 à 10:47 +0200, Maxime Ripard a écrit : > Hi, > > Adding Paul in Cc > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > We've had a number of times when a patch slipped through and we > > > couldn't > > > pick them up either because our MAINTAINERS entry only covers the > > > framework and thus we weren't Cc'd. > > > > > > Let's take another approach where we match everything, and remove > > > all > > > the drivers that are not maintained through drm-misc. > > > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > > --- > > > MAINTAINERS | 23 ++++++++++++++++++++--- > > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 90f13281d297..757d4f33e158 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann > > > <tzimmermann@suse.de> > > > S: Maintained > > > > > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm- > > > misc.html > > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > +F: Documentation/devicetree/bindings/display/ > > > +F: Documentation/devicetree/bindings/gpu/ > > > F: Documentation/gpu/ > > > -F: drivers/gpu/drm/* > > > +F: drivers/gpu/drm/ > > > F: drivers/gpu/vga/ > > > -F: include/drm/drm* > > > +F: include/drm/drm > > > F: include/linux/vga* > > > -F: include/uapi/drm/drm* > > > +F: include/uapi/drm/ > > > +X: drivers/gpu/drm/amd/ > > > +X: drivers/gpu/drm/armada/ > > > +X: drivers/gpu/drm/etnaviv/ > > > +X: drivers/gpu/drm/exynos/ > > > +X: drivers/gpu/drm/gma500/ > > > +X: drivers/gpu/drm/i915/ > > > +X: drivers/gpu/drm/imx/ > > > +X: drivers/gpu/drm/ingenic/ > > > +X: drivers/gpu/drm/kmb/ > > > +X: drivers/gpu/drm/mediatek/ > > > +X: drivers/gpu/drm/msm/ > > > +X: drivers/gpu/drm/nouveau/ > > > +X: drivers/gpu/drm/radeon/ > > > +X: drivers/gpu/drm/renesas/ > > > +X: drivers/gpu/drm/tegra/ > > > DRM DRIVERS FOR ALLWINNER A10 > > > M: Maxime Ripard <mripard@kernel.org> > > > > > > Nice patch! > > > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are > > not maintained through drm-misc? > > > > As far as I know: > > 1) the drm/ingenic driver don't have a "T" annotation (location of > > the link). > > Yeah, I wasn't sure about that one indeed. I remained conservative > since it's a > sensitive topic for some. > > Paul, is drm/ingenic supposed to be maintained through drm-misc? > Either way, > could you clarify which git tree is supposed to merge those patches > in > MAINTAINERS? drm/ingenic is maintained through drm-misc, yes. Looking at the MAINTAINERS file, it seems to be one of the only DRM drivers without its own entry. I'll add one then. Cheers, -Paul > > > 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm- > > gma500", but the > code for this link is not up to date. > > For gma500, I think it's mostly historical since it was there before > drm-misc > was a thing. > > > I think at least the drm/ingenic and drm/gma500 drivers are > > *actually* > > maintained through drm-misc, So perhaps, these two drivers should > > not be > > excluded. Am I correct? > > It's likely :) > > Either way, I think it can be solved/clarified later on > > Maxime
Hi Maxime Am 19.09.23 um 15:12 schrieb Maxime Ripard: > We've had a number of times when a patch slipped through and we couldn't > pick them up either because our MAINTAINERS entry only covers the > framework and thus we weren't Cc'd. > > Let's take another approach where we match everything, and remove all > the drivers that are not maintained through drm-misc. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > MAINTAINERS | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90f13281d297..757d4f33e158 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > S: Maintained > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/ > +F: Documentation/devicetree/bindings/gpu/ > F: Documentation/gpu/ > -F: drivers/gpu/drm/* > +F: drivers/gpu/drm/ > F: drivers/gpu/vga/ > -F: include/drm/drm* > +F: include/drm/drm > F: include/linux/vga* > -F: include/uapi/drm/drm* > +F: include/uapi/drm/ > +X: drivers/gpu/drm/amd/ > +X: drivers/gpu/drm/armada/ > +X: drivers/gpu/drm/etnaviv/ > +X: drivers/gpu/drm/exynos/ > +X: drivers/gpu/drm/gma500/ We always had gma500 in drm-misc. Where else would these go? Best regards Thomas > +X: drivers/gpu/drm/i915/ > +X: drivers/gpu/drm/imx/ > +X: drivers/gpu/drm/ingenic/ > +X: drivers/gpu/drm/kmb/ > +X: drivers/gpu/drm/mediatek/ > +X: drivers/gpu/drm/msm/ > +X: drivers/gpu/drm/nouveau/ > +X: drivers/gpu/drm/radeon/ > +X: drivers/gpu/drm/renesas/ > +X: drivers/gpu/drm/tegra/ > > DRM DRIVERS FOR ALLWINNER A10 > M: Maxime Ripard <mripard@kernel.org>
Hi, On 2023/9/21 16:47, Maxime Ripard wrote: > Hi, > > Adding Paul in Cc > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: >> On 2023/9/19 21:12, Maxime Ripard wrote: >>> We've had a number of times when a patch slipped through and we couldn't >>> pick them up either because our MAINTAINERS entry only covers the >>> framework and thus we weren't Cc'd. >>> >>> Let's take another approach where we match everything, and remove all >>> the drivers that are not maintained through drm-misc. >>> >>> Signed-off-by: Maxime Ripard <mripard@kernel.org> >>> Acked-by: Jani Nikula <jani.nikula@intel.com> >>> --- >>> MAINTAINERS | 23 ++++++++++++++++++++--- >>> 1 file changed, 20 insertions(+), 3 deletions(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 90f13281d297..757d4f33e158 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> >>> S: Maintained >>> W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html >>> T: git git://anongit.freedesktop.org/drm/drm-misc >>> +F: Documentation/devicetree/bindings/display/ >>> +F: Documentation/devicetree/bindings/gpu/ >>> F: Documentation/gpu/ >>> -F: drivers/gpu/drm/* >>> +F: drivers/gpu/drm/ >>> F: drivers/gpu/vga/ >>> -F: include/drm/drm* >>> +F: include/drm/drm >>> F: include/linux/vga* >>> -F: include/uapi/drm/drm* >>> +F: include/uapi/drm/ >>> +X: drivers/gpu/drm/amd/ >>> +X: drivers/gpu/drm/armada/ >>> +X: drivers/gpu/drm/etnaviv/ >>> +X: drivers/gpu/drm/exynos/ >>> +X: drivers/gpu/drm/gma500/ >>> +X: drivers/gpu/drm/i915/ >>> +X: drivers/gpu/drm/imx/ >>> +X: drivers/gpu/drm/ingenic/ >>> +X: drivers/gpu/drm/kmb/ >>> +X: drivers/gpu/drm/mediatek/ >>> +X: drivers/gpu/drm/msm/ >>> +X: drivers/gpu/drm/nouveau/ >>> +X: drivers/gpu/drm/radeon/ >>> +X: drivers/gpu/drm/renesas/ >>> +X: drivers/gpu/drm/tegra/ >>> DRM DRIVERS FOR ALLWINNER A10 >>> M: Maxime Ripard <mripard@kernel.org> >> >> Nice patch! >> >> Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc? >> >> As far as I know: >> 1) the drm/ingenic driver don't have a "T" annotation (location of the link). > Yeah, I wasn't sure about that one indeed. I remained conservative since it's a > sensitive topic for some. > > Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, > could you clarify which git tree is supposed to merge those patches in > MAINTAINERS? > >> 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the > code for this link is not up to date. > > For gma500, I think it's mostly historical since it was there before drm-misc > was a thing. > >> I think at least the drm/ingenic and drm/gma500 drivers are *actually* >> maintained through drm-misc, So perhaps, these two drivers should not be >> excluded. Am I correct? > It's likely :) > > Either way, I think it can be solved/clarified later on OK, that's sound fairly enough. I will respect you and Paul's opinion. By the way, I also want to say that I think the drm/imb and various drm/imx drivers are also belong to the drm-misc. They are also lack the "T" annotation. Hopes someone can help to check that. Thanks. Thanks for the patch. > Maxime
Hi Thomas, On Thu, Sep 21, 2023 at 10:57:57AM +0200, Thomas Zimmermann wrote: > Am 19.09.23 um 15:12 schrieb Maxime Ripard: > > We've had a number of times when a patch slipped through and we couldn't > > pick them up either because our MAINTAINERS entry only covers the > > framework and thus we weren't Cc'd. > > > > Let's take another approach where we match everything, and remove all > > the drivers that are not maintained through drm-misc. > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > --- > > MAINTAINERS | 23 ++++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 90f13281d297..757d4f33e158 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > > S: Maintained > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > > T: git git://anongit.freedesktop.org/drm/drm-misc > > +F: Documentation/devicetree/bindings/display/ > > +F: Documentation/devicetree/bindings/gpu/ > > F: Documentation/gpu/ > > -F: drivers/gpu/drm/* > > +F: drivers/gpu/drm/ > > F: drivers/gpu/vga/ > > -F: include/drm/drm* > > +F: include/drm/drm > > F: include/linux/vga* > > -F: include/uapi/drm/drm* > > +F: include/uapi/drm/ > > +X: drivers/gpu/drm/amd/ > > +X: drivers/gpu/drm/armada/ > > +X: drivers/gpu/drm/etnaviv/ > > +X: drivers/gpu/drm/exynos/ > > > +X: drivers/gpu/drm/gma500/ > > We always had gma500 in drm-misc. Where else would these go? The maintainers entry has a git repo. I'll update it (and that patch too) then Maxime
Hi Paul, On Thu, Sep 21, 2023 at 10:57:46AM +0200, Paul Cercueil wrote: > Le jeudi 21 septembre 2023 à 10:47 +0200, Maxime Ripard a écrit : > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > > We've had a number of times when a patch slipped through and we > > > > couldn't > > > > pick them up either because our MAINTAINERS entry only covers the > > > > framework and thus we weren't Cc'd. > > > > > > > > Let's take another approach where we match everything, and remove > > > > all > > > > the drivers that are not maintained through drm-misc. > > > > > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > > > --- > > > > MAINTAINERS | 23 ++++++++++++++++++++--- > > > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 90f13281d297..757d4f33e158 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann > > > > <tzimmermann@suse.de> > > > > S: Maintained > > > > > > > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm- > > > > misc.html > > > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > > +F: Documentation/devicetree/bindings/display/ > > > > +F: Documentation/devicetree/bindings/gpu/ > > > > F: Documentation/gpu/ > > > > -F: drivers/gpu/drm/* > > > > +F: drivers/gpu/drm/ > > > > F: drivers/gpu/vga/ > > > > -F: include/drm/drm* > > > > +F: include/drm/drm > > > > F: include/linux/vga* > > > > -F: include/uapi/drm/drm* > > > > +F: include/uapi/drm/ > > > > +X: drivers/gpu/drm/amd/ > > > > +X: drivers/gpu/drm/armada/ > > > > +X: drivers/gpu/drm/etnaviv/ > > > > +X: drivers/gpu/drm/exynos/ > > > > +X: drivers/gpu/drm/gma500/ > > > > +X: drivers/gpu/drm/i915/ > > > > +X: drivers/gpu/drm/imx/ > > > > +X: drivers/gpu/drm/ingenic/ > > > > +X: drivers/gpu/drm/kmb/ > > > > +X: drivers/gpu/drm/mediatek/ > > > > +X: drivers/gpu/drm/msm/ > > > > +X: drivers/gpu/drm/nouveau/ > > > > +X: drivers/gpu/drm/radeon/ > > > > +X: drivers/gpu/drm/renesas/ > > > > +X: drivers/gpu/drm/tegra/ > > > > DRM DRIVERS FOR ALLWINNER A10 > > > > M: Maxime Ripard <mripard@kernel.org> > > > > > > > > > Nice patch! > > > > > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are > > > not maintained through drm-misc? > > > > > > As far as I know: > > > 1) the drm/ingenic driver don't have a "T" annotation (location of > > > the link). > > > > Yeah, I wasn't sure about that one indeed. I remained conservative > > since it's a > > sensitive topic for some. > > > > Paul, is drm/ingenic supposed to be maintained through drm-misc? > > Either way, > > could you clarify which git tree is supposed to merge those patches > > in > > MAINTAINERS? > > drm/ingenic is maintained through drm-misc, yes. > > Looking at the MAINTAINERS file, it seems to be one of the only DRM > drivers without its own entry. I'll add one then. Ack, thanks! Maxime
On Thu, Sep 21, 2023 at 10:47:58AM +0200, Maxime Ripard wrote: > Hi, > > Adding Paul in Cc > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > We've had a number of times when a patch slipped through and we couldn't > > > pick them up either because our MAINTAINERS entry only covers the > > > framework and thus we weren't Cc'd. > > > > > > Let's take another approach where we match everything, and remove all > > > the drivers that are not maintained through drm-misc. > > > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > > --- > > > MAINTAINERS | 23 ++++++++++++++++++++--- > > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 90f13281d297..757d4f33e158 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > > > S: Maintained > > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > +F: Documentation/devicetree/bindings/display/ > > > +F: Documentation/devicetree/bindings/gpu/ > > > F: Documentation/gpu/ > > > -F: drivers/gpu/drm/* > > > +F: drivers/gpu/drm/ > > > F: drivers/gpu/vga/ > > > -F: include/drm/drm* > > > +F: include/drm/drm > > > F: include/linux/vga* > > > -F: include/uapi/drm/drm* > > > +F: include/uapi/drm/ > > > +X: drivers/gpu/drm/amd/ > > > +X: drivers/gpu/drm/armada/ > > > +X: drivers/gpu/drm/etnaviv/ > > > +X: drivers/gpu/drm/exynos/ > > > +X: drivers/gpu/drm/gma500/ > > > +X: drivers/gpu/drm/i915/ > > > +X: drivers/gpu/drm/imx/ > > > +X: drivers/gpu/drm/ingenic/ > > > +X: drivers/gpu/drm/kmb/ > > > +X: drivers/gpu/drm/mediatek/ > > > +X: drivers/gpu/drm/msm/ > > > +X: drivers/gpu/drm/nouveau/ > > > +X: drivers/gpu/drm/radeon/ > > > +X: drivers/gpu/drm/renesas/ > > > +X: drivers/gpu/drm/tegra/ > > > DRM DRIVERS FOR ALLWINNER A10 > > > M: Maxime Ripard <mripard@kernel.org> > > > > > > Nice patch! > > > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc? > > > > As far as I know: > > 1) the drm/ingenic driver don't have a "T" annotation (location of the link). > > Yeah, I wasn't sure about that one indeed. I remained conservative since it's a > sensitive topic for some. > > Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, > could you clarify which git tree is supposed to merge those patches in > MAINTAINERS? > > > 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the > code for this link is not up to date. > > For gma500, I think it's mostly historical since it was there before drm-misc > was a thing. Yes, that's the reason. I used do PRs from my github before we had drm-misc but now everything gma500 related goes through drm-misc. > > > I think at least the drm/ingenic and drm/gma500 drivers are *actually* > > maintained through drm-misc, So perhaps, these two drivers should not be > > excluded. Am I correct? > > It's likely :) > > Either way, I think it can be solved/clarified later on > > Maxime
On Thu, Sep 21, 2023 at 05:09:07PM +0800, Sui Jingfeng wrote: > On 2023/9/21 16:47, Maxime Ripard wrote: > > Adding Paul in Cc > > > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > > We've had a number of times when a patch slipped through and we couldn't > > > > pick them up either because our MAINTAINERS entry only covers the > > > > framework and thus we weren't Cc'd. > > > > > > > > Let's take another approach where we match everything, and remove all > > > > the drivers that are not maintained through drm-misc. > > > > > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > > > Acked-by: Jani Nikula <jani.nikula@intel.com> > > > > --- > > > > MAINTAINERS | 23 ++++++++++++++++++++--- > > > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 90f13281d297..757d4f33e158 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > > > > S: Maintained > > > > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > > > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > > +F: Documentation/devicetree/bindings/display/ > > > > +F: Documentation/devicetree/bindings/gpu/ > > > > F: Documentation/gpu/ > > > > -F: drivers/gpu/drm/* > > > > +F: drivers/gpu/drm/ > > > > F: drivers/gpu/vga/ > > > > -F: include/drm/drm* > > > > +F: include/drm/drm > > > > F: include/linux/vga* > > > > -F: include/uapi/drm/drm* > > > > +F: include/uapi/drm/ > > > > +X: drivers/gpu/drm/amd/ > > > > +X: drivers/gpu/drm/armada/ > > > > +X: drivers/gpu/drm/etnaviv/ > > > > +X: drivers/gpu/drm/exynos/ > > > > +X: drivers/gpu/drm/gma500/ > > > > +X: drivers/gpu/drm/i915/ > > > > +X: drivers/gpu/drm/imx/ > > > > +X: drivers/gpu/drm/ingenic/ > > > > +X: drivers/gpu/drm/kmb/ > > > > +X: drivers/gpu/drm/mediatek/ > > > > +X: drivers/gpu/drm/msm/ > > > > +X: drivers/gpu/drm/nouveau/ > > > > +X: drivers/gpu/drm/radeon/ > > > > +X: drivers/gpu/drm/renesas/ > > > > +X: drivers/gpu/drm/tegra/ > > > > DRM DRIVERS FOR ALLWINNER A10 > > > > M: Maxime Ripard <mripard@kernel.org> > > > > > > Nice patch! > > > > > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc? > > > > > > As far as I know: > > > 1) the drm/ingenic driver don't have a "T" annotation (location of the link). > > Yeah, I wasn't sure about that one indeed. I remained conservative since it's a > > sensitive topic for some. > > > > Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way, > > could you clarify which git tree is supposed to merge those patches in > > MAINTAINERS? > > > > > 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the > > code for this link is not up to date. > > > > For gma500, I think it's mostly historical since it was there before drm-misc > > was a thing. > > > > > I think at least the drm/ingenic and drm/gma500 drivers are *actually* > > > maintained through drm-misc, So perhaps, these two drivers should not be > > > excluded. Am I correct? > > It's likely :) > > > > Either way, I think it can be solved/clarified later on > > > OK, that's sound fairly enough. I will respect you and Paul's opinion. > By the way, I also want to say that I think the drm/imb and various drm/imx drivers > are also belong to the drm-misc. They are also lack the "T" annotation. > Hopes someone can help to check that. Thanks. > Thanks for the patch. As far as I know, imx is kind of in-between at the moment. Some patches are going through drm-misc, but others are coming through their tree. For kmb (if that's what you meant), then I would expect intel to do the maintenance like they do for i915. But given this discussion it could be a good idea to add all the maintainers of those excluded drivers in Cc in the next revision. Maxime
Hi, On 19/09/2023 10:12, Maxime Ripard wrote: > We've had a number of times when a patch slipped through and we couldn't > pick them up either because our MAINTAINERS entry only covers the > framework and thus we weren't Cc'd. > > Let's take another approach where we match everything, and remove all > the drivers that are not maintained through drm-misc. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > MAINTAINERS | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90f13281d297..757d4f33e158 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> > S: Maintained > W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/ > +F: Documentation/devicetree/bindings/gpu/ > F: Documentation/gpu/ > -F: drivers/gpu/drm/* > +F: drivers/gpu/drm/ > F: drivers/gpu/vga/ > -F: include/drm/drm* > +F: include/drm/drm > F: include/linux/vga* > -F: include/uapi/drm/drm* > +F: include/uapi/drm/ > +X: drivers/gpu/drm/amd/ > +X: drivers/gpu/drm/armada/ > +X: drivers/gpu/drm/etnaviv/ > +X: drivers/gpu/drm/exynos/ > +X: drivers/gpu/drm/gma500/ > +X: drivers/gpu/drm/i915/ > +X: drivers/gpu/drm/imx/ > +X: drivers/gpu/drm/ingenic/ > +X: drivers/gpu/drm/kmb/ > +X: drivers/gpu/drm/mediatek/ > +X: drivers/gpu/drm/msm/ > +X: drivers/gpu/drm/nouveau/ > +X: drivers/gpu/drm/radeon/ > +X: drivers/gpu/drm/renesas/ > +X: drivers/gpu/drm/tegra/ Should drivers/gpu/drm/ci/ be in the list too? Thanks, Helen > > DRM DRIVERS FOR ALLWINNER A10 > M: Maxime Ripard <mripard@kernel.org>
On 21/09/2023 15:12, Helen Koike wrote: > Hi, > > On 19/09/2023 10:12, Maxime Ripard wrote: >> We've had a number of times when a patch slipped through and we couldn't >> pick them up either because our MAINTAINERS entry only covers the >> framework and thus we weren't Cc'd. >> >> Let's take another approach where we match everything, and remove all >> the drivers that are not maintained through drm-misc. >> >> Signed-off-by: Maxime Ripard <mripard@kernel.org> >> --- >> MAINTAINERS | 23 ++++++++++++++++++++--- >> 1 file changed, 20 insertions(+), 3 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 90f13281d297..757d4f33e158 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> >> S: Maintained >> W: >> https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html >> T: git git://anongit.freedesktop.org/drm/drm-misc >> +F: Documentation/devicetree/bindings/display/ >> +F: Documentation/devicetree/bindings/gpu/ >> F: Documentation/gpu/ >> -F: drivers/gpu/drm/* >> +F: drivers/gpu/drm/ >> F: drivers/gpu/vga/ >> -F: include/drm/drm* >> +F: include/drm/drm >> F: include/linux/vga* >> -F: include/uapi/drm/drm* >> +F: include/uapi/drm/ >> +X: drivers/gpu/drm/amd/ >> +X: drivers/gpu/drm/armada/ >> +X: drivers/gpu/drm/etnaviv/ >> +X: drivers/gpu/drm/exynos/ >> +X: drivers/gpu/drm/gma500/ >> +X: drivers/gpu/drm/i915/ >> +X: drivers/gpu/drm/imx/ >> +X: drivers/gpu/drm/ingenic/ >> +X: drivers/gpu/drm/kmb/ >> +X: drivers/gpu/drm/mediatek/ >> +X: drivers/gpu/drm/msm/ >> +X: drivers/gpu/drm/nouveau/ >> +X: drivers/gpu/drm/radeon/ >> +X: drivers/gpu/drm/renesas/ >> +X: drivers/gpu/drm/tegra/ > > Should drivers/gpu/drm/ci/ be in the list too? ops, please ignore this message, I misread the patch, it is already included by default (instead of excluded). sorry for the noise. Helen > > Thanks, > Helen > >> DRM DRIVERS FOR ALLWINNER A10 >> M: Maxime Ripard <mripard@kernel.org>
diff --git a/MAINTAINERS b/MAINTAINERS index 90f13281d297..757d4f33e158 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6860,12 +6860,29 @@ M: Thomas Zimmermann <tzimmermann@suse.de> S: Maintained W: https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/ +F: Documentation/devicetree/bindings/gpu/ F: Documentation/gpu/ -F: drivers/gpu/drm/* +F: drivers/gpu/drm/ F: drivers/gpu/vga/ -F: include/drm/drm* +F: include/drm/drm F: include/linux/vga* -F: include/uapi/drm/drm* +F: include/uapi/drm/ +X: drivers/gpu/drm/amd/ +X: drivers/gpu/drm/armada/ +X: drivers/gpu/drm/etnaviv/ +X: drivers/gpu/drm/exynos/ +X: drivers/gpu/drm/gma500/ +X: drivers/gpu/drm/i915/ +X: drivers/gpu/drm/imx/ +X: drivers/gpu/drm/ingenic/ +X: drivers/gpu/drm/kmb/ +X: drivers/gpu/drm/mediatek/ +X: drivers/gpu/drm/msm/ +X: drivers/gpu/drm/nouveau/ +X: drivers/gpu/drm/radeon/ +X: drivers/gpu/drm/renesas/ +X: drivers/gpu/drm/tegra/ DRM DRIVERS FOR ALLWINNER A10 M: Maxime Ripard <mripard@kernel.org>
We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- MAINTAINERS | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)