| Message ID | 20230927072157.2544601-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | accel/habanalabs: add missing debugfs function stubs | expand |
On Wed, Sep 27, 2023 at 10:22 AM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > Two function stubs were removed in an earlier commit but are now needed > again: > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': > drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration] > 2231 | rc = hl_debugfs_device_init(hdev); > drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration] > 2367 | hl_debugfs_device_fini(hdev); > | ^~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later") > Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an accel device") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h > index 2a3acdbf91714..1655c101c7052 100644 > --- a/drivers/accel/habanalabs/common/habanalabs.h > +++ b/drivers/accel/habanalabs/common/habanalabs.h > @@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data, > > #else > > +static inline int hl_debugfs_device_init(struct hl_device *hdev) > +{ > + return 0; > +} > + > +static inline void hl_debugfs_device_fini(struct hl_device *hdev) > +{ > +} > + > static inline void hl_debugfs_add_device(struct hl_device *hdev) > { > } > -- > 2.39.2 > Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Applied to -next Thanks, Oded
diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h index 2a3acdbf91714..1655c101c7052 100644 --- a/drivers/accel/habanalabs/common/habanalabs.h +++ b/drivers/accel/habanalabs/common/habanalabs.h @@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data, #else +static inline int hl_debugfs_device_init(struct hl_device *hdev) +{ + return 0; +} + +static inline void hl_debugfs_device_fini(struct hl_device *hdev) +{ +} + static inline void hl_debugfs_add_device(struct hl_device *hdev) { }