diff mbox series

[v2,1/3] drm/nouveau: chan: use struct nvif_mclass

Message ID 20231002135008.10651-1-dakr@redhat.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] drm/nouveau: chan: use struct nvif_mclass | expand

Commit Message

Danilo Krummrich Oct. 2, 2023, 1:46 p.m. UTC 
Use actual struct nvif_mclass instead of identical anonymous struct.

Signed-off-by: Danilo Krummrich <dakr@redhat.com>
---
 drivers/gpu/drm/nouveau/nouveau_chan.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Lyude Paul Oct. 2, 2023, 6:58 p.m. UTC | #1 
For the whole series:

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Mon, 2023-10-02 at 15:46 +0200, Danilo Krummrich wrote:
> Use actual struct nvif_mclass instead of identical anonymous struct.
> 
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_chan.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c
> index 1fd5ccf41128..dffbee59be6a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_chan.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_chan.c
> @@ -259,10 +259,7 @@ static int
>  nouveau_channel_ctor(struct nouveau_drm *drm, struct nvif_device *device, bool priv, u64 runm,
>  		     struct nouveau_channel **pchan)
>  {
> -	static const struct {
> -		s32 oclass;
> -		int version;
> -	} hosts[] = {
> +	const struct nvif_mclass hosts[] = {
>  		{  AMPERE_CHANNEL_GPFIFO_B, 0 },
>  		{  AMPERE_CHANNEL_GPFIFO_A, 0 },
>  		{  TURING_CHANNEL_GPFIFO_A, 0 },
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c
index 1fd5ccf41128..dffbee59be6a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_chan.c
+++ b/drivers/gpu/drm/nouveau/nouveau_chan.c
@@ -259,10 +259,7 @@  static int
 nouveau_channel_ctor(struct nouveau_drm *drm, struct nvif_device *device, bool priv, u64 runm,
 		     struct nouveau_channel **pchan)
 {
-	static const struct {
-		s32 oclass;
-		int version;
-	} hosts[] = {
+	const struct nvif_mclass hosts[] = {
 		{  AMPERE_CHANNEL_GPFIFO_B, 0 },
 		{  AMPERE_CHANNEL_GPFIFO_A, 0 },
 		{  TURING_CHANNEL_GPFIFO_A, 0 },