diff mbox series

drm/rockchip: vop2: Demote message in mod_supported to drm_dbg_kms

Message ID 20231009103753.830458-1-m.tretter@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series drm/rockchip: vop2: Demote message in mod_supported to drm_dbg_kms | expand

Commit Message

Michael Tretter Oct. 9, 2023, 10:37 a.m. UTC
Checking if a modifier is supported by a plane is normal behavior. It is
normal that a plane may not support certain modifiers. Failing the check
doesn't justify an error message in the kernel log and may mislead
users.

Demote the error message to drm_dbg_kms to only print the message if the
respective debug messages are enabled. This is similar to the behavior
in rockchip_drm_vop.c.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heiko Stübner Oct. 9, 2023, 8:37 p.m. UTC | #1
On Mon, 9 Oct 2023 12:37:53 +0200, Michael Tretter wrote:
> Checking if a modifier is supported by a plane is normal behavior. It is
> normal that a plane may not support certain modifiers. Failing the check
> doesn't justify an error message in the kernel log and may mislead
> users.
> 
> Demote the error message to drm_dbg_kms to only print the message if the
> respective debug messages are enabled. This is similar to the behavior
> in rockchip_drm_vop.c.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: vop2: Demote message in mod_supported to drm_dbg_kms
      commit: eb23cffdd7f085149799e5eda12a9aff792cc34d

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 583df4d22f7e..003c7c189132 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -469,8 +469,8 @@  static bool rockchip_vop2_mod_supported(struct drm_plane *plane, u32 format,
 		return true;
 
 	if (!rockchip_afbc(plane, modifier)) {
-		drm_err(vop2->drm, "Unsupported format modifier 0x%llx\n",
-			modifier);
+		drm_dbg_kms(vop2->drm, "Unsupported format modifier 0x%llx\n",
+			    modifier);
 
 		return false;
 	}