From patchwork Mon Oct 16 20:04:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13424043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC238CDB474 for ; Mon, 16 Oct 2023 20:04:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD2A710E0B5; Mon, 16 Oct 2023 20:04:28 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D19610E0B5; Mon, 16 Oct 2023 20:04:26 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id DB05AB81923; Mon, 16 Oct 2023 20:04:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76274C433C7; Mon, 16 Oct 2023 20:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697486664; bh=LicEPcKoL9Sru0ZtpvzVU3YUUcuxZ6s7vspnx7TkER4=; h=From:To:Cc:Subject:Date:From; b=NF3cSB3najqsbPo3qib9+Dzj+MAvqLUUgu9V+CzC61e/PcC/3U8wuBF+GWcuNlajs 9PjV3EQnpMyo7CnVqq+v3ODtP8TTKE9CRBmXL5kvpIXalUTeT2UuUTIHPWM8IWXCM7 wpRkICK80B8j51mS3KMD2R/hsBQ2LoaBMEBFnE32fbJ5l3DOvJm/qxVqJMGXFUCy2W UOgVv6nBwGvaTP4yA/h6hvSC+bg37y5ofArWrp75AYj0tDVeT+N/WdFNS0dPgqLVLC TBbuYYR6lNGcw95F+epv8LeK9MXgh7bMTweBSxqzd9Ix6379AeQN9e163/BkVcuxf7 nymLpxS0Ju75A== From: Arnd Bergmann To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , David Airlie , Daniel Vetter , Konrad Dybcio Subject: [PATCH] drm/msm/a6xx: add QMP dependency Date: Mon, 16 Oct 2023 22:04:03 +0200 Message-Id: <20231016200415.791090-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Ulf Hansson , Arnd Bergmann , Akhil P Oommen , linux-arm-msm@vger.kernel.org, Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Marijn Suijten , freedreno@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in: x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options. Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") Signed-off-by: Arnd Bergmann Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 6309a857ca312..ad70b611b44f0 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -6,6 +6,7 @@ config DRM_MSM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on COMMON_CLK depends on IOMMU_SUPPORT + depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n depends on QCOM_OCMEM || QCOM_OCMEM=n depends on QCOM_LLCC || QCOM_LLCC=n depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n