[RFC,v2,01/17] drm/atomic: Allow get_value for immutable properties on atomic drivers

Commit Message

Harry Wentland Oct. 19, 2023, 9:21 p.m. UTC

drm_colorops use immutable properties, for type and next.
Even though drivers create these properties at initialization
they will need to look at the properties when parsing a
color pipeline for programming during an atomic check
or commit operation.

This aligns the get_value call with behavior of the set_value
call.

Signed-off-by: Harry Wentland <[e-mail]>
Cc: Ville Syrjala <[e-mail]>
Cc: Pekka Paalanen <[e-mail]>
Cc: Simon Ser <[e-mail]>
Cc: Harry Wentland <[e-mail]>
Cc: Melissa Wen <[e-mail]>
Cc: Jonas Ådahl <[e-mail]>
Cc: Sebastian Wick <[e-mail]>
Cc: Shashank Sharma <[e-mail]>
Cc: Alexander Goins <[e-mail]>
Cc: Joshua Ashton <[e-mail]>
Cc: Michel Dänzer <[e-mail]>
Cc: Aleix Pol <[e-mail]>
Cc: Xaver Hugl <[e-mail]>
Cc: Victoria Brekenfeld <[e-mail]>
Cc: Sima <[e-mail]>
Cc: Uma Shankar <[e-mail]>
Cc: Naseer Ahmed <[e-mail]>
Cc: Christopher Braga <[e-mail]>
Cc: Abhinav Kumar <[e-mail]>
Cc: Arthur Grillo <[e-mail]>
Cc: Hector Martin <[e-mail]>
Cc: Liviu Dudau <[e-mail]>
Cc: Sasha McIntosh <[e-mail]>
---
 drivers/gpu/drm/drm_mode_object.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/drivers/gpu/drm/drm_mode_object.c b/drivers/gpu/drm/drm_mode_object.c
index ac0d2ce3f870..c9b1cd48547a 100644
--- a/drivers/gpu/drm/drm_mode_object.c
+++ b/drivers/gpu/drm/drm_mode_object.c
@@ -351,7 +351,8 @@  static int __drm_object_property_get_value(struct drm_mode_object *obj,
 int drm_object_property_get_value(struct drm_mode_object *obj,
 				  struct drm_property *property, uint64_t *val)
 {
-	WARN_ON(drm_drv_uses_atomic_modeset(property->dev));
+	WARN_ON(drm_drv_uses_atomic_modeset(property->dev) &&
+		!(property->flags & DRM_MODE_PROP_IMMUTABLE));
 
 	return __drm_object_property_get_value(obj, property, val);
 }