From patchwork Thu Nov 23 09:40:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13466008 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE168C624B4 for ; Thu, 23 Nov 2023 09:41:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD38010E702; Thu, 23 Nov 2023 09:41:10 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6626F10E701 for ; Thu, 23 Nov 2023 09:41:02 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a011e9bf336so84206766b.3 for ; Thu, 23 Nov 2023 01:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732461; x=1701337261; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lHDf4R0aqtCOREGjSJoba2ofOslBc7XL2VIsmReJ8Yw=; b=jXIKhbMccGuXyktBkpOAiiCs/LjOiQjZEdh7V9L02JFnSiPSWs4GYJkxn+JIy3Zmeg uXQ/5Y6/priUe9IkLj/OXMvvbrlXu4IXpISSSZnjeKVmb2lUtTPEl4kxADFBk6UGI+Zm GoIyLvm7rOkS/SijCZR7PNkRNg6NuwEb1buTovBw939WIIyb/Z3zLIg5nDnDLLR6VNXb maDO0idv0oaIeoJ8Bn/pAbbV3KeMiVt4mdePwSw93/z797fqOqrr8N4iVahvtaqACy2o aNyiXixhG3H6hOEnk5JdUCgQOdpvLG8XfrQAR4j+SAfNPwmtsW3HJNgqCHcW4q+8seCm bC3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732461; x=1701337261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHDf4R0aqtCOREGjSJoba2ofOslBc7XL2VIsmReJ8Yw=; b=JNTs9GJ96U5Rp6cQqNNwqbdfI2HpPICzIJx1VReNRtZ2P+voHQikDIvMHyc38tpsYI Pd+AFZtBzqb6SD2rxoZUXfZUSj6EswL/MjY33GWiurEXpGWdWVuUqBS2vdaC2CQ+hmrQ d5+0AQrImgtFbgxn5BJtTJWPfJTf4TgWc2OzBvwNMbiAf80jppLopDTcTu3viK+Yx6jV qZMJPVfQoJWCFZugN4r2sWAM47mA8TifnyRKYqhDedwiGqM78efUfJoWsgoOFPfAduGH uJw3rgJ4VJJRJmOz2j70S5Z+3hlr5rNkWxlcjBv+WVSvNxI7vlYkQm9l22Zlsq8/cRhA sHSw== X-Gm-Message-State: AOJu0Yyu8Om8vxP955PED3/XXt2zHrNM79B4FGUQjyXnYD6CXsacYnSA sH7OAZqjd1AxqN7ApoZyRyY= X-Google-Smtp-Source: AGHT+IEwScrsHwrV5UGKEZ7+DczopxJBuohCG5m5Mpc0AmS7jPDAA//6e5U/+0AoBHxE87JZKJXzdA== X-Received: by 2002:a17:907:2915:b0:9c3:1d7e:f5b5 with SMTP id eq21-20020a170907291500b009c31d7ef5b5mr2676823ejc.20.1700732460355; Thu, 23 Nov 2023 01:41:00 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:59 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH v5 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:38 +0100 Message-ID: <20231123094040.592-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo;