| Message ID | 20231204171317.192427-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle() | expand |
On Mon, 4 Dec 2023 at 19:13, Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > > When pm_runtime_resume_and_get() fails, unlock before returning. > > Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is based on static analysis with Smatch. Only compile tested. > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 04 Dec 2023 09:13:14 -0800, Harshit Mogalapalli wrote: > When pm_runtime_resume_and_get() fails, unlock before returning. > > Applied, thanks! [1/1] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle() https://gitlab.freedesktop.org/lumag/msm/-/commit/801207c18834 Best regards,
On 12/4/2023 9:13 AM, Harshit Mogalapalli wrote: > When pm_runtime_resume_and_get() fails, unlock before returning. > > Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is based on static analysis with Smatch. Only compile tested. > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 61b7103498a7..b57ff6c3215d 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -569,6 +569,7 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data) ret = pm_runtime_resume_and_get(&pdev->dev); if (ret) { DRM_ERROR("failed to pm_runtime_resume\n"); + mutex_unlock(&dp->event_mutex); return ret; }
When pm_runtime_resume_and_get() fails, unlock before returning. Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- This is based on static analysis with Smatch. Only compile tested. --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+)