From patchwork Tue Dec 5 10:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13479947 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F82FC4167B for ; Tue, 5 Dec 2023 10:54:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A576110E4E2; Tue, 5 Dec 2023 10:54:07 +0000 (UTC) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id F136010E4E0 for ; Tue, 5 Dec 2023 10:54:04 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a1975fe7befso593150766b.2 for ; Tue, 05 Dec 2023 02:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773643; x=1702378443; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=ABX+SXSeu4lBmRLWUn7kG6zsgPQFo0I9w9ztscs7TRXfqWdo9KWbH7mpZVoF1mIL+J xAqvV8gDArfuX9g2cVUUiQjU8VNf+moJCI3KOF0kyqn0VrQCxOKEGOShrs3EOq7Ap+9N MUZ3a0iL6fN1r9Ugy7GldF8p9PlnI4WtC8kBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773643; x=1702378443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=VZRCpPxMniI58VGjaXX9sbsyCYoXcD6FG8y4o4uzFGIlVAxPH/aywo6wtzvEUBYVcf dWzppmh8dnuBCBcLs2e7/ecWKQqZF/5O0+7oEgRxM3WFGS3XeGC5mWAyxvnEKK4YBHnw jdjeEErrr3R9/UBd3fGz7ZvgUnc9011cL+bUzX0oGDaNnFiClmCufbzMCOK8oTCa0alE BJ0qfzlA3gTxnJ88JxPpNjpGkTHEOu/V0YlUMk8uOu+vCnEiAl1VriX2KxgAz8+C/IlO 8NotnovOG41vZp4Cy7xxGoK+V9LHMbKheSDZEn2U0CjFRqlxd/pYJoF9RDjLxkrOhYqi IjqQ== X-Gm-Message-State: AOJu0YwtPSZKeLbklEy1AOpjI2u4peyWE2kBpXkQloyNFoQ6MxGzqhoI 4jfUFzU/RlGwUIHO+TkNMRzBfA== X-Google-Smtp-Source: AGHT+IEhCW86sDDqX5HhYwo9leDEXnK3BBE5ui8/2dHRSqsGfYqV4vVQgDEtuqv3sS8ZVoS+1vs00Q== X-Received: by 2002:a17:906:2814:b0:a19:a19a:eadc with SMTP id r20-20020a170906281400b00a19a19aeadcmr311534ejc.149.1701773643372; Tue, 05 Dec 2023 02:54:03 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:03 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Subject: [PATCH v4 01/10] drm/bridge: Fix bridge disable logic Date: Tue, 5 Dec 2023 11:52:48 +0100 Message-ID: <20231205105341.4100896-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Dario Binacchi , Robert Foss , Andrzej Hajda , Thomas Zimmermann , Dave Stevenson , dri-devel@lists.freedesktop.org, Jonas Karlman , Frieder Schrempf , Jernej Skrabec , michael@amarulasolutions.com, Amarula patchwork , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" flag to true. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..f66bf4925dd8 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -686,7 +686,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, */ list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { - if (next->pre_enable_prev_first) { + if (!next->pre_enable_prev_first) { next = list_prev_entry(next, chain_node); limit = next; break;