diff mbox series

dt-bindings: display: adi,adv75xx: Document #sound-dai-cells

Message ID 20231206012831.2179356-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: display: adi,adv75xx: Document #sound-dai-cells | expand

Commit Message

Fabio Estevam Dec. 6, 2023, 1:28 a.m. UTC
From: Fabio Estevam <festevam@denx.de>

When using audio from ADV7533 or ADV7535 and describing the audio
card via simple-audio-card, the '#sound-dai-cells' needs to be passed.

Document the '#sound-dai-cells' property to fix the following
dt-schema warning:

imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
	
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
 1 file changed, 3 insertions(+)

Comments

Adam Ford Dec. 6, 2023, 2:43 a.m. UTC | #1
On Tue, Dec 5, 2023 at 7:28 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> When using audio from ADV7533 or ADV7535 and describing the audio
> card via simple-audio-card, the '#sound-dai-cells' needs to be passed.
>
> Document the '#sound-dai-cells' property to fix the following
> dt-schema warning:
>

Thanks for doing that.

> imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
>

Acked-by: Adam Ford <aford173@gmail.com>

> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> index 987aa83c2649..e15ae072922e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> @@ -89,6 +89,9 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [ 1, 2, 3, 4 ]
>
> +  '#sound-dai-cells':
> +    const: 0
> +
>    ports:
>      description:
>        The ADV7533/35 has two video ports and one audio port.
> --
> 2.34.1
>
Krzysztof Kozlowski Dec. 6, 2023, 8:57 a.m. UTC | #2
On 06/12/2023 02:28, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> When using audio from ADV7533 or ADV7535 and describing the audio
> card via simple-audio-card, the '#sound-dai-cells' needs to be passed.
> 
> Document the '#sound-dai-cells' property to fix the following
> dt-schema warning:
> 
> imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> index 987aa83c2649..e15ae072922e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> @@ -89,6 +89,9 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [ 1, 2, 3, 4 ]
>  

Then please also reference /schemas/sound/dai-common.yaml

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
index 987aa83c2649..e15ae072922e 100644
--- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
@@ -89,6 +89,9 @@  properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum: [ 1, 2, 3, 4 ]
 
+  '#sound-dai-cells':
+    const: 0
+
   ports:
     description:
       The ADV7533/35 has two video ports and one audio port.