| Message ID | 20231219150318.368398-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/therm: remove redundant duty == target check | expand |
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c index f8fa43c8a7d2..c4aaf7473065 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c @@ -90,8 +90,6 @@ nvkm_fan_update(struct nvkm_fan *fan, bool immediate, int target) if (duty > target) delay = slow_down_period; - else if (duty == target) - delay = min(bump_period, slow_down_period) ; else delay = bump_period;
The check for duty == target is always false because it is in an if block where duty != target. A previous change added the duty != target check and so the check duty == target check is now redundant and can be removed. Cleans up a cppcheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c:93:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] Fixes: e4311ee51d1e ("drm/nouveau/therm: remove ineffective workarounds for alarm bugs") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 -- 1 file changed, 2 deletions(-)