From patchwork Fri Jan 5 10:13:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Micha=C5=82_Winiarski?= X-Patchwork-Id: 13511914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DED8C47079 for ; Fri, 5 Jan 2024 10:13:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3071510E5CC; Fri, 5 Jan 2024 10:13:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BFAC10E5CC; Fri, 5 Jan 2024 10:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704449636; x=1735985636; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=yngqZG8Spc06NTUdaXFEbO5cTO9IfPcH40tZek15x7A=; b=bEcfQJktuS7mLupe6kbxNc3r0LI79YmUWpLBk6qEdIiOq7tT/G/IQKH8 1cvyQZxBohNgZnMcBexZvQ+gnmTIg0txbkocH9TimI92aFFU22i39K8dC IRfLtX8/DG2n2ow6yzXr/y3Lt7JGj0QcO/S7yJZVd9UZfLZpsACulafo7 WPFMxU7Cqbz5MiAVUM2W+kFvEd5ztB0kGswzLKF5j29KdwgcJneFI3guo asrKT5Ul7qi235PlqmF6dzciQWS78mK4YJuG5lXqORpLW9NInAiVRgmQY HaPFKe7NmEtpwNo/sjl4AKFG0qFuJtmfzDUvupB/zFbbZR9kfXzYXrDSz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="483651634" X-IronPort-AV: E=Sophos;i="6.04,333,1695711600"; d="scan'208";a="483651634" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 02:13:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="730435473" X-IronPort-AV: E=Sophos;i="6.04,333,1695711600"; d="scan'208";a="730435473" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jan 2024 02:13:55 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Jan 2024 02:13:55 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 5 Jan 2024 02:13:55 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 5 Jan 2024 02:13:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpR5RtF1eUQtOFq1o/wlSlGClbX/rgRqjQbEqis713MFwJ/DJOvt5+IAbcXQFQTnTC6JJ93JzTiO/aVUR5cC16uYa8uL9ASxkZ5OWdTKpeuXrF/GllcvLsatEew7MluPNj4iunKKHwJ+asBV4+HAUQpZA6Mlh18PDxvESf74sAAXqO67YNiqJZkPmJ04+1IZnEk+IdyNf3rMbqg2FhxD2IH8ZptbcmIrxRl1zbyypUDzaBc6j6dNJAI5t6+BmShHirf2CJLGqmVRYGq21WLCxdxeMI3CToO2xyazeNsRPI2+rOpmom2XORx05hzzrA2W2pU1jDJVCI72Kl1FqcpNMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=36WGdOADJ6H/0w6QoNAwTeI1Doo4V2GznzvvWmIxLvs=; b=cF+hDv7YhvTwQg4BoDsMriUzkqYt+RHt37/ljx2A5c9DdOcy+95FyXuEfYOos20OlaR27SX10gL96DXE5IVbeHqTP5h4gUEH/dU8u5ZHoyEigPkm+dejfV1pJuf/ePohmRf+FPmHlv3xYdph0rzf3ZD+v1ii7BYk4ePOdM6J/NRpka6yBtXnvGDu7NC5/0dppsj1mZG4/xt6086XXu2WY8nqD62DuyWpCaJ/8WJbGlbt0wLK1LV7IysTMuUP4Mu30464KGTD8MDrAi7AkpoEu1z8gosbXaqPF60AtobnGRfhSpP46hoOWJsfRohuoCb8K7XawDezxucJSakH/vvzJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB5373.namprd11.prod.outlook.com (2603:10b6:5:394::7) by PH0PR11MB4823.namprd11.prod.outlook.com (2603:10b6:510:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.17; Fri, 5 Jan 2024 10:13:47 +0000 Received: from DM4PR11MB5373.namprd11.prod.outlook.com ([fe80::f105:47dd:6794:6821]) by DM4PR11MB5373.namprd11.prod.outlook.com ([fe80::f105:47dd:6794:6821%4]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 10:13:46 +0000 From: =?utf-8?q?Micha=C5=82_Winiarski?= To: , , Subject: [PATCH v4 4/6] drm/tests: managed: Add comments and expect fail messages Date: Fri, 5 Jan 2024 11:13:22 +0100 Message-ID: <20240105101324.26811-5-michal.winiarski@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240105101324.26811-1-michal.winiarski@intel.com> References: <20240105101324.26811-1-michal.winiarski@intel.com> X-ClientProxiedBy: VI1PR0502CA0007.eurprd05.prod.outlook.com (2603:10a6:803:1::20) To BL1PR11MB5365.namprd11.prod.outlook.com (2603:10b6:208:308::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB5373:EE_|PH0PR11MB4823:EE_ X-MS-Office365-Filtering-Correlation-Id: d960fb1a-3988-44e4-87d6-08dc0dd700bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4DqXvZf7zn2juiK45TfYS6bAOq4clc8FnN8tOHK50lyFlqOi5TIjHvHsiwdJQBGppwvuxr6CudcLKDgWJM4kYwOx9mlvNeYegF5VNRyzrVV4X/yF13o2bveBYEonEBoeNzDPqPITX5dvItnhf7+Wx2p1lHYYUrdWY3ilc5MUyDUu2ufK5vP3KjS2Cmy/9Z0JMIFQMIsxooqm24tlusIQZ+EWYrGcn8QvEZ+74JnJwHmmbr2K5Q8PllZfq5HeoYrWtdL/4X9a76Hl076/I8kg01qTzrXG5E6jaTGnks2jtN2cCts3wTA4pwG8NZXZbI74yG/nD2lkQA3RjATkJEugZBk20w54Uw5J9RxJS9h0mU0ymt+WKNXmc6dJDouL+dkKPVCkuHBwC5Avo0c0tiFyCPGvlc5bZhjBVrilWZ0BpFnTLB5I271qEj4iWJL+1I+hGaKYt+zwL37kP9bi4SXRmddMkRWmLDMP+fJoMHLfvOVmNX4F1XApEvjxJYiL72xf96h5whXHR+zT2oUlB4plS1vmKhR7Q8JY4waXl30jZz/ngC7hafZEEwKXdAzqGpUO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5373.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(2616005)(26005)(1076003)(6666004)(6506007)(6512007)(86362001)(83380400001)(4326008)(8676002)(8936002)(316002)(54906003)(7416002)(36756003)(2906002)(5660300002)(6486002)(478600001)(66946007)(66476007)(66556008)(38100700002)(82960400001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Px3gXKRcJUfyHDqpyEp44t0wTWaz?= =?utf-8?q?dnMFLzd9mp/I5FMVtSLnQ0r1WLm3Hnxs4iyT5T1NOCT/Y41kTkpEAM/PCsvVZ5hwl?= =?utf-8?q?DpaEDciLFSj9hSTOm5e6iEyWbbKCkjdLvbVGQKQPb2+2eTBIFrf0NlAFpYNU+g/t1?= =?utf-8?q?Fb8T599IlwmUlye1vTf2j3vKBgjphvntSdd2lXNePtElNch88NjPG23ViBPGjLcDq?= =?utf-8?q?R3RJbYjDOMtO9P8aPrb4vAEI87NUMLv+DZM5ycLHU+S9HMk/Ri8BphxgSU2gGtuzl?= =?utf-8?q?D2HqQp8THjkpEHEpMAL7SNwELZnsgFq+W3n6zZ/Ds2sGSBcZbd51d95tTnvkm2pb4?= =?utf-8?q?xvdblYif1/3gQaES1IrnRmelw0g/enZ42cN7E2s1pqko0iQ6N1KiBNWDAqIN9W+0Q?= =?utf-8?q?roUagHdLzqhI1up/6nI6CxmWhRs8jnmfl2Z/G5v6o9vLUBS5nMrjmLqdknyUi9l6C?= =?utf-8?q?Mz5BG+njIPpMepHTaDTtZD1MLHU5ZFsfRPN5AOj1gV2UuL1BDS565jA8gSEkUCzVe?= =?utf-8?q?/qNKmxPPkbp18qgue3GKzeoGCheuMbDkH079O66TpzF57Y1WIJbeoQKx2qfPzzbPy?= =?utf-8?q?/vATTW/ThsQu8s33czN/sGmskUOYaSBdf4nZdVebGzJDst1pvvxmpVsak+LSEmhw4?= =?utf-8?q?8hO7Au2ls4kaBOyjRucXA8FDLbNEc273IEewN8ssAQ3o4VD7GrI9nPs/xlOOXmUPC?= =?utf-8?q?PCzA8FClGk0XcMNRRMu6Z73wCSYK3a0e7B19XXrdGZelj9fq1qJbPfNu5q1ab/q3p?= =?utf-8?q?FOVj47zrPisOzspSP/xakav4O9UwEnTjR5Lwa12uRPwGnFviZCfJtUbAswnNCg0UG?= =?utf-8?q?0oa6bAGxPc5599WQX8ZOy3c0EgRZXJTO1Z7pJcei17xaSPH4COe1tq6WhfDs0Z01r?= =?utf-8?q?OFBh4T7MbtMdogsF56+dU172WCCqVS0ZMpcUlz9BZx0ECCcjE78XnIzplBbwHgdrp?= =?utf-8?q?yvchE1ux8VYs1q6brXYBqjGliP0X7Yl6KJlTnA5NCcyjK4IFXUzNPrNQ+xwVptP6P?= =?utf-8?q?1J/KmPJgBacGvLzsd8d2UwyBrywACD44WLKh+5YVcYVlNJ6NoW/FcHACZbrK6bHtu?= =?utf-8?q?r2Opxjoy6uInag+BbkeF1Cn/7it88t1tfCuCBS0bF/HKM48ZeI0t5mw8KByWS8+ak?= =?utf-8?q?7NcmNn9Y+EoPborFtKqkM5csTYrQl3pPsZyif3JAxIeH03WBqORwsER/IxODSk6AA?= =?utf-8?q?jJ+eTBfI9YgZuEf6uxgaRGPEuzbilrqZ19x0zJ2m1dqZ1ErOsf7blf9ndZoG7V7zO?= =?utf-8?q?e/pjHuXYOIZuwvVE71W6nnQDyH+MUDGm6Gwaju7PHLi8JHUuqfrSbk9qF3gIOtW2K?= =?utf-8?q?OB6ONiw4fnWR2tnS98t8AiXpE2BMK4LS6fhzRckyFxKkGb2zmj3UH4mdlQf39S1Q9?= =?utf-8?q?NAzHm0SiJwr3HuxS/CiEjA6NKffr6PaodKwtXcmo3so84uiV1XDrlIKYAbiCBlAMX?= =?utf-8?q?BN/T1d06bc78mtn09PcZCNAlwmLunFHp1Zpf4MheK+2ZNMCgKe0R59uElz5EV7GUC?= =?utf-8?q?RpE1aQVRMBgay9Jbd/Kmtj8KBJIOyqlHiQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d960fb1a-3988-44e4-87d6-08dc0dd700bc X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5365.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 10:13:46.6390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wnBS3Xq0KhmIAbrqLEYcMVDLROpXSuYfz8ax9F94iaGEqq0Ue+yRBIWv1MzvSMnUDgT8eAklSpjX6TvHWoz6ObugDd9nGd08Pk+0N00mPXw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823 X-OriginatorOrg: intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Micha=C5=82_Winiarski?= , =?utf-8?q?Ma=C3=ADra_Canal?= , Javier Martinez Canillas , Maxime Ripard , Thomas Zimmermann , Rodrigo Vivi , Michal Wajdeczko Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add comments explaining the intention behind the test and certain implementation details related to device lifetime. Signed-off-by: Michał Winiarski --- drivers/gpu/drm/tests/drm_managed_test.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c index e4790ae838ba7..986a38c9144a5 100644 --- a/drivers/gpu/drm/tests/drm_managed_test.c +++ b/drivers/gpu/drm/tests/drm_managed_test.c @@ -19,6 +19,10 @@ static void drm_action(struct drm_device *drm, void *ptr) priv->action_done = true; } +/* + * The test verifies that the release action is called automatically when the + * device is released. + */ static void drm_test_managed_run_action(struct kunit *test) { struct managed_test_priv *priv; @@ -32,6 +36,11 @@ static void drm_test_managed_run_action(struct kunit *test) dev = drm_kunit_helper_alloc_device(test); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev); + /* + * DRM device can't be embedded in priv, since priv->action_done needs + * to remain allocated beyond both parent device and drm_device + * lifetime. + */ drm = __drm_kunit_helper_alloc_drm_device(test, dev, sizeof(*drm), 0, DRIVER_MODESET); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm); @@ -44,7 +53,7 @@ static void drm_test_managed_run_action(struct kunit *test) drm_dev_unregister(drm); drm_kunit_helper_free_device(test, dev); - KUNIT_EXPECT_TRUE(test, priv->action_done); + KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called"); } static struct kunit_case drm_managed_tests[] = {