| Message ID | 20240108152514.533414-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] drm: bridge: dw_hdmi: Set DRM bridge type | expand |
On 08/01/2024 16:25, Alexander Stein wrote: > The bridge type was set to default (Unknown). Set proper bridge type. > With this fixed, debugfs output imx8mp looks proper. > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] > type: [0] Unknown > OF: /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi > ops: [0x0] > bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] > type: [11] HDMI-A > OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi > ops: [0x7] detect edid hpd > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > For the record, the output before is: > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] > type: [0] Unknown > OF: /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi > ops: [0x0] > bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] > type: [0] Unknown > OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi > ops: [0x7] detect edid hpd > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index aca5bb0866f88..455bc15d90cc1 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3541,6 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, > hdmi->bridge.interlace_allowed = true; > hdmi->bridge.ddc = hdmi->ddc; > hdmi->bridge.of_node = pdev->dev.of_node; > + hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA; > > memset(&pdevinfo, 0, sizeof(pdevinfo)); > pdevinfo.parent = dev; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi everyone, Am Montag, 8. Januar 2024, 18:00:58 CET schrieb Neil Armstrong: > On 08/01/2024 16:25, Alexander Stein wrote: > > The bridge type was set to default (Unknown). Set proper bridge type. > > With this fixed, debugfs output imx8mp looks proper. > > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] > > > > type: [0] Unknown > > OF: > > /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi > > ops: [0x0] > > > > bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] > > > > type: [11] HDMI-A > > OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi > > ops: [0x7] detect edid hpd > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > For the record, the output before is: > > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] > > > > type: [0] Unknown > > OF: > > /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi > > ops: [0x0] > > > > bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] > > > > type: [0] Unknown > > OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi > > ops: [0x7] detect edid hpd > > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index > > aca5bb0866f88..455bc15d90cc1 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -3541,6 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device > > *pdev,> > > hdmi->bridge.interlace_allowed = true; > > hdmi->bridge.ddc = hdmi->ddc; > > hdmi->bridge.of_node = pdev->dev.of_node; > > > > + hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA; > > > > memset(&pdevinfo, 0, sizeof(pdevinfo)); > > pdevinfo.parent = dev; > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Any additional feedback? Thanks, Alexander
Hi, On Mon, 08 Jan 2024 16:25:14 +0100, Alexander Stein wrote: > The bridge type was set to default (Unknown). Set proper bridge type. > With this fixed, debugfs output imx8mp looks proper. > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] > type: [0] Unknown > OF: /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi > ops: [0x0] > bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] > type: [11] HDMI-A > OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi > ops: [0x7] detect edid hpd > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: bridge: dw_hdmi: Set DRM bridge type https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f63f24488571fdd6f6aa910f2db5a7f3d44a4da6
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index aca5bb0866f88..455bc15d90cc1 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -3541,6 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, hdmi->bridge.interlace_allowed = true; hdmi->bridge.ddc = hdmi->ddc; hdmi->bridge.of_node = pdev->dev.of_node; + hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA; memset(&pdevinfo, 0, sizeof(pdevinfo)); pdevinfo.parent = dev;
The bridge type was set to default (Unknown). Set proper bridge type. With this fixed, debugfs output imx8mp looks proper. $ cat /sys/kernel/debug/dri/1/encoder-0/bridges bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] type: [0] Unknown OF: /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi ops: [0x0] bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] type: [11] HDMI-A OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi ops: [0x7] detect edid hpd Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- For the record, the output before is: $ cat /sys/kernel/debug/dri/1/encoder-0/bridges bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] type: [0] Unknown OF: /soc@0/bus@32c00000/display-bridge@32fc4000:fsl,imx8mp-hdmi-pvi ops: [0x0] bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi] type: [0] Unknown OF: /soc@0/bus@32c00000/hdmi@32fd8000:fsl,imx8mp-hdmi ops: [0x7] detect edid hpd drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + 1 file changed, 1 insertion(+)