| Message ID | 20240110082245.417736-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/1] drm: panel: simple: convert LG LB070WV8 fixed mode into display timings | expand |
On 10/01/2024 09:22, Alexander Stein wrote: > At least the pixelclock has a range which can vary. Convert fixed mode > into display timings so they can be overwritten in DT if necessary. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes in v2: > * Rebase to next-20240110 > > drivers/gpu/drm/panel/panel-simple.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d3ba94f796a32..754e154f22bfc 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2793,21 +2793,21 @@ static const struct panel_desc lemaker_bl035_rgb_002 = { > .bus_flags = DRM_BUS_FLAG_DE_LOW, > }; > > -static const struct drm_display_mode lg_lb070wv8_mode = { > - .clock = 33246, > - .hdisplay = 800, > - .hsync_start = 800 + 88, > - .hsync_end = 800 + 88 + 80, > - .htotal = 800 + 88 + 80 + 88, > - .vdisplay = 480, > - .vsync_start = 480 + 10, > - .vsync_end = 480 + 10 + 25, > - .vtotal = 480 + 10 + 25 + 10, > +static const struct display_timing lg_lb070wv8_timing = { > + .pixelclock = { 31950000, 33260000, 34600000 }, > + .hactive = { 800, 800, 800 }, > + .hfront_porch = { 88, 88, 88 }, > + .hback_porch = { 88, 88, 88 }, > + .hsync_len = { 80, 80, 80 }, > + .vactive = { 480, 480, 480 }, > + .vfront_porch = { 10, 10, 10 }, > + .vback_porch = { 10, 10, 10 }, > + .vsync_len = { 25, 25, 25 }, > }; > > static const struct panel_desc lg_lb070wv8 = { > - .modes = &lg_lb070wv8_mode, > - .num_modes = 1, > + .timings = &lg_lb070wv8_timing, > + .num_timings = 1, > .bpc = 8, > .size = { > .width = 151, Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Wed, 10 Jan 2024 09:22:45 +0100, Alexander Stein wrote: > At least the pixelclock has a range which can vary. Convert fixed mode > into display timings so they can be overwritten in DT if necessary. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: panel: simple: convert LG LB070WV8 fixed mode into display timings https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c3ba13a0ed3d81d28aaf475687a5f39766566768
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index d3ba94f796a32..754e154f22bfc 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2793,21 +2793,21 @@ static const struct panel_desc lemaker_bl035_rgb_002 = { .bus_flags = DRM_BUS_FLAG_DE_LOW, }; -static const struct drm_display_mode lg_lb070wv8_mode = { - .clock = 33246, - .hdisplay = 800, - .hsync_start = 800 + 88, - .hsync_end = 800 + 88 + 80, - .htotal = 800 + 88 + 80 + 88, - .vdisplay = 480, - .vsync_start = 480 + 10, - .vsync_end = 480 + 10 + 25, - .vtotal = 480 + 10 + 25 + 10, +static const struct display_timing lg_lb070wv8_timing = { + .pixelclock = { 31950000, 33260000, 34600000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 88, 88, 88 }, + .hback_porch = { 88, 88, 88 }, + .hsync_len = { 80, 80, 80 }, + .vactive = { 480, 480, 480 }, + .vfront_porch = { 10, 10, 10 }, + .vback_porch = { 10, 10, 10 }, + .vsync_len = { 25, 25, 25 }, }; static const struct panel_desc lg_lb070wv8 = { - .modes = &lg_lb070wv8_mode, - .num_modes = 1, + .timings = &lg_lb070wv8_timing, + .num_timings = 1, .bpc = 8, .size = { .width = 151,
At least the pixelclock has a range which can vary. Convert fixed mode into display timings so they can be overwritten in DT if necessary. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changes in v2: * Rebase to next-20240110 drivers/gpu/drm/panel/panel-simple.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)