diff mbox series

[40/46] dma-buf: move dma-buf symbols into the DMA_BUF module namespace.

Message ID 20240202083153.2635684-41-kolanupaka.naveena@intel.com (mailing list archive)
State New, archived
Headers show
Series None | expand

Commit Message

Kolanupaka Naveena Feb. 2, 2024, 8:31 a.m. UTC 
From: Sagar Chormale <sagar.chormale@intel.com>

In order to better track where in the kernel the dma-buf code is used,
put the symbols in the namespace DMA_BUF and modify all users of the
symbols to properly import the namespace to not break the build at the
same time.

Now the output of modinfo shows the use of these symbols, making it
easier to watch for users over time.

$ modinfo drivers/misc/fastrpc.ko | grep import
import_ns:      DMA_BUF

Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://lore.kernel.org/r/20211010124628.17691-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-------------------------------------------------------------------------------
Backports

'commit 16b0314aa746 ("dma-buf: move dma-buf symbols into the DMA_BUF
module namespace.")'

Signed-off-by: Sagar Chormale <sagar.chormale@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Greg Kroah-Hartman Feb. 2, 2024, 4:16 p.m. UTC | #1 
On Fri, Feb 02, 2024 at 02:01:47PM +0530, Kolanupaka Naveena wrote:
> +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> +#include <linux/module.h>
> +#endif

No #ifdef in .c files please, this should not be an issue, just include
the .h file.

>  #include <drm/intel_iaf_platform.h>
>  
>  #include "gem/i915_gem_dmabuf.h"
> @@ -23,6 +26,10 @@
>  #include "i915_trace.h"
>  #include "intel_iaf.h"
>  
> +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> +MODULE_IMPORT_NS(DMA_BUF);
> +#endif

Why is a #ifdef needed here?  If this isn't built as a module, it's not
an issue, please just make it simpler.

But really, why is this a #define at all in the first place?

thanks,

greg k-h
Kolanupaka Naveena Feb. 5, 2024, 1:07 p.m. UTC | #2 
Hi Greg,

Thanks for your inputs and patience in reviewing the patch.
By mistakenly this internal patch has been sent for review as the reference commit ID is from opensource, email has been sent to those who are all involved in that commit.
Please ignore this patch as it is for internal usage.

Thanks and Regards

Kolanupaka Naveena
Graphics Software Engineer | GSE OSGC
M +918374415216
Intel Corporation | intel.com

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Friday, February 2, 2024 9:46 PM
> To: Kolanupaka Naveena <kolanupaka.naveena@intel.com>
> Cc: gfx-internal-devel@eclists.intel.com; Wilson, Chris P
> <chris.p.wilson@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>;
> Muqthyar Ahmed, Syed Abdul <syed.abdul.muqthyar.ahmed@intel.com>;
> Sagar Chormale <sagar.chormale@intel.com>; Pan, Xinhui
> <Xinhui.Pan@amd.com>; David Airlie <airlied@linux.ie>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>;
> Thomas Zimmermann <tzimmermann@suse.de>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; dri-devel@lists.freedesktop.org; Daniel Vetter
> <daniel.vetter@ffwll.ch>; Christian König <christian.koenig@amd.com>; Arnd
> Bergmann <arnd@arndb.de>; Sumit Semwal <sumit.semwal@linaro.org>;
> Alex Deucher <alexander.deucher@amd.com>
> Subject: Re: [PATCH 40/46] dma-buf: move dma-buf symbols into the
> DMA_BUF module namespace.
> 
> On Fri, Feb 02, 2024 at 02:01:47PM +0530, Kolanupaka Naveena wrote:
> > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> > +#include <linux/module.h>
> > +#endif
> 
> No #ifdef in .c files please, this should not be an issue, just include the .h file.
> 
> >  #include <drm/intel_iaf_platform.h>
> >
> >  #include "gem/i915_gem_dmabuf.h"
> > @@ -23,6 +26,10 @@
> >  #include "i915_trace.h"
> >  #include "intel_iaf.h"
> >
> > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
> > +MODULE_IMPORT_NS(DMA_BUF);
> > +#endif
> 
> Why is a #ifdef needed here?  If this isn't built as a module, it's not an issue,
> please just make it simpler.
> 
> But really, why is this a #define at all in the first place?
> 
> thanks,
> 
> greg k-h
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
index d7e4ef3fa589d..6d14315dfce40 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
@@ -9,6 +9,9 @@ 
 #include <linux/list.h>
 #include <linux/pci-p2pdma.h>
 #include <linux/scatterlist.h>
+#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
+#include <linux/module.h>
+#endif
 #include <drm/intel_iaf_platform.h>
 
 #include "gem/i915_gem_dmabuf.h"
@@ -23,6 +26,10 @@ 
 #include "i915_trace.h"
 #include "intel_iaf.h"
 
+#ifdef BPM_MODULE_IMPORT_NS_SUPPORT
+MODULE_IMPORT_NS(DMA_BUF);
+#endif
+
 I915_SELFTEST_DECLARE(static bool force_different_devices;)
 
 static const struct drm_i915_gem_object_ops i915_gem_object_dmabuf_ops;