| Message ID | 20240209140818.106685-1-michal.winiarski@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tests: mm: Convert to drm_dbg_printer | expand |
On 2/9/24 15:08, Michał Winiarski wrote: > Fix one of the tests in drm_mm that was not converted prior to > drm_debug_printer removal, causing tests build failure. > > Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/tests/drm_mm_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index 1eb0c304f9607..3488d930e3a38 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -188,7 +188,7 @@ static void drm_test_mm_init(struct kunit *test) > > static void drm_test_mm_debug(struct kunit *test) > { > - struct drm_printer p = drm_debug_printer(test->name); > + struct drm_printer p = drm_dbg_printer(NULL, DRM_UT_CORE, test->name); > struct drm_mm mm; > struct drm_mm_node nodes[2]; > Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
On 09.02.2024 15:08, Michał Winiarski wrote: > Fix one of the tests in drm_mm that was not converted prior to > drm_debug_printer removal, causing tests build failure. > > Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > --- > drivers/gpu/drm/tests/drm_mm_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index 1eb0c304f9607..3488d930e3a38 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -188,7 +188,7 @@ static void drm_test_mm_init(struct kunit *test) > > static void drm_test_mm_debug(struct kunit *test) > { > - struct drm_printer p = drm_debug_printer(test->name); > + struct drm_printer p = drm_dbg_printer(NULL, DRM_UT_CORE, test->name); > struct drm_mm mm; > struct drm_mm_node nodes[2]; >
On Fri, 09 Feb 2024, Michał Winiarski <michal.winiarski@intel.com> wrote: > Fix one of the tests in drm_mm that was not converted prior to > drm_debug_printer removal, causing tests build failure. My bad, thanks for fixing this. Reviewed-by: Jani Nikula <jani.nikula@intel.com> For one thing, I must not have git grep'd for new drm_debug_printer() additions since I wrote the patch. For another, I'm missing some kernel config, because I built the changes on x86, arm and arm64 before pushing. In particular the arm and arm64 configs I just recently added from drm-rerere repo. Those defconfigs should probably be updated. They don't have CONFIG_DRM_XE=m either. BR, Jani. > > Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/tests/drm_mm_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index 1eb0c304f9607..3488d930e3a38 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -188,7 +188,7 @@ static void drm_test_mm_init(struct kunit *test) > > static void drm_test_mm_debug(struct kunit *test) > { > - struct drm_printer p = drm_debug_printer(test->name); > + struct drm_printer p = drm_dbg_printer(NULL, DRM_UT_CORE, test->name); > struct drm_mm mm; > struct drm_mm_node nodes[2];
diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c index 1eb0c304f9607..3488d930e3a38 100644 --- a/drivers/gpu/drm/tests/drm_mm_test.c +++ b/drivers/gpu/drm/tests/drm_mm_test.c @@ -188,7 +188,7 @@ static void drm_test_mm_init(struct kunit *test) static void drm_test_mm_debug(struct kunit *test) { - struct drm_printer p = drm_debug_printer(test->name); + struct drm_printer p = drm_dbg_printer(NULL, DRM_UT_CORE, test->name); struct drm_mm mm; struct drm_mm_node nodes[2];
Fix one of the tests in drm_mm that was not converted prior to drm_debug_printer removal, causing tests build failure. Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> --- drivers/gpu/drm/tests/drm_mm_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)