| Message ID | 20240214083708.2323967-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm: ci: use clk_ignore_unused for apq8016 | expand |
On 14/02/2024 05:37, Dmitry Baryshkov wrote: > If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is > built-in, the clk_disable_unused congests with the runtime PM handling > of the DSI PHY for the clk_prepare_lock(). This causes apq8016 runner to > fail without completing any jobs ([1]). Drop the BM_CMDLINE which > duplicate the command line from the .baremetal-igt-arm64 clause and > enforce the clk_ignore_unused kernelarg instead to make apq8016 runner > work. > > [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/54990475 > > Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory") > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Acked-by: Helen Koike <helen.koike@collabora.com> Thanks Helen > --- > > Changes in v2: > - Added a comment, describing the issue and a way to reproduce it > (Javier) > > --- > drivers/gpu/drm/ci/test.yml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml > index 7ffb620d7398..e64205286a27 100644 > --- a/drivers/gpu/drm/ci/test.yml > +++ b/drivers/gpu/drm/ci/test.yml > @@ -119,7 +119,10 @@ msm:apq8016: > DRIVER_NAME: msm > BM_DTB: https://${PIPELINE_ARTIFACTS_BASE}/arm64/apq8016-sbc-usb-host.dtb > GPU_VERSION: apq8016 > - BM_CMDLINE: "ip=dhcp console=ttyMSM0,115200n8 $BM_KERNEL_EXTRA_ARGS root=/dev/nfs rw nfsrootdebug nfsroot=,tcp,nfsvers=4.2 init=/init $BM_KERNELARGS" > + # disabling unused clocks congests with the MDSS runtime PM trying to > + # disable those clocks and causes boot to fail. > + # Reproducer: DRM_MSM=y, DRM_I2C_ADV7511=m > + BM_KERNEL_EXTRA_ARGS: clk_ignore_unused > RUNNER_TAG: google-freedreno-db410c > script: > - ./install/bare-metal/fastboot.sh
On 14/02/2024 10:30, Helen Koike wrote: > > > On 14/02/2024 05:37, Dmitry Baryshkov wrote: >> If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is >> built-in, the clk_disable_unused congests with the runtime PM handling >> of the DSI PHY for the clk_prepare_lock(). This causes apq8016 runner to >> fail without completing any jobs ([1]). Drop the BM_CMDLINE which >> duplicate the command line from the .baremetal-igt-arm64 clause and >> enforce the clk_ignore_unused kernelarg instead to make apq8016 runner >> work. >> >> [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/54990475 >> >> Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory") >> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Acked-by: Helen Koike <helen.koike@collabora.com> Applied to drm-misc-next. Regards, Helen > > Thanks > Helen > >> --- >> >> Changes in v2: >> - Added a comment, describing the issue and a way to reproduce it >> (Javier) >> >> --- >> drivers/gpu/drm/ci/test.yml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml >> index 7ffb620d7398..e64205286a27 100644 >> --- a/drivers/gpu/drm/ci/test.yml >> +++ b/drivers/gpu/drm/ci/test.yml >> @@ -119,7 +119,10 @@ msm:apq8016: >> DRIVER_NAME: msm >> BM_DTB: >> https://${PIPELINE_ARTIFACTS_BASE}/arm64/apq8016-sbc-usb-host.dtb >> GPU_VERSION: apq8016 >> - BM_CMDLINE: "ip=dhcp console=ttyMSM0,115200n8 >> $BM_KERNEL_EXTRA_ARGS root=/dev/nfs rw nfsrootdebug >> nfsroot=,tcp,nfsvers=4.2 init=/init $BM_KERNELARGS" >> + # disabling unused clocks congests with the MDSS runtime PM >> trying to >> + # disable those clocks and causes boot to fail. >> + # Reproducer: DRM_MSM=y, DRM_I2C_ADV7511=m >> + BM_KERNEL_EXTRA_ARGS: clk_ignore_unused >> RUNNER_TAG: google-freedreno-db410c >> script: >> - ./install/bare-metal/fastboot.sh
diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml index 7ffb620d7398..e64205286a27 100644 --- a/drivers/gpu/drm/ci/test.yml +++ b/drivers/gpu/drm/ci/test.yml @@ -119,7 +119,10 @@ msm:apq8016: DRIVER_NAME: msm BM_DTB: https://${PIPELINE_ARTIFACTS_BASE}/arm64/apq8016-sbc-usb-host.dtb GPU_VERSION: apq8016 - BM_CMDLINE: "ip=dhcp console=ttyMSM0,115200n8 $BM_KERNEL_EXTRA_ARGS root=/dev/nfs rw nfsrootdebug nfsroot=,tcp,nfsvers=4.2 init=/init $BM_KERNELARGS" + # disabling unused clocks congests with the MDSS runtime PM trying to + # disable those clocks and causes boot to fail. + # Reproducer: DRM_MSM=y, DRM_I2C_ADV7511=m + BM_KERNEL_EXTRA_ARGS: clk_ignore_unused RUNNER_TAG: google-freedreno-db410c script: - ./install/bare-metal/fastboot.sh
If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is built-in, the clk_disable_unused congests with the runtime PM handling of the DSI PHY for the clk_prepare_lock(). This causes apq8016 runner to fail without completing any jobs ([1]). Drop the BM_CMDLINE which duplicate the command line from the .baremetal-igt-arm64 clause and enforce the clk_ignore_unused kernelarg instead to make apq8016 runner work. [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/54990475 Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory") Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v2: - Added a comment, describing the issue and a way to reproduce it (Javier) --- drivers/gpu/drm/ci/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)