diff mbox series

staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch

Message ID 20240221095404.592464-1-sawara04.o@gmail.com (mailing list archive)
State New, archived
Headers show
Series staging: fbtft: Fix "space prohibited before that close parenthesis ')'" error reported by checkpatch | expand

Commit Message

小笠原 共志 Feb. 21, 2024, 9:54 a.m. UTC 
From: Kyoji Ogasawara <sawara04.o@gmail.com>

Since whitespace is prohibited before that close parenthesis ')' in a
conditional statements, remove it and fix checkpatch.pl error "space prohibited before that
close parenthesis ')'".

Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

小笠原 共志 Feb. 22, 2024, 1:38 p.m. UTC | #1 
> This breaks the build.  You could do a search for it.
>
> https://lore.kernel.org/all/?q=define_fbtft_write_reg

I understand. Thanks for letting me know.

2024年2月21日(水) 19:18 Dan Carpenter <dan.carpenter@linaro.org>:

> On Wed, Feb 21, 2024 at 06:54:04PM +0900, sawara04.o@gmail.com wrote:
> > From: Kyoji Ogasawara <sawara04.o@gmail.com>
> >
> > Since whitespace is prohibited before that close parenthesis ')' in a
> > conditional statements, remove it and fix checkpatch.pl error "space
> prohibited before that
> > close parenthesis ')'".
> >
> > Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
>
> This breaks the build.  You could do a search for it.
>
> https://lore.kernel.org/all/?q=define_fbtft_write_reg
>
> regards,
> dan carpenter
>
>
diff mbox series

Patch

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 3d422bc11641..02a16671f2a1 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@  out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {