| Message ID | 20240322083005.24269-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev: Select I/O-memory framebuffer ops for SBus | expand |
Thomas Zimmermann <tzimmermann@suse.de> writes: > Framebuffer I/O on the Sparc Sbus requires read/write helpers for > I/O memory. Select FB_IOMEM_FOPS accordingly. > > Reported-by: Nick Bowler <nbowler@draconx.ca> > Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/ > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations") > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Helge Deller <deller@gmx.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: <stable@vger.kernel.org> # v6.8+ > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 2024-03-22 06:43, Javier Martinez Canillas wrote: > Thomas Zimmermann <tzimmermann@suse.de> writes: > >> Framebuffer I/O on the Sparc Sbus requires read/write helpers for >> I/O memory. Select FB_IOMEM_FOPS accordingly. >> >> Reported-by: Nick Bowler <nbowler@draconx.ca> Applied on top of 6.8 and the build is successful. Thanks, Nick
On Fri, Mar 22, 2024 at 09:29:46AM +0100, Thomas Zimmermann wrote: > Framebuffer I/O on the Sparc Sbus requires read/write helpers for > I/O memory. Select FB_IOMEM_FOPS accordingly. > > Reported-by: Nick Bowler <nbowler@draconx.ca> > Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/ > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations") > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Helge Deller <deller@gmx.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: <stable@vger.kernel.org> # v6.8+ Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Merged into drm-misc-fixes. Am 22.03.24 um 09:29 schrieb Thomas Zimmermann: > Framebuffer I/O on the Sparc Sbus requires read/write helpers for > I/O memory. Select FB_IOMEM_FOPS accordingly. > > Reported-by: Nick Bowler <nbowler@draconx.ca> > Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/ > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations") > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Helge Deller <deller@gmx.de> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: <stable@vger.kernel.org> # v6.8+ > --- > drivers/video/fbdev/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index a61b8260b8f36..edced74f0eeaf 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -494,6 +494,7 @@ config FB_SBUS_HELPERS > select FB_CFB_COPYAREA > select FB_CFB_FILLRECT > select FB_CFB_IMAGEBLIT > + select FB_IOMEM_FOPS > > config FB_BW2 > bool "BWtwo support" > @@ -514,6 +515,7 @@ config FB_CG6 > depends on (FB = y) && (SPARC && FB_SBUS) > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > + select FB_IOMEM_FOPS > help > This is the frame buffer device driver for the CGsix (GX, TurboGX) > frame buffer. > @@ -523,6 +525,7 @@ config FB_FFB > depends on FB_SBUS && SPARC64 > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > + select FB_IOMEM_FOPS > help > This is the frame buffer device driver for the Creator, Creator3D, > and Elite3D graphics boards.
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index a61b8260b8f36..edced74f0eeaf 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -494,6 +494,7 @@ config FB_SBUS_HELPERS select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT + select FB_IOMEM_FOPS config FB_BW2 bool "BWtwo support" @@ -514,6 +515,7 @@ config FB_CG6 depends on (FB = y) && (SPARC && FB_SBUS) select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT + select FB_IOMEM_FOPS help This is the frame buffer device driver for the CGsix (GX, TurboGX) frame buffer. @@ -523,6 +525,7 @@ config FB_FFB depends on FB_SBUS && SPARC64 select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT + select FB_IOMEM_FOPS help This is the frame buffer device driver for the Creator, Creator3D, and Elite3D graphics boards.
Framebuffer I/O on the Sparc Sbus requires read/write helpers for I/O memory. Select FB_IOMEM_FOPS accordingly. Reported-by: Nick Bowler <nbowler@draconx.ca> Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/ Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Helge Deller <deller@gmx.de> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: <stable@vger.kernel.org> # v6.8+ --- drivers/video/fbdev/Kconfig | 3 +++ 1 file changed, 3 insertions(+)