| Message ID | 20240326-fd-fix-schema-v1-1-4475d6d6d633@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: fix several display-related schema warnings | expand |
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > index c0d6a4fdff97..40b077fb20aa 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > @@ -53,6 +53,16 @@ patternProperties: > compatible: > const: qcom,sm8150-dpu > > + "^displayport-controller@[0-9a-f]+$": > + type: object > + additionalProperties: true > + > + properties: > + compatible: > + items: > + - const: qcom,sm8150-dp > + - const: qcom,sm8350-dp This does not look right. sm8350 has its own mdss binding file. Best regards, Krzysztof
On Wed, 27 Mar 2024 at 10:45, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/03/2024 21:02, Dmitry Baryshkov wrote: > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > > index c0d6a4fdff97..40b077fb20aa 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > > @@ -53,6 +53,16 @@ patternProperties: > > compatible: > > const: qcom,sm8150-dpu > > > > + "^displayport-controller@[0-9a-f]+$": > > + type: object > > + additionalProperties: true > > + > > + properties: > > + compatible: > > + items: > > + - const: qcom,sm8150-dp > > + - const: qcom,sm8350-dp > > This does not look right. sm8350 has its own mdss binding file. So just a single entry here, even though SM8150 uses fallback compat string?
On 27/03/2024 09:52, Dmitry Baryshkov wrote: > On Wed, 27 Mar 2024 at 10:45, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 26/03/2024 21:02, Dmitry Baryshkov wrote: >>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml >>> index c0d6a4fdff97..40b077fb20aa 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml >>> @@ -53,6 +53,16 @@ patternProperties: >>> compatible: >>> const: qcom,sm8150-dpu >>> >>> + "^displayport-controller@[0-9a-f]+$": >>> + type: object >>> + additionalProperties: true >>> + >>> + properties: >>> + compatible: >>> + items: >>> + - const: qcom,sm8150-dp >>> + - const: qcom,sm8350-dp >> >> This does not look right. sm8350 has its own mdss binding file. > > So just a single entry here, even though SM8150 uses fallback compat string? Ah, wait, I misread, I thought it is enum. Best regards, Krzysztof
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > As Qualcomm SM8150 got support for the DisplayPort, add displayport@ > node as a valid child to the MDSS node. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 27/03/2024 11:11, Krzysztof Kozlowski wrote: > On 26/03/2024 21:02, Dmitry Baryshkov wrote: >> As Qualcomm SM8150 got support for the DisplayPort, add displayport@ >> node as a valid child to the MDSS node. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> If there is going to be resend, please switch to "contains" and only sm8150 compatible just like: https://lore.kernel.org/all/20240329-sm6350-dp-v2-2-e46dceb32ef5@fairphone.com/ (but no need to resend just for that) Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml index c0d6a4fdff97..40b077fb20aa 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml @@ -53,6 +53,16 @@ patternProperties: compatible: const: qcom,sm8150-dpu + "^displayport-controller@[0-9a-f]+$": + type: object + additionalProperties: true + + properties: + compatible: + items: + - const: qcom,sm8150-dp + - const: qcom,sm8350-dp + "^dsi@[0-9a-f]+$": type: object additionalProperties: true
As Qualcomm SM8150 got support for the DisplayPort, add displayport@ node as a valid child to the MDSS node. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)