| Message ID | 20240330203831.87003-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/sti: dvo: drop driver owner assignment | expand |
On 30/03/2024 21:38, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- It has been almost a month. Any comments? Anything is happening here? Best regards, Krzysztof
Hi Krzysztof, sorry for the delay. On Sat, Mar 30, 2024 at 09:38:28PM +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/sti/sti_dvo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index fd1df4ce3852..00502889c7f4 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match); > struct platform_driver sti_dvo_driver = { > .driver = { > .name = "sti-dvo", > - .owner = THIS_MODULE, > .of_match_table = dvo_of_match, > }, > .probe = sti_dvo_probe, > -- > 2.34.1 > Acked-by: Alain Volmat <alain.volmat@foss.st.com> Alain
On Sat, 30 Mar 2024 21:38:28 +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c index fd1df4ce3852..00502889c7f4 100644 --- a/drivers/gpu/drm/sti/sti_dvo.c +++ b/drivers/gpu/drm/sti/sti_dvo.c @@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match); struct platform_driver sti_dvo_driver = { .driver = { .name = "sti-dvo", - .owner = THIS_MODULE, .of_match_table = dvo_of_match, }, .probe = sti_dvo_probe,
Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpu/drm/sti/sti_dvo.c | 1 - 1 file changed, 1 deletion(-)