| Message ID | 20240330205722.93801-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/sti: dvo: drop driver owner assignment | expand |
Hi Krzysztof, thanks for your patch, sorry for the delay. On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > I forgot two drivers. > drivers/gpu/drm/sti/sti_hdmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > index 500936d5743c..b0d84440a87b 100644 > --- a/drivers/gpu/drm/sti/sti_hdmi.c > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) > struct platform_driver sti_hdmi_driver = { > .driver = { > .name = "sti-hdmi", > - .owner = THIS_MODULE, > .of_match_table = hdmi_of_match, > }, > .probe = sti_hdmi_probe, > -- > 2.34.1 > Acked-by: Alain Volmat <alain.volmat@foss.st.com> Alain
On 27/05/2024 16:47, Alain Volmat wrote: > Hi Krzysztof, > > thanks for your patch, sorry for the delay. > > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >> Core in platform_driver_register() already sets the .owner, so driver >> does not need to. Whatever is set here will be anyway overwritten by >> main driver calling platform_driver_register(). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> >> I forgot two drivers. >> drivers/gpu/drm/sti/sti_hdmi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c >> index 500936d5743c..b0d84440a87b 100644 >> --- a/drivers/gpu/drm/sti/sti_hdmi.c >> +++ b/drivers/gpu/drm/sti/sti_hdmi.c >> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) >> struct platform_driver sti_hdmi_driver = { >> .driver = { >> .name = "sti-hdmi", >> - .owner = THIS_MODULE, >> .of_match_table = hdmi_of_match, >> }, >> .probe = sti_hdmi_probe, >> -- >> 2.34.1 >> > > Acked-by: Alain Volmat <alain.volmat@foss.st.com> What does this ack mean? You are the maintainer, so what is supposed to happen now? If maintainer does not take patches, then the DRM STI looks orphaned. Best regards, Krzysztof
On 04/06/2024 15:18, Krzysztof Kozlowski wrote: > On 27/05/2024 16:47, Alain Volmat wrote: >> Hi Krzysztof, >> >> thanks for your patch, sorry for the delay. >> >> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >>> Core in platform_driver_register() already sets the .owner, so driver >>> does not need to. Whatever is set here will be anyway overwritten by >>> main driver calling platform_driver_register(). >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> >>> I forgot two drivers. >>> drivers/gpu/drm/sti/sti_hdmi.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c >>> index 500936d5743c..b0d84440a87b 100644 >>> --- a/drivers/gpu/drm/sti/sti_hdmi.c >>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c >>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) >>> struct platform_driver sti_hdmi_driver = { >>> .driver = { >>> .name = "sti-hdmi", >>> - .owner = THIS_MODULE, >>> .of_match_table = hdmi_of_match, >>> }, >>> .probe = sti_hdmi_probe, >>> -- >>> 2.34.1 >>> >> >> Acked-by: Alain Volmat <alain.volmat@foss.st.com> > > What does this ack mean? You are the maintainer, so what is supposed to > happen now? If maintainer does not take patches, then the DRM STI looks > orphaned. +Cc Neil, Dmitry, I pinged and pinged and wanted some sort of clarification here but one month passed and nothing was clarified. I could be understanding the DRM process wrong, but if no one picks up trivial cleanups for 1.5 months, then to me subsystem is orphaned. I will send respective MAINTAINERS update. Best regards, Krzysztof
On 05/07/2024 11:59, Krzysztof Kozlowski wrote: > On 04/06/2024 15:18, Krzysztof Kozlowski wrote: >> On 27/05/2024 16:47, Alain Volmat wrote: >>> Hi Krzysztof, >>> >>> thanks for your patch, sorry for the delay. >>> >>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >>>> Core in platform_driver_register() already sets the .owner, so driver >>>> does not need to. Whatever is set here will be anyway overwritten by >>>> main driver calling platform_driver_register(). >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> >>>> I forgot two drivers. >>>> drivers/gpu/drm/sti/sti_hdmi.c | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c >>>> index 500936d5743c..b0d84440a87b 100644 >>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c >>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c >>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) >>>> struct platform_driver sti_hdmi_driver = { >>>> .driver = { >>>> .name = "sti-hdmi", >>>> - .owner = THIS_MODULE, >>>> .of_match_table = hdmi_of_match, >>>> }, >>>> .probe = sti_hdmi_probe, >>>> -- >>>> 2.34.1 >>>> >>> >>> Acked-by: Alain Volmat <alain.volmat@foss.st.com> >> >> What does this ack mean? You are the maintainer, so what is supposed to >> happen now? If maintainer does not take patches, then the DRM STI looks >> orphaned. > > +Cc Neil, Dmitry, > > I pinged and pinged and wanted some sort of clarification here but one > month passed and nothing was clarified. > > I could be understanding the DRM process wrong, but if no one picks up > trivial cleanups for 1.5 months, then to me subsystem is orphaned. I > will send respective MAINTAINERS update. Let's do that, if Alain doesn't take his own patches that were reviewed then it should either be orphaned or moved to drm-misc. Neil > > Best regards, > Krzysztof >
On Fri, 5 Jul 2024 at 13:04, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 05/07/2024 11:59, Krzysztof Kozlowski wrote: > > On 04/06/2024 15:18, Krzysztof Kozlowski wrote: > >> On 27/05/2024 16:47, Alain Volmat wrote: > >>> Hi Krzysztof, > >>> > >>> thanks for your patch, sorry for the delay. > >>> > >>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: > >>>> Core in platform_driver_register() already sets the .owner, so driver > >>>> does not need to. Whatever is set here will be anyway overwritten by > >>>> main driver calling platform_driver_register(). > >>>> > >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>> --- > >>>> > >>>> I forgot two drivers. > >>>> drivers/gpu/drm/sti/sti_hdmi.c | 1 - > >>>> 1 file changed, 1 deletion(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > >>>> index 500936d5743c..b0d84440a87b 100644 > >>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c > >>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c > >>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) > >>>> struct platform_driver sti_hdmi_driver = { > >>>> .driver = { > >>>> .name = "sti-hdmi", > >>>> - .owner = THIS_MODULE, > >>>> .of_match_table = hdmi_of_match, > >>>> }, > >>>> .probe = sti_hdmi_probe, > >>>> -- > >>>> 2.34.1 > >>>> > >>> > >>> Acked-by: Alain Volmat <alain.volmat@foss.st.com> > >> > >> What does this ack mean? You are the maintainer, so what is supposed to > >> happen now? If maintainer does not take patches, then the DRM STI looks > >> orphaned. > > > > +Cc Neil, Dmitry, > > > > I pinged and pinged and wanted some sort of clarification here but one > > month passed and nothing was clarified. > > > > I could be understanding the DRM process wrong, but if no one picks up > > trivial cleanups for 1.5 months, then to me subsystem is orphaned. I > > will send respective MAINTAINERS update. > > Let's do that, if Alain doesn't take his own patches that were reviewed > then it should either be orphaned or moved to drm-misc. But it already a part of drm-misc as far as I can see: DRM DRIVERS FOR STI M: Alain Volmat <alain.volmat@foss.st.com> L: dri-devel@lists.freedesktop.org S: Maintained T: git https://gitlab.freedesktop.org/drm/misc/kernel.git F: Documentation/devicetree/bindings/display/st,stih4xx.txt F: drivers/gpu/drm/sti
On 05/07/2024 12:37, Dmitry Baryshkov wrote: >>>>> Acked-by: Alain Volmat <alain.volmat@foss.st.com> >>>> >>>> What does this ack mean? You are the maintainer, so what is supposed to >>>> happen now? If maintainer does not take patches, then the DRM STI looks >>>> orphaned. >>> >>> +Cc Neil, Dmitry, >>> >>> I pinged and pinged and wanted some sort of clarification here but one >>> month passed and nothing was clarified. >>> >>> I could be understanding the DRM process wrong, but if no one picks up >>> trivial cleanups for 1.5 months, then to me subsystem is orphaned. I >>> will send respective MAINTAINERS update. >> >> Let's do that, if Alain doesn't take his own patches that were reviewed >> then it should either be orphaned or moved to drm-misc. > > But it already a part of drm-misc as far as I can see: In such case who is going to pick up such patches? Best regards, Krzysztof
+Alain On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote: > On 27/05/2024 16:47, Alain Volmat wrote: > > Hi Krzysztof, > > > > thanks for your patch, sorry for the delay. > > > > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: > >> Core in platform_driver_register() already sets the .owner, so driver > >> does not need to. Whatever is set here will be anyway overwritten by > >> main driver calling platform_driver_register(). > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> > >> I forgot two drivers. > >> drivers/gpu/drm/sti/sti_hdmi.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > >> index 500936d5743c..b0d84440a87b 100644 > >> --- a/drivers/gpu/drm/sti/sti_hdmi.c > >> +++ b/drivers/gpu/drm/sti/sti_hdmi.c > >> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) > >> struct platform_driver sti_hdmi_driver = { > >> .driver = { > >> .name = "sti-hdmi", > >> - .owner = THIS_MODULE, > >> .of_match_table = hdmi_of_match, > >> }, > >> .probe = sti_hdmi_probe, > >> -- > >> 2.34.1 > >> > > > > Acked-by: Alain Volmat <alain.volmat@foss.st.com> > > What does this ack mean? You are the maintainer, so what is supposed to > happen now? If maintainer does not take patches, then the DRM STI looks > orphaned. The expectation would have been that Alain would have applied these patches. That being said, your reply here dropped him from the recipients list, so it's not surprising you didn't get any answer. Maxime
On 05/07/2024 13:14, Maxime Ripard wrote: > +Alain > > On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote: >> On 27/05/2024 16:47, Alain Volmat wrote: >>> Hi Krzysztof, >>> >>> thanks for your patch, sorry for the delay. >>> ... >>> >>> Acked-by: Alain Volmat <alain.volmat@foss.st.com> >> >> What does this ack mean? You are the maintainer, so what is supposed to >> happen now? If maintainer does not take patches, then the DRM STI looks >> orphaned. > > The expectation would have been that Alain would have applied these > patches. That being said, your reply here dropped him from the > recipients list, so it's not surprising you didn't get any answer. Uh, indeed. I don't know how this happened. I was replying to him, which is visible in "On 27/05 .... Alain Vormat wrote" header, but... weird. Alain, I apologize, it seems I am responsible for this mishap here. Best regards, Krzysztof
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 500936d5743c..b0d84440a87b 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev) struct platform_driver sti_hdmi_driver = { .driver = { .name = "sti-hdmi", - .owner = THIS_MODULE, .of_match_table = hdmi_of_match, }, .probe = sti_hdmi_probe,
Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- I forgot two drivers. drivers/gpu/drm/sti/sti_hdmi.c | 1 - 1 file changed, 1 deletion(-)