From patchwork Tue May 28 08:32:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerald Loacker X-Patchwork-Id: 13676306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8639C25B7E for ; Tue, 28 May 2024 08:33:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AC1B10E9C1; Tue, 28 May 2024 08:33:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=wolfvision.net header.i=@wolfvision.net header.b="p/ebaB0O"; dkim-atps=neutral Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2090.outbound.protection.outlook.com [40.107.21.90]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A9F210E2D6 for ; Tue, 28 May 2024 08:33:43 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7oTbd8vRm/2Lp1+VXUV3vmYHMRsw4S4KgV+Q29eOagQPbqf36hGfXNwd00maM6iO8+dyoNqt33ohDWDbK+Gv8/19j/QfEeJSXxwOGpkZanEzFdvhAQzi3G3hI/H3BnSpQI0O6Z2lENUIQou1y5COkut2afIeBLEXixAaOy7AJI6BV5nNaXbCuLnwIn1e6ACjHgcForGYwEol0JGWWp0LNB5jjygAcrmAuoSAaIJ1+mqp+KOHOCoyFUoGhpUjSLoD+/0FbiHgEfmUIjtUXGN8JAVk9zyLJvz6xJwOV+6feyQw/5gmdd8TunQlNt0gn7tes1eMkF3zXoR9Xv+lxVLHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EM9BM7NROHLDTPLPC3FQFnhfeVsAi/mFrMO7Uo9OCns=; b=BE0I5wk0WaUO5+ayvy0CEFibL+5oXyiIAA+vMSyU0BR1DjnVlqdGvBD9GsMMc9f6jU1b6ZOsvZEa0pz1tBQ+/Kctopn/kdGM9FciO0c+E0Y0hKFzvRpknvfStRYxykbBvoheq+6hqmLRmDjsWnvzuExIcrvvCgJDWa2h7EjioOMWfcaDWhiRx7HbWgGbvHjeert2q04E4Ei8FFjBo3KIXhtSapqpM2V0vMG0U9cKVqvZCH1RkrrBb2WRZ/USbp91c6oC4uuYGtlZMVd37FT4kqPff0uTsqgCy3gUrCdpVzHL0IMcfqriOC+d0FCyrF/d5kuzytXqVVt2+CuDwGdjqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wolfvision.net; dmarc=pass action=none header.from=wolfvision.net; dkim=pass header.d=wolfvision.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EM9BM7NROHLDTPLPC3FQFnhfeVsAi/mFrMO7Uo9OCns=; b=p/ebaB0O9QFOiNpWef91mUgENanmPqzFikHAA0ge3bAf76u048pgvTMiDOmuPtbp3YKosU2iC+w7JD/dPgQUnMY4eZz0DbYLIrZ1Xe2JXKPJEn+ahmD6hiV0pj9WoD/tLcAjnlmXOY05U6iKLTepsliuM8A9GxqiB5z7Ltxy9Kk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from VI1PR08MB4544.eurprd08.prod.outlook.com (2603:10a6:803:100::13) by PAVPR08MB9745.eurprd08.prod.outlook.com (2603:10a6:102:31c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Tue, 28 May 2024 08:33:38 +0000 Received: from VI1PR08MB4544.eurprd08.prod.outlook.com ([fe80::1f7f:ed46:6440:8b38]) by VI1PR08MB4544.eurprd08.prod.outlook.com ([fe80::1f7f:ed46:6440:8b38%4]) with mapi id 15.20.7611.025; Tue, 28 May 2024 08:33:38 +0000 From: Gerald Loacker Date: Tue, 28 May 2024 10:32:54 +0200 Subject: [PATCH RESEND 1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek_e3 panel Message-Id: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v1-1-f8351d4a8d4b@wolfvision.net> References: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v1-0-f8351d4a8d4b@wolfvision.net> In-Reply-To: <20240409-bugfix-jt240mhqs_hwt_ek_e3-timing-v1-0-f8351d4a8d4b@wolfvision.net> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gerald Loacker X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1716885217; l=1056; i=gerald.loacker@wolfvision.net; s=20230502; h=from:subject:message-id; bh=7iARjiADrdPjTmt5PCj4o6fziLM4cv3Jg7R3sLbVu1Q=; b=gguBnEo7zsQnMt/y4zCmkYV1p4hwvAy+6Yyepu+RJNpZLbMpGxtHXwx1xDrVSk54WpRDY96zZ FoaByc25mquCSXiliTt+nMTRxzfR0qz8Rl+7Mvn2gg2M5cQDi9Ona89 X-Developer-Key: i=gerald.loacker@wolfvision.net; a=ed25519; pk=UXhp+obGMUOjknszonesnb29P6a2Kk/K5eBuz62ggVE= X-ClientProxiedBy: VI1PR08CA0251.eurprd08.prod.outlook.com (2603:10a6:803:dc::24) To VI1PR08MB4544.eurprd08.prod.outlook.com (2603:10a6:803:100::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR08MB4544:EE_|PAVPR08MB9745:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a5c2713-c902-4e7e-a767-08dc7ef0df4f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|7416005|376005|366007|1800799015|52116005|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?gIxQ3CVpXyYccmxXuwgSiJgFW630/LJ?= =?utf-8?q?G1LmunJtVeK5aRoifj2Q8kXPoZoj+l9yes37j3+L5QxB9nnmaAZemzJdmLODyENaY?= =?utf-8?q?MQJ7Zkhkwyc7NDS0nDCDwT7xLNV9UQqednNOWi0Qy/WjCUm+m5lOcEVOBZWdMeC1F?= =?utf-8?q?NSJ5cV5c/OmvzmrxdIYWWupBprCWKi1h9azHNm6MbwB94VQlubwkNAS9O3mTVY/WZ?= =?utf-8?q?xwe+XusAJBkOeLJCBTxHlYodNIu08bA/SvwcyH842Imzdr2OQchMHuB0t2WZuklPW?= =?utf-8?q?ugTfBiuaz9ZlZVeLUzW0J9pcISmlGLDODpVqgWK7iJ1EOCT7Hh3B3s/ZGTnxCUZde?= =?utf-8?q?6gVHsMsnC17QkIvCkqEnCM2ffp2ucwnrBXKL/OfqCibniW3CF+u4B0NUXQsSnPw9A?= =?utf-8?q?6H0pJ4g0ZhTM6oUAR3z2YWR2emHC6QPgd9QZhfll79d8dF6wWYgQhHlENq9hhQLBu?= =?utf-8?q?giJ9LDK/tRPXe8YFVKaK5Nuxl+1EzaVuAYuo01yCX1IIG8IkNnhj8b89s8BZoJ11M?= =?utf-8?q?TaLkwPL9sKXz51ul2hB4N79Ke50isR3KGj3DygIAKcA7Ae/4Hin7nFodXvGD5dMae?= =?utf-8?q?0WpawkIdrfwv2c7GM8kDWouLnv4E9lISIQO7L+2m99P95ogz+ns+hv7JqoXhkAhsj?= =?utf-8?q?H1FnczAg5U/sXkuMEvFzduC/9ITWz2TzhDgtVqUxfbo/sQS1YxeYqTYS4UlCAKNA+?= =?utf-8?q?d+SVTEyt8pAWOX5jFSa33dsAVVvwiy8ZdCxS5PPzk2EjAhup+8UR06YKW+sF592+N?= =?utf-8?q?TTMyZjq1Z83sHPt2A+kt9JOlDQBSkdbjVLL77N5M6FpG87oG4/I/i1MDQyaxw0IT1?= =?utf-8?q?2R0eg4yr7w1pV7tJVZYw1ah1uOuWCcc5fa4B+7n6pZXBjm/scteNgwkK78PTzegXY?= =?utf-8?q?qUUMVLVTNfTe8besBzUzTzRYG1sEXEqLk0iMH/TJfGpxUq07nHDmUK9Op09PQDNPC?= =?utf-8?q?pusDfgU6oiIPDfxYelpTnvTMx4dIufWKDuzMBJv3lZQWYsE8rglxtvI7zJXqM5u/L?= =?utf-8?q?2uhHWiicV+heW1mwuYHizp/d049K1qqA/VXzGDO3KyRSxgPxZSg1GcuJu7l2XMUne?= =?utf-8?q?cJVdJiG/9I4f12Wb1dw3ECtwouj4j2ZTj1+BjTxZB3Gk7fC3NO8TJfpfGjSoZ2eS+?= =?utf-8?q?sUXNPia6nOoR4z1MYKCIm0hiLDARCBr6woC6L6wNKpm9wKuCRKD51lgGIEuVT4Z5a?= =?utf-8?q?708pVjOtKVledNskAIkFDrpEMAVmsM6fIKCsqlyPsITs1pkOlm5IQumVUSA4NodxZ?= =?utf-8?q?TRnT/DzS534qQQJoWXGzxYeSSBcrDayB3BQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB4544.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7416005)(376005)(366007)(1800799015)(52116005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?d0HTyMm4yM5vLMVpHvu3YHSwWpa+?= =?utf-8?q?nzuJvuNabYV+0t677HGVC2lrCeZ2b6mb6azW+Z9MP60EMZj4hFuO4TXE/cK9AGezE?= =?utf-8?q?QkinEaMBWRnjTYVgFMQl0IwUBPwCKOViM9AUX2cp/UzxlvF+jAA18UB/sJL7Kvhm6?= =?utf-8?q?U6nP2e+NIxg7+5By3BtPg5kezKR+D/6HcrcPYVMKH4/oyK53wcAPN/Rs7XpUS5NF1?= =?utf-8?q?L+jb66Slb+3AIF39cgG0XpZJf7QDBfZYeMIncpWtkA4bvDYH43nhjxWz07apu7pqM?= =?utf-8?q?D2n1SWmhwh6qFQnW9cn8U5nl1KJW9fRJGAZVV121oDA6YmOIDt5rSOMoBEIae7w7j?= =?utf-8?q?h15fL7oFUt8235rnPcErqj4DweIw7Zfb7amUm3IJ/DKDEx3mcAVlL571GWmr2S4WI?= =?utf-8?q?JMmNmsBVTWHxkZe8GTZB8qWf4PXsG3K+FePPxfs65TtIKBeYCHaAJpzumEWo7wfwD?= =?utf-8?q?xG7V5hLw/0aNfNicq6aqYIL90qAaa0h3Ad10sNKzDLikLUJBEuyh3W9U6IcxRxnXN?= =?utf-8?q?ZqdlRVlKW47Jn2LRYiOnBvk7pJBLwyEDk4EdQIADh7BgJW0rNH1zUauaCjVDPM7xl?= =?utf-8?q?LzW4+A4HjEmQo5PqESx065Xz2j2SG0iOcK7Vn1FomtUPwFsNr038qIsnVesFgxUHs?= =?utf-8?q?s3cm/LXVPiC2MTq9mCm2LsrKW2fvpnhwHcxh/YLDG/xcF+w1M6C1pgPhQlriLUHv8?= =?utf-8?q?fKwI7bVnyf7EB2ey5+m9nUngzGFMRqYto24Juyr4759l6bV9fGxefRPhj6LGMQJXA?= =?utf-8?q?9RFkW4ls0476sOYp4knILx06l8OOs3vEWZQUmPAEEjRj+po2RkilDUipFXFFcZ5JY?= =?utf-8?q?aKMF4gQfy1pUuXdcUf8fQEZg/A3hunrzHJ5zDq+S+goxCrL77BvGjqn/ZoC9yk2TD?= =?utf-8?q?HYUfTGtu9iCZQS+NyCz4Ou6ZuKFKgYqAkoOJTeZkn2zuHwDtR0wqkpKQV4/LmqAvf?= =?utf-8?q?bvYEg8fT8gbEtKxAMyXLor+7B1GmVX8AZmWDUOV0ZuvNeyWoABvLDVfnyYeW3+5Mz?= =?utf-8?q?RKpohrkOWk79sTHGhq5LgWU04OdVhk7JGW/0xWyokFUXQGjfVYvK70uhN2NNwH0Cu?= =?utf-8?q?eF4oMsCXIBeuC6iuoOl7NICBaIT3Zw23QuY20LoU5wb5/L6tcCEplVV7xy31YGmba?= =?utf-8?q?YK9oBDkp6Tv5mP4yeljNHofJnxbH1YJOHGM5L0r/hH5HlVoGubd2C99MMtZW9NzyU?= =?utf-8?q?Ax6Wu6B/nY4hdz8FU+pVt3I9eRxM8DyVmv3x0NhyTmBKN0yhdAysH3XnXaq8y/PGO?= =?utf-8?q?L3ifYX4jU/k9aEfVrquF1qBHCjhFUSeh1W7Os4/OOG/gB3DtSfrhdGna5aisMXy8f?= =?utf-8?q?uxa9PEZrpqaAzBrhh+5nUHKbdz4UB9yD6IAsbFn/BwgeR8VjYK18Oyp/EMR2vQ+eo?= =?utf-8?q?1chtrF4nQ4n2OJubSthBBbJO9Sm9jgnVLdTCEcOQx2ELLq8DQJ615dOp2aCscx15Z?= =?utf-8?q?c4knHNB1nuLPSh1RvKH+QpRlq3iTiUAYC/XtvcFGXs5xgQAgTyOxYiW2la25yW8f/?= =?utf-8?q?1PLIRSMulH5mA8nLap3vJQZga5EXJTS2OQ=3D=3D?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5c2713-c902-4e7e-a767-08dc7ef0df4f X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB4544.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 08:33:38.4333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4qv2RQ4NpB6JiljnYV2YkiX6qzC/zA+pb5a+qvmyY2jrFEtr2A6q+ZcxuhNwXhVHFXx7V3At5QBCAZOOT+OKT010hudH6tJMRtWvh4KsdM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9745 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Flickering was observed when using partial mode. Moving the vsync to the same position as used by the default sitronix-st7789v timing resolves this issue. Signed-off-by: Gerald Loacker Acked-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 88e80fe98112..32e5c0348038 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -286,9 +286,9 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = { .hsync_end = 240 + 28 + 10, .htotal = 240 + 28 + 10 + 10, .vdisplay = 280, - .vsync_start = 280 + 8, - .vsync_end = 280 + 8 + 4, - .vtotal = 280 + 8 + 4 + 4, + .vsync_start = 280 + 48, + .vsync_end = 280 + 48 + 4, + .vtotal = 280 + 48 + 4 + 4, .width_mm = 43, .height_mm = 37, .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,