| Message ID | 20240417-component-dummy-v1-1-b0854665c760@herrie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | component: Support masters with no subcomponents | expand |
Hi Herman, thanks for your patch! Do you actually have this working on real hardware? I never submitted this patch because I could not get the hardware working. I was hoping for smarter people (Dmitry Baryshkov...) to step in and help out to actually make it work before submitting patches. Yours, Linus Walleij
On Wed, Apr 17, 2024 at 01:39:16PM +0200, Linus Walleij wrote: > Hi Herman, > > thanks for your patch! > > Do you actually have this working on real hardware? I never > submitted this patch because I could not get the hardware > working. > > I was hoping for smarter people (Dmitry Baryshkov...) to step > in and help out to actually make it work before submitting > patches. I have LVDS working on apq8064, but it requires fixes in the MMCC driver, in the MDP4 driver and in DTS. I need to clean up them first before even attempting to send them out. Also a PWM/LPG driver would help as otherwise the power supply is quick to be overloaded by the backlight. Nevertheless, LVDS/LCDC-only MDP4 is a valid usecase, but it has to be handled in the driver rather than in the core lib.
On Thu, Apr 18, 2024 at 1:36 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > I have LVDS working on apq8064, but it requires fixes in the MMCC > driver, in the MDP4 driver and in DTS. I need to clean up them first > before even attempting to send them out. Also a PWM/LPG driver would > help as otherwise the power supply is quick to be overloaded by the > backlight. Thanks then I bet the prototype 8060 MMCC driver needs similar fixes before it will work as well, so we should work to merge this, then look at 8060 support after that. Yours, Linus Walleij
On Fri, Apr 19, 2024 at 10:22:19AM +0200, Linus Walleij wrote: > On Thu, Apr 18, 2024 at 1:36 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > I have LVDS working on apq8064, but it requires fixes in the MMCC > > driver, in the MDP4 driver and in DTS. I need to clean up them first > > before even attempting to send them out. Also a PWM/LPG driver would > > help as otherwise the power supply is quick to be overloaded by the > > backlight. > > Thanks then I bet the prototype 8060 MMCC driver needs similar fixes > before it will work as well, so we should work to merge this, then look at > 8060 support after that. Once I have time to cleanup them, I'll post 8064-related fixes.
diff --git a/drivers/base/component.c b/drivers/base/component.c index 741497324d78..bb79e7a77bb0 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -497,6 +497,10 @@ static void free_aggregate_device(struct aggregate_device *adev) kfree(adev); } +static struct component_match dummy_match = { + .num = 0, +}; + /** * component_master_add_with_match - register an aggregate driver * @parent: parent device of the aggregate driver @@ -516,6 +520,9 @@ int component_master_add_with_match(struct device *parent, struct aggregate_device *adev; int ret; + if (!match) + match = &dummy_match; + /* Reallocate the match array for its true size */ ret = component_match_realloc(match, match->num); if (ret)