| Message ID | 20240422191903.255642-4-sui.jingfeng@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: Allow using fwnode API to get the next bridge | expand |
On Tue, Apr 23, 2024 at 03:18:57AM +0800, Sui Jingfeng wrote: > Otherwise when compiled as module, this driver will not be probed on > non-DT environment. This is a fundamential step to make this driver > truely OF-independent. > > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> > --- > drivers/gpu/drm/bridge/simple-bridge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c > index 3b09bdd5ad4d..6be271d1394b 100644 > --- a/drivers/gpu/drm/bridge/simple-bridge.c > +++ b/drivers/gpu/drm/bridge/simple-bridge.c > @@ -308,3 +308,4 @@ module_platform_driver(simple_bridge_driver); > MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>"); > MODULE_DESCRIPTION("Simple DRM bridge driver"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:simple-bridge"); I think it would be better to use MODULE_DEVICE_TABLE(platform, simple_bridge_platform)id_table). Note, there is no such thing as generic 'simple_bridge'. I'd expect platform device to have a device-specific name which can be matched by the driver. This requires a platform_device_id table. > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c index 3b09bdd5ad4d..6be271d1394b 100644 --- a/drivers/gpu/drm/bridge/simple-bridge.c +++ b/drivers/gpu/drm/bridge/simple-bridge.c @@ -308,3 +308,4 @@ module_platform_driver(simple_bridge_driver); MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>"); MODULE_DESCRIPTION("Simple DRM bridge driver"); MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:simple-bridge");
Otherwise when compiled as module, this driver will not be probed on non-DT environment. This is a fundamential step to make this driver truely OF-independent. Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> --- drivers/gpu/drm/bridge/simple-bridge.c | 1 + 1 file changed, 1 insertion(+)