| Message ID | 20240509064336.9803-2-lvzhaoxiong@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 | expand |
Hi, On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the post_gpio_reset_on_delay_ms is set to 100. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ > 1 file changed, 8 insertions(+) You silently ignored pretty much all of the feedback from the previous version [1], so I'm not planning to review this version. [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com
hi Doug Sorry, This patch was accidentally sent when sending other patches. Please ignore this patch. > Also: other than the main power supply, there is no difference between > this and the ili2901. If you actually do have a main power supply, > then you probably don't need a new table. You probably don't even need > your own compatible string and in the device tree you could just > specify: > compatible = "ilitek,ili2900, "ilitek,ili2901"; > ...which says "I actually have an ILI 2900, but if you don't have any > special driver for the ILI 2900 it's likely that the driver for the > ILI 2901 will work because the hardware is almost the same." In addition, in the previous patch, we have made modifications based on your suggestions. "ilitek ili2900" and "ilitek ili2901" use the same driver. Upstream may not be needed in the future. Thank you for your previous suggestions. [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com On Thu, May 9, 2024 at 10:35 PM Doug Anderson <dianders@google.com> wrote: > > Hi, > > On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > > > ILI2900 requires reset to pull down time greater than 10ms, > > so the configuration post_power_delay_ms is 10, and the chipset > > initial time is required to be greater than 100ms, > > so the post_gpio_reset_on_delay_ms is set to 100. > > > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > --- > > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > You silently ignored pretty much all of the feedback from the previous > version [1], so I'm not planning to review this version. > > [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com
diff --git a/drivers/hid/i2c-hid/i2c-hid-of-elan.c b/drivers/hid/i2c-hid/i2c-hid-of-elan.c index 5b91fb106cfc..3073620b2dec 100644 --- a/drivers/hid/i2c-hid/i2c-hid-of-elan.c +++ b/drivers/hid/i2c-hid/i2c-hid-of-elan.c @@ -137,10 +137,18 @@ static const struct elan_i2c_hid_chip_data ilitek_ili2901_chip_data = { .main_supply_name = "vcc33", }; +static const struct elan_i2c_hid_chip_data ilitek_ili2900_chip_data = { + .post_power_delay_ms = 10, + .post_gpio_reset_on_delay_ms = 100, + .hid_descriptor_address = 0x0001, + .main_supply_name = NULL, +}; + static const struct of_device_id elan_i2c_hid_of_match[] = { { .compatible = "elan,ekth6915", .data = &elan_ekth6915_chip_data }, { .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_chip_data }, { .compatible = "ilitek,ili2901", .data = &ilitek_ili2901_chip_data }, + { .compatible = "ilitek,ili2900", .data = &ilitek_ili2900_chip_data }, { } }; MODULE_DEVICE_TABLE(of, elan_i2c_hid_of_match);