| Message ID | 20240510-dsi-panels-upd-api-v1-4-317c78a0dcc8@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mipi-dsi: simplify MIPI DSI init/cleanup even more | expand |
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Remove conditional code and use mipi_dsi_dcs_nop_multi() wrapper to > simplify driver code. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index ade8bf7491ee..0691a27a0daa 100644 --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c @@ -224,21 +224,14 @@ static const struct drm_display_mode innolux_p097pfg_mode = { static void innolux_panel_write_multi(struct mipi_dsi_multi_context *ctx, const void *payload, size_t size) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - mipi_dsi_generic_write_multi(ctx, payload, size); - if (ctx->accum_err) - return; /* * Included by random guessing, because without this * (or at least, some delay), the panel sometimes * didn't appear to pick up the command sequence. */ - ctx->accum_err = mipi_dsi_dcs_nop(ctx->dsi); - if (ctx->accum_err) - dev_err(dev, "failed to send DCS nop: %d\n", ctx->accum_err); + mipi_dsi_dcs_nop_multi(ctx); } #define innolux_panel_init_cmd_multi(ctx, seq...) \
Remove conditional code and use mipi_dsi_dcs_nop_multi() wrapper to simplify driver code. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)