| Message ID | 20240511193055.1686149-2-a-bhatia1@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tidss: Add OLDI bridge support | expand |
Hi Aradhya, Thank you for the patch. On Sun, May 12, 2024 at 01:00:52AM +0530, Aradhya Bhatia wrote: > Reduce tab size from 8 spaces to 4 spaces to make the bindings > consistent, and easy to expand. > > Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/display/ti/ti,am65x-dss.yaml | 54 +++++++++---------- > 1 file changed, 27 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index 55e3e490d0e6..399d68986326 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -142,32 +142,32 @@ examples: > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > dss: dss@4a00000 { > - compatible = "ti,am65x-dss"; > - reg = <0x04a00000 0x1000>, /* common */ > - <0x04a02000 0x1000>, /* vidl1 */ > - <0x04a06000 0x1000>, /* vid */ > - <0x04a07000 0x1000>, /* ovr1 */ > - <0x04a08000 0x1000>, /* ovr2 */ > - <0x04a0a000 0x1000>, /* vp1 */ > - <0x04a0b000 0x1000>, /* vp2 */ > - <0x04a01000 0x1000>; /* common1 */ > - reg-names = "common", "vidl1", "vid", > - "ovr1", "ovr2", "vp1", "vp2", "common1"; > - ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; > - power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; > - clocks = <&k3_clks 67 1>, > - <&k3_clks 216 1>, > - <&k3_clks 67 2>; > - clock-names = "fck", "vp1", "vp2"; > - interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - port@0 { > - reg = <0>; > - oldi_out0: endpoint { > - remote-endpoint = <&lcd_in0>; > - }; > - }; > + compatible = "ti,am65x-dss"; > + reg = <0x04a00000 0x1000>, /* common */ > + <0x04a02000 0x1000>, /* vidl1 */ > + <0x04a06000 0x1000>, /* vid */ > + <0x04a07000 0x1000>, /* ovr1 */ > + <0x04a08000 0x1000>, /* ovr2 */ > + <0x04a0a000 0x1000>, /* vp1 */ > + <0x04a0b000 0x1000>, /* vp2 */ > + <0x04a01000 0x1000>; /* common1 */ > + reg-names = "common", "vidl1", "vid", > + "ovr1", "ovr2", "vp1", "vp2", "common1"; > + ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; > + power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 67 1>, > + <&k3_clks 216 1>, > + <&k3_clks 67 2>; > + clock-names = "fck", "vp1", "vp2"; > + interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + oldi_out0: endpoint { > + remote-endpoint = <&lcd_in0>; > + }; > }; > + }; > };
On Sun, May 12, 2024 at 01:00:52AM +0530, Aradhya Bhatia wrote: > Reduce tab size from 8 spaces to 4 spaces to make the bindings > consistent, and easy to expand. "Re-indent the example" would be more specific than "minor cleanups" in the subject. Otherwise, Acked-by: Rob Herring (Arm) <robh@kernel.org> > > Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> > --- > .../bindings/display/ti/ti,am65x-dss.yaml | 54 +++++++++---------- > 1 file changed, 27 insertions(+), 27 deletions(-)
On 14/05/24 00:49, Rob Herring wrote: > On Sun, May 12, 2024 at 01:00:52AM +0530, Aradhya Bhatia wrote: >> Reduce tab size from 8 spaces to 4 spaces to make the bindings >> consistent, and easy to expand. > > "Re-indent the example" would be more specific than "minor cleanups" in > the subject. That would be better. Will reword this in v2. Thank you! Regards Aradhya > > Otherwise, > > Acked-by: Rob Herring (Arm) <robh@kernel.org> > >> >> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> >> --- >> .../bindings/display/ti/ti,am65x-dss.yaml | 54 +++++++++---------- >> 1 file changed, 27 insertions(+), 27 deletions(-) >
On 11/05/2024 22:30, Aradhya Bhatia wrote: > Reduce tab size from 8 spaces to 4 spaces to make the bindings > consistent, and easy to expand. > > Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> > --- > .../bindings/display/ti/ti,am65x-dss.yaml | 54 +++++++++---------- > 1 file changed, 27 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index 55e3e490d0e6..399d68986326 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -142,32 +142,32 @@ examples: > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > dss: dss@4a00000 { > - compatible = "ti,am65x-dss"; > - reg = <0x04a00000 0x1000>, /* common */ > - <0x04a02000 0x1000>, /* vidl1 */ > - <0x04a06000 0x1000>, /* vid */ > - <0x04a07000 0x1000>, /* ovr1 */ > - <0x04a08000 0x1000>, /* ovr2 */ > - <0x04a0a000 0x1000>, /* vp1 */ > - <0x04a0b000 0x1000>, /* vp2 */ > - <0x04a01000 0x1000>; /* common1 */ > - reg-names = "common", "vidl1", "vid", > - "ovr1", "ovr2", "vp1", "vp2", "common1"; > - ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; > - power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; > - clocks = <&k3_clks 67 1>, > - <&k3_clks 216 1>, > - <&k3_clks 67 2>; > - clock-names = "fck", "vp1", "vp2"; > - interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - port@0 { > - reg = <0>; > - oldi_out0: endpoint { > - remote-endpoint = <&lcd_in0>; > - }; > - }; > + compatible = "ti,am65x-dss"; > + reg = <0x04a00000 0x1000>, /* common */ > + <0x04a02000 0x1000>, /* vidl1 */ > + <0x04a06000 0x1000>, /* vid */ > + <0x04a07000 0x1000>, /* ovr1 */ > + <0x04a08000 0x1000>, /* ovr2 */ > + <0x04a0a000 0x1000>, /* vp1 */ > + <0x04a0b000 0x1000>, /* vp2 */ > + <0x04a01000 0x1000>; /* common1 */ > + reg-names = "common", "vidl1", "vid", > + "ovr1", "ovr2", "vp1", "vp2", "common1"; > + ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; > + power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 67 1>, > + <&k3_clks 216 1>, > + <&k3_clks 67 2>; > + clock-names = "fck", "vp1", "vp2"; > + interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + oldi_out0: endpoint { > + remote-endpoint = <&lcd_in0>; > + }; > }; > + }; > }; Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index 55e3e490d0e6..399d68986326 100644 --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml @@ -142,32 +142,32 @@ examples: #include <dt-bindings/soc/ti,sci_pm_domain.h> dss: dss@4a00000 { - compatible = "ti,am65x-dss"; - reg = <0x04a00000 0x1000>, /* common */ - <0x04a02000 0x1000>, /* vidl1 */ - <0x04a06000 0x1000>, /* vid */ - <0x04a07000 0x1000>, /* ovr1 */ - <0x04a08000 0x1000>, /* ovr2 */ - <0x04a0a000 0x1000>, /* vp1 */ - <0x04a0b000 0x1000>, /* vp2 */ - <0x04a01000 0x1000>; /* common1 */ - reg-names = "common", "vidl1", "vid", - "ovr1", "ovr2", "vp1", "vp2", "common1"; - ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; - power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; - clocks = <&k3_clks 67 1>, - <&k3_clks 216 1>, - <&k3_clks 67 2>; - clock-names = "fck", "vp1", "vp2"; - interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; - ports { - #address-cells = <1>; - #size-cells = <0>; - port@0 { - reg = <0>; - oldi_out0: endpoint { - remote-endpoint = <&lcd_in0>; - }; - }; + compatible = "ti,am65x-dss"; + reg = <0x04a00000 0x1000>, /* common */ + <0x04a02000 0x1000>, /* vidl1 */ + <0x04a06000 0x1000>, /* vid */ + <0x04a07000 0x1000>, /* ovr1 */ + <0x04a08000 0x1000>, /* ovr2 */ + <0x04a0a000 0x1000>, /* vp1 */ + <0x04a0b000 0x1000>, /* vp2 */ + <0x04a01000 0x1000>; /* common1 */ + reg-names = "common", "vidl1", "vid", + "ovr1", "ovr2", "vp1", "vp2", "common1"; + ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; + power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 67 1>, + <&k3_clks 216 1>, + <&k3_clks 67 2>; + clock-names = "fck", "vp1", "vp2"; + interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + oldi_out0: endpoint { + remote-endpoint = <&lcd_in0>; + }; }; + }; };
Reduce tab size from 8 spaces to 4 spaces to make the bindings consistent, and easy to expand. Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> --- .../bindings/display/ti/ti,am65x-dss.yaml | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-)