diff mbox series

nouveau/uconn: drop WARN_ON and pointless ret setting.

Message ID 20240528064730.9907-1-airlied@gmail.com (mailing list archive)
State New, archived
Headers show
Series nouveau/uconn: drop WARN_ON and pointless ret setting. | expand

Commit Message

Dave Airlie May 28, 2024, 6:47 a.m. UTC 
From: Dave Airlie <airlied@redhat.com>

With GSP on my laptop I get an 0xff connector type, it appears
this is normal behaviour and we should ignore that connector.

Now we don't handle that all properly, but anywhere I try to
ignore it at that point causes driver load to fail, so let's
not do that, and just drop the warn and ret setting (which gets
set to 0 a few lines later).

Cc: stable@vger.kernel.org
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
index 2dab6612c4fc..5f460e3d1bb5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
@@ -211,8 +211,6 @@  nvkm_uconn_new(const struct nvkm_oclass *oclass, void *argv, u32 argc, struct nv
 		case DCB_CONNECTOR_HDMI_1   :
 		case DCB_CONNECTOR_HDMI_C   : args->v0.type = NVIF_CONN_V0_HDMI; break;
 		default:
-			WARN_ON(1);
-			ret = -EINVAL;
 			break;
 		}