diff mbox series

[1/2] drm/vkms: Fix misalignment in comment block

Message ID 20240528131026.214773-2-brunolevilevi@usp.br (mailing list archive)
State New, archived
Headers show
Series Fix alignment in comment blocks | expand

Commit Message

Bruno Rocha Levi May 28, 2024, 1:08 p.m. UTC
From: Bruno Rocha Levi <brunolevilevi@gmail.com>

This change fixes a warning from checkpatch, it improves readability of a
comment that was previously misaligned, by ensuring the trailing */ is on
the same line as the opening /*.

Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
---
 drivers/gpu/drm/vkms/vkms_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Louis Chauvet May 28, 2024, 2:38 p.m. UTC | #1
Le 28/05/24 - 10:08, Bruno Rocha Levi a écrit :
> From: Bruno Rocha Levi <brunolevilevi@gmail.com>
> 
> This change fixes a warning from checkpatch, it improves readability of a
> comment that was previously misaligned, by ensuring the trailing */ is on
> the same line as the opening /*.

Hi,

Do you mean same column?

Maybe in the same patch, also add the missing first empty line in the 
comment [1]:

	/*
	 * FIXME: [...]
	 */

https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting

Thanks,
Louis Chauvet
 
> Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index dd0af086e..e8612759a 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -166,7 +166,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
>  	dev->mode_config.cursor_height = 512;
>  	/* FIXME: There's a confusion between bpp and depth between this and
>  	 * fbdev helpers. We have to go with 0, meaning "pick the default",
> -	 * which ix XRGB8888 in all cases. */
> +	 * which ix XRGB8888 in all cases.
> +	 */
>  	dev->mode_config.preferred_depth = 0;
>  	dev->mode_config.helper_private = &vkms_mode_config_helpers;
>  
> -- 
> 2.45.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index dd0af086e..e8612759a 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -166,7 +166,8 @@  static int vkms_modeset_init(struct vkms_device *vkmsdev)
 	dev->mode_config.cursor_height = 512;
 	/* FIXME: There's a confusion between bpp and depth between this and
 	 * fbdev helpers. We have to go with 0, meaning "pick the default",
-	 * which ix XRGB8888 in all cases. */
+	 * which ix XRGB8888 in all cases.
+	 */
 	dev->mode_config.preferred_depth = 0;
 	dev->mode_config.helper_private = &vkms_mode_config_helpers;