| Message ID | 20240530082318.40516-3-ryan@testtoast.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add WL-355608-A8 panel | expand |
On Thu, May 30, 2024 at 08:22:22PM +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a > number of handheld gaming devices made by Anbernic. > By consensus a > vendor prefix is not provided as the panel OEM is unknown. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + spi_lcd: spi { The "spi_lcd" label is not used and can be dropped.
On Thu, May 30, 2024 at 08:22:22PM +1200, Ryan Walklin wrote: > + port { > + endpoint { ^ You accidentally added a tab here: /stuff/linux/.git/worktrees/linux-dt/rebase-apply/patch:71: space before tab in indent. endpoint { warning: 1 line adds whitespace errors.
On Fri, 31 May 2024, at 4:03 AM, Conor Dooley wrote: > You accidentally added a tab here: > endpoint { Apologies, will fix along with the other redundant label for v3. Thanks for the review! Ryan
diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml new file mode 100644 index 0000000000000..05039a6db4bc8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel + +maintainers: + - Ryan Walklin <ryan@testtoast.com> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + const: wl-355608-a8 + + reg: + maxItems: 1 + + spi-3wire: true + +required: + - compatible + - reg + - port + - power-supply + - reset-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi_lcd: spi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "wl-355608-a8"; + reg = <0>; + + spi-3wire; + spi-max-frequency = <3125000>; + + reset-gpios = <&pio 8 14 GPIO_ACTIVE_LOW>; // PI14 + + backlight = <&backlight>; + power-supply = <®_lcd>; + + port { + endpoint { + remote-endpoint = <&tcon_lcd0_out_lcd>; + }; + }; + }; + };
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a number of handheld gaming devices made by Anbernic. By consensus a vendor prefix is not provided as the panel OEM is unknown. Add a device tree binding for the panel. Signed-off-by: Ryan Walklin <ryan@testtoast.com> --- Changelog v1..v2: - Correct compatible string and filename - Note #dri-devel discussion regarding vendor prefix - Remove unnecessary node names, spi-gpio compatible string and GPIOs from example --- .../bindings/display/panel/wl-355608-a8.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml