From patchwork Fri May 31 16:56:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13681954 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B5B7C25B75 for ; Fri, 31 May 2024 17:09:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2D9510E136; Fri, 31 May 2024 17:09:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Hhb9nq7v"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B4BD10E3BC for ; Fri, 31 May 2024 17:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717175333; x=1748711333; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dlLwge4maMD5cCoCfHiqrG474Js9Ny8k6wcSKnYkycU=; b=Hhb9nq7v4j5lryuMRfNcCl1dv22oZJPaw1RCqCSYZ/2oYnYLinuFSrHQ GI8D6Z2q78KB6J5rPv3sBWhGFtrTt0F7nMAALttIcyHpojhfvwhm5oxOy 017ywil9zhSLHjUf+tYc/JZeRoGqfT9azcN9WFYdDkUtJeSovh1IpV+EB v0822qlqT3qpiyzihx857QCnUAs1aFc4bSCanWZdbTntkU/bqBQTtc2B8 lN3FYJ5aj6tCPUhGc7JINMNFt+iKmU7HkusTxz4m+9psLjARbMDTIa770 HKejVGGniiC7PjgSmdId2j+mKIqb+Dbi+u28AD9qABWkuowOtAOf0b0XO Q==; X-CSE-ConnectionGUID: Mi7R0i+ZT+yN6DpNJNZ4Gg== X-CSE-MsgGUID: 9kruRv5HTdCNEe5iuhnP+Q== X-IronPort-AV: E=McAfee;i="6600,9927,11089"; a="25131909" X-IronPort-AV: E=Sophos;i="6.08,204,1712646000"; d="scan'208";a="25131909" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 10:08:51 -0700 X-CSE-ConnectionGUID: ruC/MblIT8OM1eyfSLXHdQ== X-CSE-MsgGUID: qMFVlju+RR2+imotfPv6Yg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,204,1712646000"; d="scan'208";a="36147846" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa007.fm.intel.com with ESMTP; 31 May 2024 10:08:47 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9B4A2650; Fri, 31 May 2024 20:08:46 +0300 (EEST) From: Andy Shevchenko To: Jonathan Cameron , Andy Shevchenko , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= , Lee Jones , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Pavel Machek , Daniel Thompson , Jingoo Han , Helge Deller , Johan Hovold Subject: [PATCH v1 3/4] leds: lm3533: Remove the driver Date: Fri, 31 May 2024 19:56:15 +0300 Message-ID: <20240531170844.1595468-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240531170844.1595468-1-andriy.shevchenko@linux.intel.com> References: <20240531170844.1595468-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver has no in kernel users and requires a board file to be instantiated. Remove basically a dead code. If ever needed, it can be reinstantiated and converted to one that uses firmware node interfaces. Signed-off-by: Andy Shevchenko --- drivers/leds/Kconfig | 13 - drivers/leds/Makefile | 1 - drivers/leds/leds-lm3533.c | 755 ------------------------------------- 3 files changed, 769 deletions(-) delete mode 100644 drivers/leds/leds-lm3533.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 05e6af88b88c..4cdc3a687421 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -229,19 +229,6 @@ config LEDS_LM3532 controlled manually or using PWM input or using ambient light automatically. -config LEDS_LM3533 - tristate "LED support for LM3533" - depends on LEDS_CLASS - depends on MFD_LM3533 - help - This option enables support for the LEDs on National Semiconductor / - TI LM3533 Lighting Power chips. - - The LEDs can be controlled directly, through PWM input, or by the - ambient-light-sensor interface. The chip supports - hardware-accelerated blinking with maximum on and off periods of 9.8 - and 77 seconds respectively. - config LEDS_LM3642 tristate "LED support for LM3642 Chip" depends on LEDS_CLASS && I2C diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index effdfc6f1e95..6bc8c412d3ac 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -38,7 +38,6 @@ obj-$(CONFIG_LEDS_IS31FL319X) += leds-is31fl319x.o obj-$(CONFIG_LEDS_IS31FL32XX) += leds-is31fl32xx.o obj-$(CONFIG_LEDS_LM3530) += leds-lm3530.o obj-$(CONFIG_LEDS_LM3532) += leds-lm3532.o -obj-$(CONFIG_LEDS_LM3533) += leds-lm3533.o obj-$(CONFIG_LEDS_LM355x) += leds-lm355x.o obj-$(CONFIG_LEDS_LM36274) += leds-lm36274.o obj-$(CONFIG_LEDS_LM3642) += leds-lm3642.o diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c deleted file mode 100644 index a3d33165d262..000000000000 --- a/drivers/leds/leds-lm3533.c +++ /dev/null @@ -1,755 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-or-later -/* - * leds-lm3533.c -- LM3533 LED driver - * - * Copyright (C) 2011-2012 Texas Instruments - * - * Author: Johan Hovold - */ - -#include -#include -#include -#include -#include -#include - -#include - - -#define LM3533_LVCTRLBANK_MIN 2 -#define LM3533_LVCTRLBANK_MAX 5 -#define LM3533_LVCTRLBANK_COUNT 4 -#define LM3533_RISEFALLTIME_MAX 7 -#define LM3533_ALS_CHANNEL_LV_MIN 1 -#define LM3533_ALS_CHANNEL_LV_MAX 2 - -#define LM3533_REG_CTRLBANK_BCONF_BASE 0x1b -#define LM3533_REG_PATTERN_ENABLE 0x28 -#define LM3533_REG_PATTERN_LOW_TIME_BASE 0x71 -#define LM3533_REG_PATTERN_HIGH_TIME_BASE 0x72 -#define LM3533_REG_PATTERN_RISETIME_BASE 0x74 -#define LM3533_REG_PATTERN_FALLTIME_BASE 0x75 - -#define LM3533_REG_PATTERN_STEP 0x10 - -#define LM3533_REG_CTRLBANK_BCONF_MAPPING_MASK 0x04 -#define LM3533_REG_CTRLBANK_BCONF_ALS_EN_MASK 0x02 -#define LM3533_REG_CTRLBANK_BCONF_ALS_CHANNEL_MASK 0x01 - -#define LM3533_LED_FLAG_PATTERN_ENABLE 1 - - -struct lm3533_led { - struct lm3533 *lm3533; - struct lm3533_ctrlbank cb; - struct led_classdev cdev; - int id; - - struct mutex mutex; - unsigned long flags; -}; - - -static inline struct lm3533_led *to_lm3533_led(struct led_classdev *cdev) -{ - return container_of(cdev, struct lm3533_led, cdev); -} - -static inline int lm3533_led_get_ctrlbank_id(struct lm3533_led *led) -{ - return led->id + 2; -} - -static inline u8 lm3533_led_get_lv_reg(struct lm3533_led *led, u8 base) -{ - return base + led->id; -} - -static inline u8 lm3533_led_get_pattern(struct lm3533_led *led) -{ - return led->id; -} - -static inline u8 lm3533_led_get_pattern_reg(struct lm3533_led *led, - u8 base) -{ - return base + lm3533_led_get_pattern(led) * LM3533_REG_PATTERN_STEP; -} - -static int lm3533_led_pattern_enable(struct lm3533_led *led, int enable) -{ - u8 mask; - u8 val; - int pattern; - int state; - int ret = 0; - - dev_dbg(led->cdev.dev, "%s - %d\n", __func__, enable); - - mutex_lock(&led->mutex); - - state = test_bit(LM3533_LED_FLAG_PATTERN_ENABLE, &led->flags); - if ((enable && state) || (!enable && !state)) - goto out; - - pattern = lm3533_led_get_pattern(led); - mask = 1 << (2 * pattern); - - if (enable) - val = mask; - else - val = 0; - - ret = lm3533_update(led->lm3533, LM3533_REG_PATTERN_ENABLE, val, mask); - if (ret) { - dev_err(led->cdev.dev, "failed to enable pattern %d (%d)\n", - pattern, enable); - goto out; - } - - __change_bit(LM3533_LED_FLAG_PATTERN_ENABLE, &led->flags); -out: - mutex_unlock(&led->mutex); - - return ret; -} - -static int lm3533_led_set(struct led_classdev *cdev, - enum led_brightness value) -{ - struct lm3533_led *led = to_lm3533_led(cdev); - - dev_dbg(led->cdev.dev, "%s - %d\n", __func__, value); - - if (value == 0) - lm3533_led_pattern_enable(led, 0); /* disable blink */ - - return lm3533_ctrlbank_set_brightness(&led->cb, value); -} - -static enum led_brightness lm3533_led_get(struct led_classdev *cdev) -{ - struct lm3533_led *led = to_lm3533_led(cdev); - u8 val; - int ret; - - ret = lm3533_ctrlbank_get_brightness(&led->cb, &val); - if (ret) - return ret; - - dev_dbg(led->cdev.dev, "%s - %u\n", __func__, val); - - return val; -} - -/* Pattern generator defines (delays in us). */ -#define LM3533_LED_DELAY1_VMIN 0x00 -#define LM3533_LED_DELAY2_VMIN 0x3d -#define LM3533_LED_DELAY3_VMIN 0x80 - -#define LM3533_LED_DELAY1_VMAX (LM3533_LED_DELAY2_VMIN - 1) -#define LM3533_LED_DELAY2_VMAX (LM3533_LED_DELAY3_VMIN - 1) -#define LM3533_LED_DELAY3_VMAX 0xff - -#define LM3533_LED_DELAY1_TMIN 16384U -#define LM3533_LED_DELAY2_TMIN 1130496U -#define LM3533_LED_DELAY3_TMIN 10305536U - -#define LM3533_LED_DELAY1_TMAX 999424U -#define LM3533_LED_DELAY2_TMAX 9781248U -#define LM3533_LED_DELAY3_TMAX 76890112U - -/* t_step = (t_max - t_min) / (v_max - v_min) */ -#define LM3533_LED_DELAY1_TSTEP 16384 -#define LM3533_LED_DELAY2_TSTEP 131072 -#define LM3533_LED_DELAY3_TSTEP 524288 - -/* Delay limits for hardware accelerated blinking (in ms). */ -#define LM3533_LED_DELAY_ON_MAX \ - ((LM3533_LED_DELAY2_TMAX + LM3533_LED_DELAY2_TSTEP / 2) / 1000) -#define LM3533_LED_DELAY_OFF_MAX \ - ((LM3533_LED_DELAY3_TMAX + LM3533_LED_DELAY3_TSTEP / 2) / 1000) - -/* - * Returns linear map of *t from [t_min,t_max] to [v_min,v_max] with a step - * size of t_step, where - * - * t_step = (t_max - t_min) / (v_max - v_min) - * - * and updates *t to reflect the mapped value. - */ -static u8 time_to_val(unsigned *t, unsigned t_min, unsigned t_step, - u8 v_min, u8 v_max) -{ - unsigned val; - - val = (*t + t_step / 2 - t_min) / t_step + v_min; - - *t = t_step * (val - v_min) + t_min; - - return (u8)val; -} - -/* - * Returns time code corresponding to *delay (in ms) and updates *delay to - * reflect actual hardware delay. - * - * Hardware supports 256 discrete delay times, divided into three groups with - * the following ranges and step-sizes: - * - * [ 16, 999] [0x00, 0x3e] step 16 ms - * [ 1130, 9781] [0x3d, 0x7f] step 131 ms - * [10306, 76890] [0x80, 0xff] step 524 ms - * - * Note that delay group 3 is only available for delay_off. - */ -static u8 lm3533_led_get_hw_delay(unsigned *delay) -{ - unsigned t; - u8 val; - - t = *delay * 1000; - - if (t >= (LM3533_LED_DELAY2_TMAX + LM3533_LED_DELAY3_TMIN) / 2) { - t = clamp(t, LM3533_LED_DELAY3_TMIN, LM3533_LED_DELAY3_TMAX); - val = time_to_val(&t, LM3533_LED_DELAY3_TMIN, - LM3533_LED_DELAY3_TSTEP, - LM3533_LED_DELAY3_VMIN, - LM3533_LED_DELAY3_VMAX); - } else if (t >= (LM3533_LED_DELAY1_TMAX + LM3533_LED_DELAY2_TMIN) / 2) { - t = clamp(t, LM3533_LED_DELAY2_TMIN, LM3533_LED_DELAY2_TMAX); - val = time_to_val(&t, LM3533_LED_DELAY2_TMIN, - LM3533_LED_DELAY2_TSTEP, - LM3533_LED_DELAY2_VMIN, - LM3533_LED_DELAY2_VMAX); - } else { - t = clamp(t, LM3533_LED_DELAY1_TMIN, LM3533_LED_DELAY1_TMAX); - val = time_to_val(&t, LM3533_LED_DELAY1_TMIN, - LM3533_LED_DELAY1_TSTEP, - LM3533_LED_DELAY1_VMIN, - LM3533_LED_DELAY1_VMAX); - } - - *delay = (t + 500) / 1000; - - return val; -} - -/* - * Set delay register base to *delay (in ms) and update *delay to reflect - * actual hardware delay used. - */ -static u8 lm3533_led_delay_set(struct lm3533_led *led, u8 base, - unsigned long *delay) -{ - unsigned t; - u8 val; - u8 reg; - int ret; - - t = (unsigned)*delay; - - /* Delay group 3 is only available for low time (delay off). */ - if (base != LM3533_REG_PATTERN_LOW_TIME_BASE) - t = min(t, LM3533_LED_DELAY2_TMAX / 1000); - - val = lm3533_led_get_hw_delay(&t); - - dev_dbg(led->cdev.dev, "%s - %lu: %u (0x%02x)\n", __func__, - *delay, t, val); - reg = lm3533_led_get_pattern_reg(led, base); - ret = lm3533_write(led->lm3533, reg, val); - if (ret) - dev_err(led->cdev.dev, "failed to set delay (%02x)\n", reg); - - *delay = t; - - return ret; -} - -static int lm3533_led_delay_on_set(struct lm3533_led *led, unsigned long *t) -{ - return lm3533_led_delay_set(led, LM3533_REG_PATTERN_HIGH_TIME_BASE, t); -} - -static int lm3533_led_delay_off_set(struct lm3533_led *led, unsigned long *t) -{ - return lm3533_led_delay_set(led, LM3533_REG_PATTERN_LOW_TIME_BASE, t); -} - -static int lm3533_led_blink_set(struct led_classdev *cdev, - unsigned long *delay_on, - unsigned long *delay_off) -{ - struct lm3533_led *led = to_lm3533_led(cdev); - int ret; - - dev_dbg(led->cdev.dev, "%s - on = %lu, off = %lu\n", __func__, - *delay_on, *delay_off); - - if (*delay_on > LM3533_LED_DELAY_ON_MAX || - *delay_off > LM3533_LED_DELAY_OFF_MAX) - return -EINVAL; - - if (*delay_on == 0 && *delay_off == 0) { - *delay_on = 500; - *delay_off = 500; - } - - ret = lm3533_led_delay_on_set(led, delay_on); - if (ret) - return ret; - - ret = lm3533_led_delay_off_set(led, delay_off); - if (ret) - return ret; - - return lm3533_led_pattern_enable(led, 1); -} - -static ssize_t show_id(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - - return sysfs_emit(buf, "%d\n", led->id); -} - -/* - * Pattern generator rise/fall times: - * - * 0 - 2048 us (default) - * 1 - 262 ms - * 2 - 524 ms - * 3 - 1.049 s - * 4 - 2.097 s - * 5 - 4.194 s - * 6 - 8.389 s - * 7 - 16.78 s - */ -static ssize_t show_risefalltime(struct device *dev, - struct device_attribute *attr, - char *buf, u8 base) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - ssize_t ret; - u8 reg; - u8 val; - - reg = lm3533_led_get_pattern_reg(led, base); - ret = lm3533_read(led->lm3533, reg, &val); - if (ret) - return ret; - - return sysfs_emit(buf, "%x\n", val); -} - -static ssize_t show_risetime(struct device *dev, - struct device_attribute *attr, char *buf) -{ - return show_risefalltime(dev, attr, buf, - LM3533_REG_PATTERN_RISETIME_BASE); -} - -static ssize_t show_falltime(struct device *dev, - struct device_attribute *attr, char *buf) -{ - return show_risefalltime(dev, attr, buf, - LM3533_REG_PATTERN_FALLTIME_BASE); -} - -static ssize_t store_risefalltime(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len, u8 base) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - u8 val; - u8 reg; - int ret; - - if (kstrtou8(buf, 0, &val) || val > LM3533_RISEFALLTIME_MAX) - return -EINVAL; - - reg = lm3533_led_get_pattern_reg(led, base); - ret = lm3533_write(led->lm3533, reg, val); - if (ret) - return ret; - - return len; -} - -static ssize_t store_risetime(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - return store_risefalltime(dev, attr, buf, len, - LM3533_REG_PATTERN_RISETIME_BASE); -} - -static ssize_t store_falltime(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - return store_risefalltime(dev, attr, buf, len, - LM3533_REG_PATTERN_FALLTIME_BASE); -} - -static ssize_t show_als_channel(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - unsigned channel; - u8 reg; - u8 val; - int ret; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - ret = lm3533_read(led->lm3533, reg, &val); - if (ret) - return ret; - - channel = (val & LM3533_REG_CTRLBANK_BCONF_ALS_CHANNEL_MASK) + 1; - - return sysfs_emit(buf, "%u\n", channel); -} - -static ssize_t store_als_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - unsigned channel; - u8 reg; - u8 val; - u8 mask; - int ret; - - if (kstrtouint(buf, 0, &channel)) - return -EINVAL; - - if (channel < LM3533_ALS_CHANNEL_LV_MIN || - channel > LM3533_ALS_CHANNEL_LV_MAX) - return -EINVAL; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - mask = LM3533_REG_CTRLBANK_BCONF_ALS_CHANNEL_MASK; - val = channel - 1; - - ret = lm3533_update(led->lm3533, reg, val, mask); - if (ret) - return ret; - - return len; -} - -static ssize_t show_als_en(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - bool enable; - u8 reg; - u8 val; - int ret; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - ret = lm3533_read(led->lm3533, reg, &val); - if (ret) - return ret; - - enable = val & LM3533_REG_CTRLBANK_BCONF_ALS_EN_MASK; - - return sysfs_emit(buf, "%d\n", enable); -} - -static ssize_t store_als_en(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - unsigned enable; - u8 reg; - u8 mask; - u8 val; - int ret; - - if (kstrtouint(buf, 0, &enable)) - return -EINVAL; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - mask = LM3533_REG_CTRLBANK_BCONF_ALS_EN_MASK; - - if (enable) - val = mask; - else - val = 0; - - ret = lm3533_update(led->lm3533, reg, val, mask); - if (ret) - return ret; - - return len; -} - -static ssize_t show_linear(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - u8 reg; - u8 val; - int linear; - int ret; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - ret = lm3533_read(led->lm3533, reg, &val); - if (ret) - return ret; - - if (val & LM3533_REG_CTRLBANK_BCONF_MAPPING_MASK) - linear = 1; - else - linear = 0; - - return sysfs_emit(buf, "%x\n", linear); -} - -static ssize_t store_linear(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - unsigned long linear; - u8 reg; - u8 mask; - u8 val; - int ret; - - if (kstrtoul(buf, 0, &linear)) - return -EINVAL; - - reg = lm3533_led_get_lv_reg(led, LM3533_REG_CTRLBANK_BCONF_BASE); - mask = LM3533_REG_CTRLBANK_BCONF_MAPPING_MASK; - - if (linear) - val = mask; - else - val = 0; - - ret = lm3533_update(led->lm3533, reg, val, mask); - if (ret) - return ret; - - return len; -} - -static ssize_t show_pwm(struct device *dev, - struct device_attribute *attr, - char *buf) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - u8 val; - int ret; - - ret = lm3533_ctrlbank_get_pwm(&led->cb, &val); - if (ret) - return ret; - - return sysfs_emit(buf, "%u\n", val); -} - -static ssize_t store_pwm(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - u8 val; - int ret; - - if (kstrtou8(buf, 0, &val)) - return -EINVAL; - - ret = lm3533_ctrlbank_set_pwm(&led->cb, val); - if (ret) - return ret; - - return len; -} - -static LM3533_ATTR_RW(als_channel); -static LM3533_ATTR_RW(als_en); -static LM3533_ATTR_RW(falltime); -static LM3533_ATTR_RO(id); -static LM3533_ATTR_RW(linear); -static LM3533_ATTR_RW(pwm); -static LM3533_ATTR_RW(risetime); - -static struct attribute *lm3533_led_attributes[] = { - &dev_attr_als_channel.attr, - &dev_attr_als_en.attr, - &dev_attr_falltime.attr, - &dev_attr_id.attr, - &dev_attr_linear.attr, - &dev_attr_pwm.attr, - &dev_attr_risetime.attr, - NULL, -}; - -static umode_t lm3533_led_attr_is_visible(struct kobject *kobj, - struct attribute *attr, int n) -{ - struct device *dev = kobj_to_dev(kobj); - struct led_classdev *led_cdev = dev_get_drvdata(dev); - struct lm3533_led *led = to_lm3533_led(led_cdev); - umode_t mode = attr->mode; - - if (attr == &dev_attr_als_channel.attr || - attr == &dev_attr_als_en.attr) { - if (!led->lm3533->have_als) - mode = 0; - } - - return mode; -}; - -static const struct attribute_group lm3533_led_attribute_group = { - .is_visible = lm3533_led_attr_is_visible, - .attrs = lm3533_led_attributes -}; - -static const struct attribute_group *lm3533_led_attribute_groups[] = { - &lm3533_led_attribute_group, - NULL -}; - -static int lm3533_led_setup(struct lm3533_led *led, - struct lm3533_led_platform_data *pdata) -{ - int ret; - - ret = lm3533_ctrlbank_set_max_current(&led->cb, pdata->max_current); - if (ret) - return ret; - - return lm3533_ctrlbank_set_pwm(&led->cb, pdata->pwm); -} - -static int lm3533_led_probe(struct platform_device *pdev) -{ - struct lm3533 *lm3533; - struct lm3533_led_platform_data *pdata; - struct lm3533_led *led; - int ret; - - dev_dbg(&pdev->dev, "%s\n", __func__); - - lm3533 = dev_get_drvdata(pdev->dev.parent); - if (!lm3533) - return -EINVAL; - - pdata = dev_get_platdata(&pdev->dev); - if (!pdata) { - dev_err(&pdev->dev, "no platform data\n"); - return -EINVAL; - } - - if (pdev->id < 0 || pdev->id >= LM3533_LVCTRLBANK_COUNT) { - dev_err(&pdev->dev, "illegal LED id %d\n", pdev->id); - return -EINVAL; - } - - led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL); - if (!led) - return -ENOMEM; - - led->lm3533 = lm3533; - led->cdev.name = pdata->name; - led->cdev.default_trigger = pdata->default_trigger; - led->cdev.brightness_set_blocking = lm3533_led_set; - led->cdev.brightness_get = lm3533_led_get; - led->cdev.blink_set = lm3533_led_blink_set; - led->cdev.brightness = LED_OFF; - led->cdev.groups = lm3533_led_attribute_groups; - led->id = pdev->id; - - mutex_init(&led->mutex); - - /* The class framework makes a callback to get brightness during - * registration so use parent device (for error reporting) until - * registered. - */ - led->cb.lm3533 = lm3533; - led->cb.id = lm3533_led_get_ctrlbank_id(led); - led->cb.dev = lm3533->dev; - - platform_set_drvdata(pdev, led); - - ret = led_classdev_register(pdev->dev.parent, &led->cdev); - if (ret) { - dev_err(&pdev->dev, "failed to register LED %d\n", pdev->id); - return ret; - } - - led->cb.dev = led->cdev.dev; - - ret = lm3533_led_setup(led, pdata); - if (ret) - goto err_deregister; - - ret = lm3533_ctrlbank_enable(&led->cb); - if (ret) - goto err_deregister; - - return 0; - -err_deregister: - led_classdev_unregister(&led->cdev); - - return ret; -} - -static void lm3533_led_remove(struct platform_device *pdev) -{ - struct lm3533_led *led = platform_get_drvdata(pdev); - - dev_dbg(&pdev->dev, "%s\n", __func__); - - lm3533_ctrlbank_disable(&led->cb); - led_classdev_unregister(&led->cdev); -} - -static void lm3533_led_shutdown(struct platform_device *pdev) -{ - - struct lm3533_led *led = platform_get_drvdata(pdev); - - dev_dbg(&pdev->dev, "%s\n", __func__); - - lm3533_ctrlbank_disable(&led->cb); - lm3533_led_set(&led->cdev, LED_OFF); /* disable blink */ -} - -static struct platform_driver lm3533_led_driver = { - .driver = { - .name = "lm3533-leds", - }, - .probe = lm3533_led_probe, - .remove_new = lm3533_led_remove, - .shutdown = lm3533_led_shutdown, -}; -module_platform_driver(lm3533_led_driver); - -MODULE_AUTHOR("Johan Hovold "); -MODULE_DESCRIPTION("LM3533 LED driver"); -MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:lm3533-leds");