| Message ID | 20240604015134.164206-13-baolu.lu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu: Refactoring domain allocation interface | expand |
Lu Baolu <baolu.lu@linux.intel.com> writes: > An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is > attached to ab_ahb->fw.dev in the same function. > > Use iommu_paging_domain_alloc() to make it explicit. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > --- > drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c > index ca0f17ddebba..a469647719f9 100644 > --- a/drivers/net/wireless/ath/ath11k/ahb.c > +++ b/drivers/net/wireless/ath/ath11k/ahb.c > @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab) > > ab_ahb->fw.dev = &pdev->dev; > > - iommu_dom = iommu_domain_alloc(&platform_bus_type); > - if (!iommu_dom) { > + iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev); > + if (IS_ERR(iommu_dom)) { > ath11k_err(ab, "failed to allocate iommu domain\n"); > - ret = -ENOMEM; > + ret = PTR_ERR(iommu_dom); > goto err_unregister; > } Adding Jeff and ath11k list so that they can review this as well.
On 6/3/24 18:51, Lu Baolu wrote: > An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is > attached to ab_ahb->fw.dev in the same function. > > Use iommu_paging_domain_alloc() to make it explicit. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c > index ca0f17ddebba..a469647719f9 100644 > --- a/drivers/net/wireless/ath/ath11k/ahb.c > +++ b/drivers/net/wireless/ath/ath11k/ahb.c > @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab) > > ab_ahb->fw.dev = &pdev->dev; > > - iommu_dom = iommu_domain_alloc(&platform_bus_type); > - if (!iommu_dom) { > + iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev); > + if (IS_ERR(iommu_dom)) { > ath11k_err(ab, "failed to allocate iommu domain\n"); > - ret = -ENOMEM; > + ret = PTR_ERR(iommu_dom); > goto err_unregister; > } >
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index ca0f17ddebba..a469647719f9 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab) ab_ahb->fw.dev = &pdev->dev; - iommu_dom = iommu_domain_alloc(&platform_bus_type); - if (!iommu_dom) { + iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev); + if (IS_ERR(iommu_dom)) { ath11k_err(ab, "failed to allocate iommu domain\n"); - ret = -ENOMEM; + ret = PTR_ERR(iommu_dom); goto err_unregister; }
An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is attached to ab_ahb->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)