From patchwork Thu Jun 20 13:35:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13705528 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B272C27C79 for ; Thu, 20 Jun 2024 13:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3060B10E9DF; Thu, 20 Jun 2024 13:35:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X762k1oG"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0089610E9DF for ; Thu, 20 Jun 2024 13:35:35 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 54078621A6; Thu, 20 Jun 2024 13:35:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E9B9C32786; Thu, 20 Jun 2024 13:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718890535; bh=5tYVYfhQ8AgDhKqY9oLsQ7bOinioICIDD6Nq7WRjn+U=; h=From:To:Cc:Subject:Date:From; b=X762k1oGLZKF7Cl1FWlBDIiH354n9HkPPslE3bLQYYWYSFlSrOikylk6qdVQxm5Cq XxmC5SiKhpEb1rcpJHoHQWmzUjm5P0o0DYgC2+K2/IcTOSySrDHCpE0mjnMm5DzOdo vj/ZvNkO21YCB3dC02Vf6P+kgaJJKVf6tOp97U9dREcgb4MxnlUosaJIWE7y54cGHP t+FA6V5g9zF1hHx+NHsGbucqXrywXop/D60/DvoLdpwe9txWYYHciXBlzdzy1nHgtI MwyQjotlanGi1VMtYkbMoqEZ2+0cdoJjPNBVSDthrzrH2hEw7iDUTTYXrY9Yi2A2eP 9jYw9331jLI5w== From: Maxime Ripard To: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Javier Martinez Canillas , Dmitry Baryshkov Subject: [PATCH v2 1/3] drm/todo: Create a TODO item for additional HDMI work Date: Thu, 20 Jun 2024 15:35:29 +0200 Message-ID: <20240620133531.3954622-1-mripard@kernel.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We recently added some infrastructure to deal with HDMI but we're still lacking a couple of things. Add a TODO entry with the remaining items. Cc: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- Changes from v1: - Add sound and HDCP --- Documentation/gpu/todo.rst | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 2ea6ffc9b22b..3104ffbd6295 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -633,10 +633,46 @@ long as that supports DMA. Otherwise importing can still needlessly fail. Contact: Thomas Zimmermann , Daniel Vetter Level: Advanced +Improve HDMI Infrastructure +--------------------------- + +We have a bunch of helpers to handle HDMI and reduce the boilerplate in +drivers. Support so far includes HDMI 1.4 support, but we need to extend +it with: + + - CEC handling support. CEC requires a bit of integration into every + HDMI driver to set the device physical address according to the EDID + in `.get_modes`, and to clear/reset it in the hotplug detection + path. We should create the ``drm_atomic_helper_connector_hdmi_get_modes()`` + and ``drm_atomic_helper_connector_hdmi_handle_hotplug()`` helpers to handle + this properly, and convert drivers to use them. + + - In order to support HDMI 2.0 properly, the scrambler parameters need + to be moved into the state. This includes figuring out in + drm_atomic_helper_connector_hdmi_check() if the scrambler and TMDS ratio + need to be changed, and make the + ``drm_atomic_helper_connector_hdmi_handle_hotplug()`` helper reset the + scrambler status when the device is plugged and unplugged. + + - We need to support YUV420 too. + + - Make the audio support somewhat generic too. The lowest hanging fruits + would be to provide helpers for `get_eld`, to handle hotplug and compute + ACR, N, and CTS parameters. + + - Handling HDCP in a generic manner would be a good idea too. + See `[PATCH v10 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers `_ + +The `vc4` driver is a good example for all this. + +Contact: Maxime Ripard + +Level: Intermediate + Better Testing ============== Add unit tests using the Kernel Unit Testing (KUnit) framework