| Message ID | 20240623193420.333735-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/msm/adreno: allow headless setup on SM8150 MTP | expand |
On 6/23/24 21:34, Krzysztof Kozlowski wrote: > Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used > amd,imageon compatible for the SM8150 just to enable headless mode due > to missing display controller nodes. This work-around was later > narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: > qcom: sm8150: Don't start Adreno in headless mode"). > > This was not a correct solution, because the Qualcomm SM8150 SoC does > not have an AMD GPU and the SM8150 MTP board does not have magically > different GPU than SM8150 SoC. > > Rely on board compatible to achieve the same in a Devicetree-correct > way. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Let's just forget this exists, this was a hack from the start and not a very necessary one given display bringup followed soon.. This should be handled by a module parameter if anything Konrad
On 24/06/2024 16:06, Konrad Dybcio wrote: > > > On 6/23/24 21:34, Krzysztof Kozlowski wrote: >> Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used >> amd,imageon compatible for the SM8150 just to enable headless mode due >> to missing display controller nodes. This work-around was later >> narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: >> qcom: sm8150: Don't start Adreno in headless mode"). >> >> This was not a correct solution, because the Qualcomm SM8150 SoC does >> not have an AMD GPU and the SM8150 MTP board does not have magically >> different GPU than SM8150 SoC. >> >> Rely on board compatible to achieve the same in a Devicetree-correct >> way. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > > Let's just forget this exists, this was a hack from the start and not > a very necessary one given display bringup followed soon.. > This will affect SM8150-MTP, but I don't mind. This patch can be just ignored and only the second patch - DTS - picked up via Qcom soc. Best regards, Krzysztof
On Mon, Jun 24, 2024 at 04:06:24PM GMT, Konrad Dybcio wrote: > > > On 6/23/24 21:34, Krzysztof Kozlowski wrote: > > Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used > > amd,imageon compatible for the SM8150 just to enable headless mode due > > to missing display controller nodes. This work-around was later > > narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: > > qcom: sm8150: Don't start Adreno in headless mode"). > > > > This was not a correct solution, because the Qualcomm SM8150 SoC does > > not have an AMD GPU and the SM8150 MTP board does not have magically > > different GPU than SM8150 SoC. > > > > Rely on board compatible to achieve the same in a Devicetree-correct > > way. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Let's just forget this exists, this was a hack from the start and not > a very necessary one given display bringup followed soon.. > > This should be handled by a module parameter if anything We discussed having a modparam for separate KMS and GPU msm drivers, but I've never implemented it.
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index c3703a51287b..a8afe0b6429b 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -838,7 +838,8 @@ static int adreno_probe(struct platform_device *pdev) if (ret) return ret; - if (of_device_is_compatible(pdev->dev.of_node, "amd,imageon")) + if (of_device_is_compatible(pdev->dev.of_node, "amd,imageon") || + of_machine_is_compatible("qcom,sm8150-mtp")) adreno_device_register_headless(); return 0;
Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used amd,imageon compatible for the SM8150 just to enable headless mode due to missing display controller nodes. This work-around was later narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: qcom: sm8150: Don't start Adreno in headless mode"). This was not a correct solution, because the Qualcomm SM8150 SoC does not have an AMD GPU and the SM8150 MTP board does not have magically different GPU than SM8150 SoC. Rely on board compatible to achieve the same in a Devicetree-correct way. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)