| Message ID | 20240624031158.98502-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: Use ARRAY_SIZE for array length | expand |
Applied. Thanks! On Sun, Jun 23, 2024 at 11:37 PM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > Use of macro ARRAY_SIZE to calculate array size minimizes > the redundant code and improves code reusability. > > ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:164:45-46: WARNING: Use ARRAY_SIZE. > ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:183:47-48: WARNING: Use ARRAY_SIZE. > ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:237:45-46: WARNING: Use ARRAY_SIZE. > ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:257:47-48: WARNING: Use ARRAY_SIZE. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9405 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c > index 1b2df97226a3..7ecf76aea950 100644 > --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c > +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c > @@ -161,8 +161,7 @@ static enum mod_hdcp_status read(struct mod_hdcp *hdcp, > return MOD_HDCP_STATUS_DDC_FAILURE; > > if (is_dp_hdcp(hdcp)) { > - int num_dpcd_addrs = sizeof(hdcp_dpcd_addrs) / > - sizeof(hdcp_dpcd_addrs[0]); > + int num_dpcd_addrs = ARRAY_SIZE(hdcp_dpcd_addrs); > if (msg_id >= num_dpcd_addrs) > return MOD_HDCP_STATUS_DDC_FAILURE; > > @@ -180,8 +179,7 @@ static enum mod_hdcp_status read(struct mod_hdcp *hdcp, > data_offset += cur_size; > } > } else { > - int num_i2c_offsets = sizeof(hdcp_i2c_offsets) / > - sizeof(hdcp_i2c_offsets[0]); > + int num_i2c_offsets = ARRAY_SIZE(hdcp_i2c_offsets); > if (msg_id >= num_i2c_offsets) > return MOD_HDCP_STATUS_DDC_FAILURE; > > @@ -234,8 +232,7 @@ static enum mod_hdcp_status write(struct mod_hdcp *hdcp, > return MOD_HDCP_STATUS_DDC_FAILURE; > > if (is_dp_hdcp(hdcp)) { > - int num_dpcd_addrs = sizeof(hdcp_dpcd_addrs) / > - sizeof(hdcp_dpcd_addrs[0]); > + int num_dpcd_addrs = ARRAY_SIZE(hdcp_dpcd_addrs); > if (msg_id >= num_dpcd_addrs) > return MOD_HDCP_STATUS_DDC_FAILURE; > > @@ -254,8 +251,7 @@ static enum mod_hdcp_status write(struct mod_hdcp *hdcp, > data_offset += cur_size; > } > } else { > - int num_i2c_offsets = sizeof(hdcp_i2c_offsets) / > - sizeof(hdcp_i2c_offsets[0]); > + int num_i2c_offsets = ARRAY_SIZE(hdcp_i2c_offsets); > if (msg_id >= num_i2c_offsets) > return MOD_HDCP_STATUS_DDC_FAILURE; > > -- > 2.20.1.7.g153144c >
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c index 1b2df97226a3..7ecf76aea950 100644 --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c @@ -161,8 +161,7 @@ static enum mod_hdcp_status read(struct mod_hdcp *hdcp, return MOD_HDCP_STATUS_DDC_FAILURE; if (is_dp_hdcp(hdcp)) { - int num_dpcd_addrs = sizeof(hdcp_dpcd_addrs) / - sizeof(hdcp_dpcd_addrs[0]); + int num_dpcd_addrs = ARRAY_SIZE(hdcp_dpcd_addrs); if (msg_id >= num_dpcd_addrs) return MOD_HDCP_STATUS_DDC_FAILURE; @@ -180,8 +179,7 @@ static enum mod_hdcp_status read(struct mod_hdcp *hdcp, data_offset += cur_size; } } else { - int num_i2c_offsets = sizeof(hdcp_i2c_offsets) / - sizeof(hdcp_i2c_offsets[0]); + int num_i2c_offsets = ARRAY_SIZE(hdcp_i2c_offsets); if (msg_id >= num_i2c_offsets) return MOD_HDCP_STATUS_DDC_FAILURE; @@ -234,8 +232,7 @@ static enum mod_hdcp_status write(struct mod_hdcp *hdcp, return MOD_HDCP_STATUS_DDC_FAILURE; if (is_dp_hdcp(hdcp)) { - int num_dpcd_addrs = sizeof(hdcp_dpcd_addrs) / - sizeof(hdcp_dpcd_addrs[0]); + int num_dpcd_addrs = ARRAY_SIZE(hdcp_dpcd_addrs); if (msg_id >= num_dpcd_addrs) return MOD_HDCP_STATUS_DDC_FAILURE; @@ -254,8 +251,7 @@ static enum mod_hdcp_status write(struct mod_hdcp *hdcp, data_offset += cur_size; } } else { - int num_i2c_offsets = sizeof(hdcp_i2c_offsets) / - sizeof(hdcp_i2c_offsets[0]); + int num_i2c_offsets = ARRAY_SIZE(hdcp_i2c_offsets); if (msg_id >= num_i2c_offsets) return MOD_HDCP_STATUS_DDC_FAILURE;
Use of macro ARRAY_SIZE to calculate array size minimizes the redundant code and improves code reusability. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:164:45-46: WARNING: Use ARRAY_SIZE. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:183:47-48: WARNING: Use ARRAY_SIZE. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:237:45-46: WARNING: Use ARRAY_SIZE. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:257:47-48: WARNING: Use ARRAY_SIZE. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9405 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)